blob: caac8c302fbc3fc94b276a615c87097e86d5dd86 [file] [log] [blame]
developer20747c12022-09-16 14:09:40 +08001From e7fac7c5c91fbabafa530abdf32cf11dd36834d7 Mon Sep 17 00:00:00 2001
developer20d67712022-03-02 14:09:32 +08002From: Shayne Chen <shayne.chen@mediatek.com>
3Date: Fri, 25 Feb 2022 09:36:01 +0800
developer20747c12022-09-16 14:09:40 +08004Subject: [PATCH 2/7] mt76: testmode: rework tx antenna setting
developer20d67712022-03-02 14:09:32 +08005
6---
developer5ce5ea42022-08-31 14:12:29 +08007 mt7915/mcu.c | 7 +------
developer5e5d6802022-09-01 10:53:06 +08008 mt7915/testmode.c | 13 ++++++-------
developer5ce5ea42022-08-31 14:12:29 +08009 testmode.c | 3 +--
developer5e5d6802022-09-01 10:53:06 +080010 3 files changed, 8 insertions(+), 15 deletions(-)
developer20d67712022-03-02 14:09:32 +080011
12diff --git a/mt7915/mcu.c b/mt7915/mcu.c
developer20747c12022-09-16 14:09:40 +080013index 3586a8e3..d9c9805b 100644
developer20d67712022-03-02 14:09:32 +080014--- a/mt7915/mcu.c
15+++ b/mt7915/mcu.c
developer20747c12022-09-16 14:09:40 +080016@@ -2642,14 +2642,9 @@ int mt7915_mcu_set_chan_info(struct mt7915_phy *phy, int cmd)
developer20d67712022-03-02 14:09:32 +080017
18 #ifdef CONFIG_NL80211_TESTMODE
19 if (phy->mt76->test.tx_antenna_mask &&
20- (phy->mt76->test.state == MT76_TM_STATE_TX_FRAMES ||
21- phy->mt76->test.state == MT76_TM_STATE_RX_FRAMES ||
22- phy->mt76->test.state == MT76_TM_STATE_TX_CONT)) {
23+ mt76_testmode_enabled(phy->mt76)) {
24 req.tx_streams_num = fls(phy->mt76->test.tx_antenna_mask);
25 req.rx_streams = phy->mt76->test.tx_antenna_mask;
26-
27- if (phy != &dev->phy)
28- req.rx_streams >>= dev->chainshift;
29 }
30 #endif
31
32diff --git a/mt7915/testmode.c b/mt7915/testmode.c
developer20747c12022-09-16 14:09:40 +080033index 01866028..41b99496 100644
developer20d67712022-03-02 14:09:32 +080034--- a/mt7915/testmode.c
35+++ b/mt7915/testmode.c
developerf64861f2022-06-22 11:44:53 +080036@@ -474,11 +474,7 @@ mt7915_tm_set_tx_frames(struct mt7915_phy *phy, bool en)
developer20d67712022-03-02 14:09:32 +080037 if (td->tx_spe_idx) {
38 phy->test.spe_idx = td->tx_spe_idx;
39 } else {
40- u8 tx_ant = td->tx_antenna_mask;
41-
42- if (phy != &dev->phy)
43- tx_ant >>= dev->chainshift;
44- phy->test.spe_idx = spe_idx_map[tx_ant];
45+ phy->test.spe_idx = spe_idx_map[td->tx_antenna_mask];
46 }
47 }
48
developer5e5d6802022-09-01 10:53:06 +080049@@ -720,8 +716,10 @@ mt7915_tm_set_params(struct mt76_phy *mphy, struct nlattr **tb,
developer5ce5ea42022-08-31 14:12:29 +080050 {
51 struct mt76_testmode_data *td = &mphy->test;
52 struct mt7915_phy *phy = mphy->priv;
53- u32 changed = 0;
developer5e5d6802022-09-01 10:53:06 +080054+ struct mt7915_dev *dev = phy->dev;
developer5ce5ea42022-08-31 14:12:29 +080055+ u32 chainmask = mphy->chainmask, changed = 0;
56 int i;
57+ bool ext_phy = phy != &dev->phy;
58
59 BUILD_BUG_ON(NUM_TM_CHANGED >= 32);
60
developer5e5d6802022-09-01 10:53:06 +080061@@ -729,7 +727,8 @@ mt7915_tm_set_params(struct mt76_phy *mphy, struct nlattr **tb,
developer20d67712022-03-02 14:09:32 +080062 td->state == MT76_TM_STATE_OFF)
63 return 0;
64
65- if (td->tx_antenna_mask & ~mphy->chainmask)
developer5ce5ea42022-08-31 14:12:29 +080066+ chainmask = ext_phy ? chainmask >> dev->chainshift : chainmask;
67+ if (td->tx_antenna_mask > chainmask)
68 return -EINVAL;
69
developer20d67712022-03-02 14:09:32 +080070 for (i = 0; i < ARRAY_SIZE(tm_change_map); i++) {
developer20d67712022-03-02 14:09:32 +080071diff --git a/testmode.c b/testmode.c
developer20747c12022-09-16 14:09:40 +080072index 0accc71a..57cdfdf6 100644
developer20d67712022-03-02 14:09:32 +080073--- a/testmode.c
74+++ b/testmode.c
developer20747c12022-09-16 14:09:40 +080075@@ -447,8 +447,7 @@ int mt76_testmode_cmd(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
developer20d67712022-03-02 14:09:32 +080076 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_RATE_LDPC], &td->tx_rate_ldpc, 0, 1) ||
77 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_RATE_STBC], &td->tx_rate_stbc, 0, 1) ||
78 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_LTF], &td->tx_ltf, 0, 2) ||
79- mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_ANTENNA],
80- &td->tx_antenna_mask, 0, 0xff) ||
developer5ce5ea42022-08-31 14:12:29 +080081+ mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_ANTENNA], &td->tx_antenna_mask, 1, 0xff) ||
developer20d67712022-03-02 14:09:32 +080082 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_SPE_IDX], &td->tx_spe_idx, 0, 27) ||
83 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_DUTY_CYCLE],
84 &td->tx_duty_cycle, 0, 99) ||
85--
developer20747c12022-09-16 14:09:40 +0800862.25.1
developer20d67712022-03-02 14:09:32 +080087