blob: 4600e99e5486fa2170318e337ace4ed054cd8e17 [file] [log] [blame]
developer5ce5ea42022-08-31 14:12:29 +08001From 29fbf66158df1596d043ed568933f1af424ee2d4 Mon Sep 17 00:00:00 2001
developer20d67712022-03-02 14:09:32 +08002From: Shayne Chen <shayne.chen@mediatek.com>
3Date: Fri, 25 Feb 2022 09:36:01 +0800
developer5ce5ea42022-08-31 14:12:29 +08004Subject: [PATCH 2/8] mt76: testmode: rework tx antenna setting
developer20d67712022-03-02 14:09:32 +08005
6---
developer5ce5ea42022-08-31 14:12:29 +08007 mt7915/mcu.c | 7 +------
8 mt7915/testmode.c | 12 +++++-------
9 testmode.c | 3 +--
10 3 files changed, 7 insertions(+), 15 deletions(-)
developer20d67712022-03-02 14:09:32 +080011
12diff --git a/mt7915/mcu.c b/mt7915/mcu.c
developer5ce5ea42022-08-31 14:12:29 +080013index 7767bfe..e3123f2 100644
developer20d67712022-03-02 14:09:32 +080014--- a/mt7915/mcu.c
15+++ b/mt7915/mcu.c
developer5ce5ea42022-08-31 14:12:29 +080016@@ -2640,14 +2640,9 @@ int mt7915_mcu_set_chan_info(struct mt7915_phy *phy, int cmd)
developer20d67712022-03-02 14:09:32 +080017
18 #ifdef CONFIG_NL80211_TESTMODE
19 if (phy->mt76->test.tx_antenna_mask &&
20- (phy->mt76->test.state == MT76_TM_STATE_TX_FRAMES ||
21- phy->mt76->test.state == MT76_TM_STATE_RX_FRAMES ||
22- phy->mt76->test.state == MT76_TM_STATE_TX_CONT)) {
23+ mt76_testmode_enabled(phy->mt76)) {
24 req.tx_streams_num = fls(phy->mt76->test.tx_antenna_mask);
25 req.rx_streams = phy->mt76->test.tx_antenna_mask;
26-
27- if (phy != &dev->phy)
28- req.rx_streams >>= dev->chainshift;
29 }
30 #endif
31
32diff --git a/mt7915/testmode.c b/mt7915/testmode.c
developer5ce5ea42022-08-31 14:12:29 +080033index 0186602..9d46d69 100644
developer20d67712022-03-02 14:09:32 +080034--- a/mt7915/testmode.c
35+++ b/mt7915/testmode.c
developerf64861f2022-06-22 11:44:53 +080036@@ -474,11 +474,7 @@ mt7915_tm_set_tx_frames(struct mt7915_phy *phy, bool en)
developer20d67712022-03-02 14:09:32 +080037 if (td->tx_spe_idx) {
38 phy->test.spe_idx = td->tx_spe_idx;
39 } else {
40- u8 tx_ant = td->tx_antenna_mask;
41-
42- if (phy != &dev->phy)
43- tx_ant >>= dev->chainshift;
44- phy->test.spe_idx = spe_idx_map[tx_ant];
45+ phy->test.spe_idx = spe_idx_map[td->tx_antenna_mask];
46 }
47 }
48
developer5ce5ea42022-08-31 14:12:29 +080049@@ -720,8 +716,9 @@ mt7915_tm_set_params(struct mt76_phy *mphy, struct nlattr **tb,
50 {
51 struct mt76_testmode_data *td = &mphy->test;
52 struct mt7915_phy *phy = mphy->priv;
53- u32 changed = 0;
54+ u32 chainmask = mphy->chainmask, changed = 0;
55 int i;
56+ bool ext_phy = phy != &dev->phy;
57
58 BUILD_BUG_ON(NUM_TM_CHANGED >= 32);
59
60@@ -729,7 +726,8 @@ mt7915_tm_set_params(struct mt76_phy *mphy, struct nlattr **tb,
developer20d67712022-03-02 14:09:32 +080061 td->state == MT76_TM_STATE_OFF)
62 return 0;
63
64- if (td->tx_antenna_mask & ~mphy->chainmask)
developer5ce5ea42022-08-31 14:12:29 +080065+ chainmask = ext_phy ? chainmask >> dev->chainshift : chainmask;
66+ if (td->tx_antenna_mask > chainmask)
67 return -EINVAL;
68
developer20d67712022-03-02 14:09:32 +080069 for (i = 0; i < ARRAY_SIZE(tm_change_map); i++) {
developer20d67712022-03-02 14:09:32 +080070diff --git a/testmode.c b/testmode.c
developer5ce5ea42022-08-31 14:12:29 +080071index 71fd3fb..74a46e9 100644
developer20d67712022-03-02 14:09:32 +080072--- a/testmode.c
73+++ b/testmode.c
developer5ce5ea42022-08-31 14:12:29 +080074@@ -443,8 +443,7 @@ int mt76_testmode_cmd(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
developer20d67712022-03-02 14:09:32 +080075 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_RATE_LDPC], &td->tx_rate_ldpc, 0, 1) ||
76 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_RATE_STBC], &td->tx_rate_stbc, 0, 1) ||
77 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_LTF], &td->tx_ltf, 0, 2) ||
78- mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_ANTENNA],
79- &td->tx_antenna_mask, 0, 0xff) ||
developer5ce5ea42022-08-31 14:12:29 +080080+ mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_ANTENNA], &td->tx_antenna_mask, 1, 0xff) ||
developer20d67712022-03-02 14:09:32 +080081 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_SPE_IDX], &td->tx_spe_idx, 0, 27) ||
82 mt76_tm_get_u8(tb[MT76_TM_ATTR_TX_DUTY_CYCLE],
83 &td->tx_duty_cycle, 0, 99) ||
84--
developer4721e252022-06-21 16:41:28 +0800852.18.0
developer20d67712022-03-02 14:09:32 +080086