Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 1 | ---------------------- |
| 2 | HAProxy how-to |
| 3 | ---------------------- |
Willy Tarreau | 1a34d57 | 2014-02-03 00:41:29 +0100 | [diff] [blame] | 4 | version 1.5-dev22 |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 5 | willy tarreau |
Willy Tarreau | 1a34d57 | 2014-02-03 00:41:29 +0100 | [diff] [blame] | 6 | 2014/02/03 |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 7 | |
| 8 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 9 | 1) How to build it |
| 10 | ------------------ |
| 11 | |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 12 | To build haproxy, you will need : |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 13 | - GNU make. Neither Solaris nor OpenBSD's make work with the GNU Makefile. |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 14 | However, specific Makefiles for BSD and OSX are provided. |
Willy Tarreau | 32e65ef | 2013-04-02 08:14:29 +0200 | [diff] [blame] | 15 | - GCC between 2.91 and 4.7. Others may work, but not tested. |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 16 | - GNU ld |
| 17 | |
| 18 | Also, you might want to build with libpcre support, which will provide a very |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 19 | efficient regex implementation and will also fix some badness on Solaris' one. |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 20 | |
| 21 | To build haproxy, you have to choose your target OS amongst the following ones |
| 22 | and assign it to the TARGET variable : |
| 23 | |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 24 | - linux22 for Linux 2.2 |
| 25 | - linux24 for Linux 2.4 and above (default) |
| 26 | - linux24e for Linux 2.4 with support for a working epoll (> 0.21) |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 27 | - linux26 for Linux 2.6 and above |
Willy Tarreau | e0c623d | 2012-06-04 00:42:09 +0200 | [diff] [blame] | 28 | - linux2628 for Linux 2.6.28 and above (enables splice and tproxy) |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 29 | - solaris for Solaris 8 or 10 (others untested) |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 30 | - freebsd for FreeBSD 5 to 8.0 (others untested) |
Willy Tarreau | 8624cab | 2013-04-02 08:17:43 +0200 | [diff] [blame] | 31 | - osx for Mac OS/X |
Willy Tarreau | 3b8e979 | 2012-11-22 00:43:09 +0100 | [diff] [blame] | 32 | - openbsd for OpenBSD 3.1 to 5.2 (others untested) |
Willy Tarreau | 50abe30 | 2014-04-02 20:44:43 +0200 | [diff] [blame] | 33 | - aix51 for AIX 5.1 |
Willy Tarreau | 7dec965 | 2012-06-06 16:15:03 +0200 | [diff] [blame] | 34 | - aix52 for AIX 5.2 |
Yitzhak Sapir | 3208731 | 2009-06-14 18:27:54 +0200 | [diff] [blame] | 35 | - cygwin for Cygwin |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 36 | - generic for any other OS. |
| 37 | - custom to manually adjust every setting |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 38 | |
| 39 | You may also choose your CPU to benefit from some optimizations. This is |
| 40 | particularly important on UltraSparc machines. For this, you can assign |
| 41 | one of the following choices to the CPU variable : |
| 42 | |
| 43 | - i686 for intel PentiumPro, Pentium 2 and above, AMD Athlon |
| 44 | - i586 for intel Pentium, AMD K6, VIA C3. |
| 45 | - ultrasparc : Sun UltraSparc I/II/III/IV processor |
Willy Tarreau | a5899aa | 2010-11-28 07:41:00 +0100 | [diff] [blame] | 46 | - native : use the build machine's specific processor optimizations |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 47 | - generic : any other processor or no specific optimization. (default) |
| 48 | |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 49 | Alternatively, you may just set the CPU_CFLAGS value to the optimal GCC options |
| 50 | for your platform. |
| 51 | |
Willy Tarreau | ef7341d | 2009-04-11 19:45:50 +0200 | [diff] [blame] | 52 | You may want to build specific target binaries which do not match your native |
| 53 | compiler's target. This is particularly true on 64-bit systems when you want |
| 54 | to build a 32-bit binary. Use the ARCH variable for this purpose. Right now |
Willy Tarreau | a5899aa | 2010-11-28 07:41:00 +0100 | [diff] [blame] | 55 | it only knows about a few x86 variants (i386,i486,i586,i686,x86_64), two |
| 56 | generic ones (32,64) and sets -m32/-m64 as well as -march=<arch> accordingly. |
Willy Tarreau | ef7341d | 2009-04-11 19:45:50 +0200 | [diff] [blame] | 57 | |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 58 | If your system supports PCRE (Perl Compatible Regular Expressions), then you |
| 59 | really should build with libpcre which is between 2 and 10 times faster than |
| 60 | other libc implementations. Regex are used for header processing (deletion, |
| 61 | rewriting, allow, deny). The only inconvenient of libpcre is that it is not |
| 62 | yet widely spread, so if you build for other systems, you might get into |
| 63 | trouble if they don't have the dynamic library. In this situation, you should |
| 64 | statically link libpcre into haproxy so that it will not be necessary to |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 65 | install it on target systems. Available build options for PCRE are : |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 66 | |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 67 | - USE_PCRE=1 to use libpcre, in whatever form is available on your system |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 68 | (shared or static) |
| 69 | |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 70 | - USE_STATIC_PCRE=1 to use a static version of libpcre even if the dynamic |
| 71 | one is available. This will enhance portability. |
| 72 | |
Willy Tarreau | 663148c | 2012-12-12 00:38:22 +0100 | [diff] [blame] | 73 | - with no option, use your OS libc's standard regex implementation (default). |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 74 | Warning! group references on Solaris seem broken. Use static-pcre whenever |
| 75 | possible. |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 76 | |
Willy Tarreau | 64bc40b | 2011-03-23 20:00:53 +0100 | [diff] [blame] | 77 | Recent systems can resolve IPv6 host names using getaddrinfo(). This primitive |
| 78 | is not present in all libcs and does not work in all of them either. Support in |
| 79 | glibc was broken before 2.3. Some embedded libs may not properly work either, |
| 80 | thus, support is disabled by default, meaning that some host names which only |
| 81 | resolve as IPv6 addresses will not resolve and configs might emit an error |
| 82 | during parsing. If you know that your OS libc has reliable support for |
| 83 | getaddrinfo(), you can add USE_GETADDRINFO=1 on the make command line to enable |
| 84 | it. This is the recommended option for most Linux distro packagers since it's |
| 85 | working fine on all recent mainstream distros. It is automatically enabled on |
| 86 | Solaris 8 and above, as it's known to work. |
| 87 | |
Willy Tarreau | d450881 | 2012-09-10 09:07:41 +0200 | [diff] [blame] | 88 | It is possible to add native support for SSL using the GNU makefile only, and |
| 89 | by passing "USE_OPENSSL=1" on the make commande line. The libssl and libcrypto |
| 90 | will automatically be linked with haproxy. Some systems also require libz, so |
| 91 | if the build fails due to missing symbols such as deflateInit(), then try again |
| 92 | with "ADDLIB=-lz". |
| 93 | |
Lukas Tribus | 3fe9f1e | 2013-05-19 16:28:17 +0200 | [diff] [blame] | 94 | To link OpenSSL statically against haproxy, build OpenSSL with the no-shared |
| 95 | keyword and install it to a local directory, so your system is not affected : |
| 96 | |
| 97 | $ export STATICLIBSSL=/tmp/staticlibssl |
| 98 | $ ./config --prefix=$STATICLIBSSL no-shared |
| 99 | $ make && make install_sw |
| 100 | |
Lukas Tribus | 130ddf7 | 2013-10-01 00:28:03 +0200 | [diff] [blame] | 101 | When building haproxy, pass that path via SSL_INC and SSL_LIB to make and |
| 102 | include additional libs with ADDLIB if needed (in this case for example libdl): |
| 103 | $ make TARGET=linux26 USE_OPENSSL=1 SSL_INC=$STATICLIBSSL/include SSL_LIB=$STATICLIBSSL/lib ADDLIB=-ldl |
Lukas Tribus | 3fe9f1e | 2013-05-19 16:28:17 +0200 | [diff] [blame] | 104 | |
William Lallemand | 82fe75c | 2012-10-23 10:25:10 +0200 | [diff] [blame] | 105 | It is also possible to include native support for ZLIB to benefit from HTTP |
| 106 | compression. For this, pass "USE_ZLIB=1" on the "make" command line and ensure |
| 107 | that zlib is present on the system. |
| 108 | |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 109 | By default, the DEBUG variable is set to '-g' to enable debug symbols. It is |
| 110 | not wise to disable it on uncommon systems, because it's often the only way to |
| 111 | get a complete core when you need one. Otherwise, you can set DEBUG to '-s' to |
| 112 | strip the binary. |
| 113 | |
| 114 | For example, I use this to build for Solaris 8 : |
| 115 | |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 116 | $ make TARGET=solaris CPU=ultrasparc USE_STATIC_PCRE=1 |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 117 | |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 118 | And I build it this way on OpenBSD or FreeBSD : |
willy tarreau | d38e72d | 2006-03-19 20:56:52 +0100 | [diff] [blame] | 119 | |
| 120 | $ make -f Makefile.bsd REGEX=pcre DEBUG= COPTS.generic="-Os -fomit-frame-pointer -mgnu" |
| 121 | |
Willy Tarreau | 663148c | 2012-12-12 00:38:22 +0100 | [diff] [blame] | 122 | And on a classic Linux with SSL and ZLIB support (eg: Red Hat 5.x) : |
| 123 | |
| 124 | $ make TARGET=linux26 CPU=native USE_PCRE=1 USE_OPENSSL=1 USE_ZLIB=1 |
| 125 | |
| 126 | And on a recent Linux >= 2.6.28 with SSL and ZLIB support : |
Willy Tarreau | d450881 | 2012-09-10 09:07:41 +0200 | [diff] [blame] | 127 | |
William Lallemand | 82fe75c | 2012-10-23 10:25:10 +0200 | [diff] [blame] | 128 | $ make TARGET=linux2628 CPU=native USE_PCRE=1 USE_OPENSSL=1 USE_ZLIB=1 |
Willy Tarreau | d450881 | 2012-09-10 09:07:41 +0200 | [diff] [blame] | 129 | |
William Lallemand | 82fe75c | 2012-10-23 10:25:10 +0200 | [diff] [blame] | 130 | In order to build a 32-bit binary on an x86_64 Linux system with SSL support |
| 131 | without support for compression but when OpenSSL requires ZLIB anyway : |
Willy Tarreau | ef7341d | 2009-04-11 19:45:50 +0200 | [diff] [blame] | 132 | |
Willy Tarreau | d450881 | 2012-09-10 09:07:41 +0200 | [diff] [blame] | 133 | $ make TARGET=linux26 ARCH=i386 USE_OPENSSL=1 ADDLIB=-lz |
Willy Tarreau | ef7341d | 2009-04-11 19:45:50 +0200 | [diff] [blame] | 134 | |
Willy Tarreau | 3b8e979 | 2012-11-22 00:43:09 +0100 | [diff] [blame] | 135 | The BSD and OSX makefiles do not support build options for OpenSSL nor zlib. |
| 136 | Also, at least on OpenBSD, pthread_mutexattr_setpshared() does not exist so |
| 137 | the SSL session cache cannot be shared between multiple processes. If you want |
| 138 | to enable these options, you need to use GNU make with the default makefile as |
| 139 | follows : |
| 140 | |
| 141 | $ gmake TARGET=openbsd USE_OPENSSL=1 USE_ZLIB=1 USE_PRIVATE_CACHE=1 |
| 142 | |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 143 | If you need to pass other defines, includes, libraries, etc... then please |
| 144 | check the Makefile to see which ones will be available in your case, and |
Willy Tarreau | 83b30c1 | 2008-05-25 10:32:50 +0200 | [diff] [blame] | 145 | use the USE_* variables in the GNU Makefile, or ADDINC, ADDLIB, and DEFINE |
| 146 | variables in the BSD makefiles. |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 147 | |
Willy Tarreau | 97ec969 | 2010-01-28 20:52:05 +0100 | [diff] [blame] | 148 | AIX 5.3 is known to work with the generic target. However, for the binary to |
| 149 | also run on 5.2 or earlier, you need to build with DEFINE="-D_MSGQSUPPORT", |
| 150 | otherwise __fd_select() will be used while not being present in the libc. |
Willy Tarreau | 7dec965 | 2012-06-06 16:15:03 +0200 | [diff] [blame] | 151 | If you get build errors because of strange symbols or section mismatches, |
| 152 | simply remove -g from DEBUG_CFLAGS. |
Willy Tarreau | 97ec969 | 2010-01-28 20:52:05 +0100 | [diff] [blame] | 153 | |
Willy Tarreau | 32e65ef | 2013-04-02 08:14:29 +0200 | [diff] [blame] | 154 | You can easily define your own target with the GNU Makefile. Unknown targets |
| 155 | are processed with no default option except USE_POLL=default. So you can very |
| 156 | well use that property to define your own set of options. USE_POLL can even be |
| 157 | disabled by setting USE_POLL="". For example : |
| 158 | |
| 159 | $ gmake TARGET=tiny USE_POLL="" TARGET_CFLAGS=-fomit-frame-pointer |
| 160 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 161 | |
| 162 | 2) How to install it |
| 163 | -------------------- |
| 164 | |
| 165 | To install haproxy, you can either copy the single resulting binary to the |
| 166 | place you want, or run : |
| 167 | |
| 168 | $ sudo make install |
| 169 | |
| 170 | If you're packaging it for another system, you can specify its root directory |
| 171 | in the usual DESTDIR variable. |
| 172 | |
| 173 | |
| 174 | 3) How to set it up |
| 175 | ------------------- |
| 176 | |
| 177 | There is some documentation in the doc/ directory : |
| 178 | |
| 179 | - architecture.txt : this is the architecture manual. It is quite old and |
| 180 | does not tell about the nice new features, but it's still a good starting |
| 181 | point when you know what you want but don't know how to do it. |
| 182 | |
| 183 | - configuration.txt : this is the configuration manual. It recalls a few |
| 184 | essential HTTP basic concepts, and details all the configuration file |
| 185 | syntax (keywords, units). It also describes the log and stats format. It |
| 186 | is normally always up to date. If you see that something is missing from |
| 187 | it, please report it as this is a bug. |
| 188 | |
| 189 | - haproxy-en.txt / haproxy-fr.txt : these are the old outdated docs. You |
| 190 | should never need them. If you do, then please report what you didn't |
| 191 | find in the other ones. |
| 192 | |
| 193 | - gpl.txt / lgpl.txt : the copy of the licenses covering the software. See |
| 194 | the 'LICENSE' file at the top for more information. |
| 195 | |
| 196 | - the rest is mainly for developers. |
| 197 | |
| 198 | There are also a number of nice configuration examples in the "examples" |
| 199 | directory as well as on several sites and articles on the net which are linked |
| 200 | to from the haproxy web site. |
| 201 | |
| 202 | |
| 203 | 4) How to report a bug |
| 204 | ---------------------- |
| 205 | |
| 206 | It is possible that from time to time you'll find a bug. A bug is a case where |
| 207 | what you see is not what is documented. Otherwise it can be a misdesign. If you |
| 208 | find that something is stupidly design, please discuss it on the list (see the |
| 209 | "how to contribute" section below). If you feel like you're proceeding right |
| 210 | and haproxy doesn't obey, then first ask yourself if it is possible that nobody |
| 211 | before you has even encountered this issue. If it's unlikely, the you probably |
| 212 | have an issue in your setup. Just in case of doubt, please consult the mailing |
| 213 | list archives : |
| 214 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 215 | http://marc.info/?l=haproxy |
| 216 | |
| 217 | Otherwise, please try to gather the maximum amount of information to help |
| 218 | reproduce the issue and send that to the mailing list : |
| 219 | |
| 220 | haproxy@formilux.org |
| 221 | |
| 222 | Please include your configuration and logs. You can mask your IP addresses and |
| 223 | passwords, we don't need them. But it's essential that you post your config if |
| 224 | you want people to guess what is happening. |
| 225 | |
| 226 | Also, keep in mind that haproxy is designed to NEVER CRASH. If you see it die |
| 227 | without any reason, then it definitely is a critical bug that must be reported |
| 228 | and urgently fixed. It has happened a couple of times in the past, essentially |
| 229 | on development versions running on new architectures. If you think your setup |
| 230 | is fairly common, then it is possible that the issue is totally unrelated. |
| 231 | Anyway, if that happens, feel free to contact me directly, as I will give you |
| 232 | instructions on how to collect a usable core file, and will probably ask for |
| 233 | other captures that you'll not want to share with the list. |
| 234 | |
| 235 | |
| 236 | 5) How to contribute |
| 237 | -------------------- |
| 238 | |
| 239 | It is possible that you'll want to add a specific feature to satisfy your needs |
| 240 | or one of your customers'. Contributions are welcome, however I'm often very |
| 241 | picky about changes. I will generally reject patches that change massive parts |
| 242 | of the code, or that touch the core parts without any good reason if those |
| 243 | changes have not been discussed first. |
| 244 | |
| 245 | The proper place to discuss your changes is the HAProxy Mailing List. There are |
| 246 | enough skilled readers to catch hazardous mistakes and to suggest improvements. |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 247 | I trust a number of them enough to merge a patch if they say it's OK, so using |
| 248 | the list is the fastest way to get your code reviewed and merged. You can |
| 249 | subscribe to it by sending an empty e-mail at the following address : |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 250 | |
| 251 | haproxy+subscribe@formilux.org |
| 252 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 253 | If you have an idea about something to implement, *please* discuss it on the |
| 254 | list first. It has already happened several times that two persons did the same |
| 255 | thing simultaneously. This is a waste of time for both of them. It's also very |
| 256 | common to see some changes rejected because they're done in a way that will |
| 257 | conflict with future evolutions, or that does not leave a good feeling. It's |
| 258 | always unpleasant for the person who did the work, and it is unpleasant for me |
| 259 | too because I value people's time and efforts. That would not happen if these |
| 260 | were discussed first. There is no problem posting work in progress to the list, |
| 261 | it happens quite often in fact. Also, don't waste your time with the doc when |
| 262 | submitting patches for review, only add the doc with the patch you consider |
| 263 | ready to merge. |
| 264 | |
Willy Tarreau | 2ddccb7 | 2013-05-01 10:07:21 +0200 | [diff] [blame] | 265 | Another important point concerns code portability. Haproxy requires gcc as the |
| 266 | C compiler, and may or may not work with other compilers. However it's known |
| 267 | to build using gcc 2.95 or any later version. As such, it is important to keep |
| 268 | in mind that certain facilities offered by recent versions must not be used in |
| 269 | the code : |
| 270 | |
| 271 | - declarations mixed in the code (requires gcc >= 3.x) |
| 272 | - GCC builtins without checking for their availability based on version and |
| 273 | architecture ; |
| 274 | - assembly code without any alternate portable form for other platforms |
| 275 | - use of stdbool.h, "bool", "false", "true" : simply use "int", "0", "1" |
| 276 | - in general, anything which requires C99 (such as declaring variables in |
| 277 | "for" statements) |
| 278 | |
| 279 | Since most of these restrictions are just a matter of coding style, it is |
| 280 | normally not a problem to comply. |
| 281 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 282 | If your work is very confidential and you can't publicly discuss it, you can |
| 283 | also mail me directly about it, but your mail may be waiting several days in |
| 284 | the queue before you get a response. |
| 285 | |
| 286 | If you'd like a feature to be added but you think you don't have the skills to |
| 287 | implement it yourself, you should follow these steps : |
| 288 | |
| 289 | 1. discuss the feature on the mailing list. It is possible that someone |
| 290 | else has already implemented it, or that someone will tell you how to |
| 291 | proceed without it, or even why not to do it. It is also possible that |
| 292 | in fact it's quite easy to implement and people will guide you through |
| 293 | the process. That way you'll finally have YOUR patch merged, providing |
| 294 | the feature YOU need. |
| 295 | |
| 296 | 2. if you really can't code it yourself after discussing it, then you may |
| 297 | consider contacting someone to do the job for you. Some people on the |
| 298 | list might be OK with trying to do it. Otherwise, you can check the list |
| 299 | of contributors at the URL below, some of the regular contributors may |
| 300 | be able to do the work, probably not for free but their time is as much |
| 301 | valuable as yours after all, you can't eat the cake and have it too. |
| 302 | |
| 303 | The list of past and regular contributors is available below. It lists not only |
| 304 | significant code contributions (features, fixes), but also time or money |
| 305 | donations : |
| 306 | |
| 307 | http://haproxy.1wt.eu/contrib.html |
| 308 | |
| 309 | Note to contributors: it's very handy when patches comes with a properly |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 310 | formated subject. There are 3 criteria of particular importance in any patch : |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 311 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 312 | - its nature (is it a fix for a bug, a new feature, an optimization, ...) |
| 313 | - its importance, which generally reflects the risk of merging/not merging it |
| 314 | - what area it applies to (eg: http, stats, startup, config, doc, ...) |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 315 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 316 | It's important to make these 3 criteria easy to spot in the patch's subject, |
| 317 | because it's the first (and sometimes the only) thing which is read when |
| 318 | reviewing patches to find which ones need to be backported to older versions. |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 319 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 320 | Specifically, bugs must be clearly easy to spot so that they're never missed. |
| 321 | Any patch fixing a bug must have the "BUG" tag in its subject. Most common |
| 322 | patch types include : |
| 323 | |
| 324 | - BUG fix for a bug. The severity of the bug should also be indicated |
| 325 | when known. Similarly, if a backport is needed to older versions, |
| 326 | it should be indicated on the last line of the commit message. If |
| 327 | the bug has been identified as a regression brought by a specific |
| 328 | patch or version, this indication will be appreciated too. New |
| 329 | maintenance releases are generally emitted when a few of these |
| 330 | patches are merged. |
| 331 | |
| 332 | - CLEANUP code cleanup, silence of warnings, etc... theorically no impact. |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 333 | These patches will rarely be seen in stable branches, though they |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 334 | may appear when they remove some annoyance or when they make |
| 335 | backporting easier. By nature, a cleanup is always minor. |
| 336 | |
| 337 | - REORG code reorganization. Some blocks may be moved to other places, |
| 338 | some important checks might be swapped, etc... These changes |
| 339 | always present a risk of regression. For this reason, they should |
| 340 | never be mixed with any bug fix nor functional change. Code is |
| 341 | only moved as-is. Indicating the risk of breakage is highly |
| 342 | recommended. |
| 343 | |
| 344 | - BUILD updates or fixes for build issues. Changes to makefiles also fall |
| 345 | into this category. The risk of breakage should be indicated if |
| 346 | known. It is also appreciated to indicate what platforms and/or |
| 347 | configurations were tested after the change. |
| 348 | |
| 349 | - OPTIM some code was optimised. Sometimes if the regression risk is very |
| 350 | low and the gains significant, such patches may be merged in the |
| 351 | stable branch. Depending on the amount of code changed or replaced |
| 352 | and the level of trust the author has in the change, the risk of |
| 353 | regression should be indicated. |
| 354 | |
| 355 | - RELEASE release of a new version (development or stable). |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 356 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 357 | - LICENSE licensing updates (may impact distro packagers). |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 358 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 359 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 360 | When the patch cannot be categorized, it's best not to put any tag. This is |
| 361 | commonly the case for new features, which development versions are mostly made |
| 362 | of. |
| 363 | |
| 364 | Additionally, the importance of the patch should be indicated when known. A |
| 365 | single upper-case word is preferred, among : |
| 366 | |
| 367 | - MINOR minor change, very low risk of impact. It is often the case for |
| 368 | code additions that don't touch live code. For a bug, it generally |
| 369 | indicates an annoyance, nothing more. |
| 370 | |
| 371 | - MEDIUM medium risk, may cause unexpected regressions of low importance or |
| 372 | which may quickly be discovered. For a bug, it generally indicates |
| 373 | something odd which requires changing the configuration in an |
| 374 | undesired way to work around the issue. |
| 375 | |
| 376 | - MAJOR major risk of hidden regression. This happens when I rearrange |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 377 | large parts of code, when I play with timeouts, with variable |
| 378 | initializations, etc... We should only exceptionally find such |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 379 | patches in stable branches. For a bug, it indicates severe |
| 380 | reliability issues for which workarounds are identified with or |
| 381 | without performance impacts. |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 382 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 383 | - CRITICAL medium-term reliability or security is at risk and workarounds, |
| 384 | if they exist, might not always be acceptable. An upgrade is |
| 385 | absolutely required. A maintenance release may be emitted even if |
| 386 | only one of these bugs are fixed. Note that this tag is only used |
| 387 | with bugs. Such patches must indicate what is the first version |
| 388 | affected, and if known, the commit ID which introduced the issue. |
| 389 | |
| 390 | If this criterion doesn't apply, it's best not to put it. For instance, most |
| 391 | doc updates and most examples or test files are just added or updated without |
| 392 | any need to qualify a level of importance. |
| 393 | |
| 394 | The area the patch applies to is quite important, because some areas are known |
| 395 | to be similar in older versions, suggesting a backport might be desirable, and |
| 396 | conversely, some areas are known to be specific to one version. When the tag is |
| 397 | used alone, uppercase is preferred for readability, otherwise lowercase is fine |
| 398 | too. The following tags are suggested but not limitative : |
| 399 | |
| 400 | - doc documentation updates or fixes. No code is affected, no need to |
| 401 | upgrade. These patches can also be sent right after a new feature, |
| 402 | to document it. |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 403 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 404 | - examples example files. Be careful, sometimes these files are packaged. |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 405 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 406 | - tests regression test files. No code is affected, no need to upgrade. |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 407 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 408 | - init initialization code, arguments parsing, etc... |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 409 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 410 | - config configuration parser, mostly used when adding new config keywords |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 411 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 412 | - http the HTTP engine |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 413 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 414 | - stats the stats reporting engine as well as the stats socket CLI |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 415 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 416 | - checks the health checks engine (eg: when adding new checks) |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 417 | |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 418 | - acl the ACL processing core or some ACLs from other areas |
| 419 | |
| 420 | - peers the peer synchronization engine |
| 421 | |
| 422 | - listeners everything related to incoming connection settings |
| 423 | |
| 424 | - frontend everything related to incoming connection processing |
| 425 | |
| 426 | - backend everything related to LB algorithms and server farm |
| 427 | |
| 428 | - session session processing and flags (very sensible, be careful) |
| 429 | |
| 430 | - server server connection management, queueing |
| 431 | |
| 432 | - proxy proxy maintenance (start/stop) |
| 433 | |
| 434 | - log log management |
| 435 | |
| 436 | - poll any of the pollers |
| 437 | |
| 438 | - halog the halog sub-component in the contrib directory |
| 439 | |
| 440 | - contrib any addition to the contrib directory |
| 441 | |
| 442 | Other names may be invented when more precise indications are meaningful, for |
| 443 | instance : "cookie" which indicates cookie processing in the HTTP core. Last, |
| 444 | indicating the name of the affected file is also a good way to quickly spot |
| 445 | changes. Many commits were already tagged with "stream_sock" or "cfgparse" for |
| 446 | instance. |
| 447 | |
| 448 | It is desired that AT LEAST one of the 3 criteria tags is reported in the patch |
| 449 | subject. Ideally, we would have the 3 most often. The two first criteria should |
| 450 | be present before a first colon (':'). If both are present, then they should be |
| 451 | delimited with a slash ('/'). The 3rd criterion (area) should appear next, also |
| 452 | followed by a colon. Thus, all of the following messages are valid : |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 453 | |
| 454 | Examples of messages : |
Willy Tarreau | 9a639a1 | 2011-09-10 22:48:36 +0200 | [diff] [blame] | 455 | - DOC: document options forwardfor to logasap |
| 456 | - DOC/MAJOR: reorganize the whole document and change indenting |
| 457 | - BUG: stats: connection reset counters must be plain ascii, not HTML |
| 458 | - BUG/MINOR: stats: connection reset counters must be plain ascii, not HTML |
| 459 | - MEDIUM: checks: support multi-packet health check responses |
| 460 | - RELEASE: Released version 1.4.2 |
| 461 | - BUILD: stats: stdint is not present on solaris |
| 462 | - OPTIM/MINOR: halog: make fgets parse more bytes by blocks |
| 463 | - REORG/MEDIUM: move syscall redefinition to specific places |
| 464 | |
| 465 | Please do not use square brackets anymore around the tags, because they give me |
| 466 | more work when merging patches. By default I'm asking Git to keep them but this |
| 467 | causes trouble when patches are prefixed with the [PATCH] tag because in order |
| 468 | not to store it, I have to hand-edit the patches. So as of now, I will ask Git |
| 469 | to remove whatever is located between square brackets, which implies that any |
| 470 | subject formatted the old way will have its tag stripped out. |
| 471 | |
| 472 | In fact, one of the only square bracket tags that still makes sense is '[RFC]' |
| 473 | at the beginning of the subject, when you're asking for someone to review your |
| 474 | change before getting it merged. If the patch is OK to be merged, then I can |
| 475 | merge it as-is and the '[RFC]' tag will automatically be removed. If you don't |
| 476 | want it to be merged at all, you can simply state it in the message, or use an |
| 477 | alternate '[WIP]' tag ("work in progress"). |
| 478 | |
| 479 | The tags are not rigid, follow your intuition first, anyway I reserve the right |
| 480 | to change them when merging the patch. It may happen that a same patch has a |
| 481 | different tag in two distinct branches. The reason is that a bug in one branch |
| 482 | may just be a cleanup in the other one because the code cannot be triggered. |
| 483 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 484 | |
| 485 | For a more efficient interaction between the mainline code and your code, I can |
| 486 | only strongly encourage you to try the Git version control system : |
| 487 | |
| 488 | http://git-scm.com/ |
| 489 | |
| 490 | It's very fast, lightweight and lets you undo/redo your work as often as you |
| 491 | want, without making your mistakes visible to the rest of the world. It will |
| 492 | definitely help you contribute quality code and take other people's feedback |
| 493 | in consideration. In order to clone the HAProxy Git repository : |
| 494 | |
| 495 | $ git clone http://git.1wt.eu/git/haproxy-1.4.git (stable 1.4) |
| 496 | $ git clone http://git.1wt.eu/git/haproxy.git/ (development) |
| 497 | |
Willy Tarreau | 663148c | 2012-12-12 00:38:22 +0100 | [diff] [blame] | 498 | The site above is slow, a faster mirror is maintained up to date here : |
| 499 | |
| 500 | $ git clone http://master.formilux.org/git/people/willy/haproxy.git/ |
| 501 | |
Willy Tarreau | b1a34b6 | 2010-05-09 22:37:12 +0200 | [diff] [blame] | 502 | If you decide to use Git for your developments, then your commit messages will |
| 503 | have the subject line in the format described above, then the whole description |
| 504 | of your work (mainly why you did it) will be in the body. You can directly send |
| 505 | your commits to the mailing list, the format is convenient to read and process. |
| 506 | |
willy tarreau | 7834533 | 2005-12-18 01:33:16 +0100 | [diff] [blame] | 507 | -- end |