Tom Rini | 10e4779 | 2018-05-06 17:58:06 -0400 | [diff] [blame] | 1 | # SPDX-License-Identifier: GPL-2.0+ |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 2 | # Copyright (c) 2013 The Chromium OS Authors. |
| 3 | # |
| 4 | # Bloat-o-meter code used here Copyright 2004 Matt Mackall <mpm@selenic.com> |
| 5 | # |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 6 | |
| 7 | import collections |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 8 | from datetime import datetime, timedelta |
| 9 | import glob |
| 10 | import os |
| 11 | import re |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 12 | import queue |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 13 | import shutil |
Simon Glass | 205ac04 | 2016-09-18 16:48:37 -0600 | [diff] [blame] | 14 | import signal |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 15 | import string |
| 16 | import sys |
Simon Glass | d26e144 | 2016-09-18 16:48:35 -0600 | [diff] [blame] | 17 | import threading |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 18 | import time |
| 19 | |
Simon Glass | f0d9c10 | 2020-04-17 18:09:02 -0600 | [diff] [blame] | 20 | from buildman import builderthread |
| 21 | from buildman import toolchain |
Simon Glass | a997ea5 | 2020-04-17 18:09:04 -0600 | [diff] [blame] | 22 | from patman import gitutil |
Simon Glass | 131444f | 2023-02-23 18:18:04 -0700 | [diff] [blame] | 23 | from u_boot_pylib import command |
| 24 | from u_boot_pylib import terminal |
Simon Glass | 600ede9 | 2024-08-15 13:57:45 -0600 | [diff] [blame] | 25 | from u_boot_pylib import tools |
Simon Glass | 131444f | 2023-02-23 18:18:04 -0700 | [diff] [blame] | 26 | from u_boot_pylib.terminal import tprint |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 27 | |
Simon Glass | 146b602 | 2021-10-19 21:43:24 -0600 | [diff] [blame] | 28 | # This indicates an new int or hex Kconfig property with no default |
| 29 | # It hangs the build since the 'conf' tool cannot proceed without valid input. |
| 30 | # |
| 31 | # We get a repeat sequence of something like this: |
| 32 | # >> |
| 33 | # Break things (BREAK_ME) [] (NEW) |
| 34 | # Error in reading or end of file. |
| 35 | # << |
| 36 | # which indicates that BREAK_ME has an empty default |
Simon Glass | 1f3a122 | 2024-09-21 19:57:57 +0200 | [diff] [blame] | 37 | RE_NO_DEFAULT = re.compile(br'\((\w+)\) \[] \(NEW\)') |
Simon Glass | 146b602 | 2021-10-19 21:43:24 -0600 | [diff] [blame] | 38 | |
Simon Glass | dac7371 | 2023-10-23 00:52:43 -0700 | [diff] [blame] | 39 | # Symbol types which appear in the bloat feature (-B). Others are silently |
| 40 | # dropped when reading in the 'nm' output |
| 41 | NM_SYMBOL_TYPES = 'tTdDbBr' |
| 42 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 43 | """ |
| 44 | Theory of Operation |
| 45 | |
| 46 | Please see README for user documentation, and you should be familiar with |
| 47 | that before trying to make sense of this. |
| 48 | |
| 49 | Buildman works by keeping the machine as busy as possible, building different |
| 50 | commits for different boards on multiple CPUs at once. |
| 51 | |
| 52 | The source repo (self.git_dir) contains all the commits to be built. Each |
| 53 | thread works on a single board at a time. It checks out the first commit, |
| 54 | configures it for that board, then builds it. Then it checks out the next |
| 55 | commit and builds it (typically without re-configuring). When it runs out |
| 56 | of commits, it gets another job from the builder and starts again with that |
| 57 | board. |
| 58 | |
| 59 | Clearly the builder threads could work either way - they could check out a |
| 60 | commit and then built it for all boards. Using separate directories for each |
| 61 | commit/board pair they could leave their build product around afterwards |
| 62 | also. |
| 63 | |
| 64 | The intent behind building a single board for multiple commits, is to make |
| 65 | use of incremental builds. Since each commit is built incrementally from |
| 66 | the previous one, builds are faster. Reconfiguring for a different board |
| 67 | removes all intermediate object files. |
| 68 | |
| 69 | Many threads can be working at once, but each has its own working directory. |
| 70 | When a thread finishes a build, it puts the output files into a result |
| 71 | directory. |
| 72 | |
| 73 | The base directory used by buildman is normally '../<branch>', i.e. |
| 74 | a directory higher than the source repository and named after the branch |
| 75 | being built. |
| 76 | |
| 77 | Within the base directory, we have one subdirectory for each commit. Within |
| 78 | that is one subdirectory for each board. Within that is the build output for |
| 79 | that commit/board combination. |
| 80 | |
| 81 | Buildman also create working directories for each thread, in a .bm-work/ |
| 82 | subdirectory in the base dir. |
| 83 | |
| 84 | As an example, say we are building branch 'us-net' for boards 'sandbox' and |
| 85 | 'seaboard', and say that us-net has two commits. We will have directories |
| 86 | like this: |
| 87 | |
| 88 | us-net/ base directory |
Ovidiu Panait | ee8e9cb | 2020-05-15 09:30:12 +0300 | [diff] [blame] | 89 | 01_g4ed4ebc_net--Add-tftp-speed-/ |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 90 | sandbox/ |
| 91 | u-boot.bin |
| 92 | seaboard/ |
| 93 | u-boot.bin |
Ovidiu Panait | ee8e9cb | 2020-05-15 09:30:12 +0300 | [diff] [blame] | 94 | 02_g4ed4ebc_net--Check-tftp-comp/ |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 95 | sandbox/ |
| 96 | u-boot.bin |
| 97 | seaboard/ |
| 98 | u-boot.bin |
| 99 | .bm-work/ |
| 100 | 00/ working directory for thread 0 (contains source checkout) |
| 101 | build/ build output |
| 102 | 01/ working directory for thread 1 |
| 103 | build/ build output |
| 104 | ... |
| 105 | u-boot/ source directory |
| 106 | .git/ repository |
| 107 | """ |
| 108 | |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 109 | """Holds information about a particular error line we are outputing |
| 110 | |
| 111 | char: Character representation: '+': error, '-': fixed error, 'w+': warning, |
| 112 | 'w-' = fixed warning |
| 113 | boards: List of Board objects which have line in the error/warning output |
| 114 | errline: The text of the error line |
| 115 | """ |
Simon Glass | 5df4522 | 2022-07-11 19:04:00 -0600 | [diff] [blame] | 116 | ErrLine = collections.namedtuple('ErrLine', 'char,brds,errline') |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 117 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 118 | # Possible build outcomes |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 119 | OUTCOME_OK, OUTCOME_WARNING, OUTCOME_ERROR, OUTCOME_UNKNOWN = list(range(4)) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 120 | |
Simon Glass | d214bef | 2017-04-12 18:23:26 -0600 | [diff] [blame] | 121 | # Translate a commit subject into a valid filename (and handle unicode) |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 122 | trans_valid_chars = str.maketrans('/: ', '---') |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 123 | |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 124 | BASE_CONFIG_FILENAMES = [ |
| 125 | 'u-boot.cfg', 'u-boot-spl.cfg', 'u-boot-tpl.cfg' |
| 126 | ] |
| 127 | |
| 128 | EXTRA_CONFIG_FILENAMES = [ |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 129 | '.config', '.config-spl', '.config-tpl', |
| 130 | 'autoconf.mk', 'autoconf-spl.mk', 'autoconf-tpl.mk', |
| 131 | 'autoconf.h', 'autoconf-spl.h','autoconf-tpl.h', |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 132 | ] |
| 133 | |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 134 | class Config: |
| 135 | """Holds information about configuration settings for a board.""" |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 136 | def __init__(self, config_filename, target): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 137 | self.target = target |
| 138 | self.config = {} |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 139 | for fname in config_filename: |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 140 | self.config[fname] = {} |
| 141 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 142 | def add(self, fname, key, value): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 143 | self.config[fname][key] = value |
| 144 | |
| 145 | def __hash__(self): |
| 146 | val = 0 |
| 147 | for fname in self.config: |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 148 | for key, value in self.config[fname].items(): |
| 149 | print(key, value) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 150 | val = val ^ hash(key) & hash(value) |
| 151 | return val |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 152 | |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 153 | class Environment: |
| 154 | """Holds information about environment variables for a board.""" |
| 155 | def __init__(self, target): |
| 156 | self.target = target |
| 157 | self.environment = {} |
| 158 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 159 | def add(self, key, value): |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 160 | self.environment[key] = value |
| 161 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 162 | class Builder: |
| 163 | """Class for building U-Boot for a particular commit. |
| 164 | |
| 165 | Public members: (many should ->private) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 166 | already_done: Number of builds already completed |
| 167 | base_dir: Base directory to use for builder |
| 168 | checkout: True to check out source, False to skip that step. |
| 169 | This is used for testing. |
| 170 | col: terminal.Color() object |
Simon Glass | f56cc29 | 2023-07-19 17:49:03 -0600 | [diff] [blame] | 171 | count: Total number of commits to build, which is the number of commits |
| 172 | multiplied by the number of boards |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 173 | do_make: Method to call to invoke Make |
| 174 | fail: Number of builds that failed due to error |
| 175 | force_build: Force building even if a build already exists |
| 176 | force_config_on_failure: If a commit fails for a board, disable |
| 177 | incremental building for the next commit we build for that |
| 178 | board, so that we will see all warnings/errors again. |
Simon Glass | 7041c39 | 2014-07-13 12:22:31 -0600 | [diff] [blame] | 179 | force_build_failures: If a previously-built build (i.e. built on |
| 180 | a previous run of buildman) is marked as failed, rebuild it. |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 181 | git_dir: Git directory containing source repository |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 182 | num_jobs: Number of jobs to run at once (passed to make as -j) |
| 183 | num_threads: Number of builder threads to run |
| 184 | out_queue: Queue of results to process |
| 185 | re_make_err: Compiled regular expression for ignore_lines |
| 186 | queue: Queue of jobs to run |
| 187 | threads: List of active threads |
| 188 | toolchains: Toolchains object to use for building |
| 189 | upto: Current commit number we are building (0.count-1) |
| 190 | warned: Number of builds that produced at least one warning |
Simon Glass | f3018b7a | 2014-07-14 17:51:02 -0600 | [diff] [blame] | 191 | force_reconfig: Reconfigure U-Boot on each comiit. This disables |
| 192 | incremental building, where buildman reconfigures on the first |
| 193 | commit for a baord, and then just does an incremental build for |
| 194 | the following commits. In fact buildman will reconfigure and |
| 195 | retry for any failing commits, so generally the only effect of |
| 196 | this option is to slow things down. |
Simon Glass | 38df2e2 | 2014-07-14 17:51:03 -0600 | [diff] [blame] | 197 | in_tree: Build U-Boot in-tree instead of specifying an output |
| 198 | directory separate from the source code. This option is really |
| 199 | only useful for testing in-tree builds. |
Simon Glass | b6eb8cf | 2020-03-18 09:42:42 -0600 | [diff] [blame] | 200 | work_in_output: Use the output directory as the work directory and |
| 201 | don't write to a separate output directory. |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 202 | thread_exceptions: List of exceptions raised by thread jobs |
Simon Glass | f6bfcca | 2023-02-21 12:40:28 -0700 | [diff] [blame] | 203 | no_lto (bool): True to set the NO_LTO flag when building |
Simon Glass | 828d70d | 2023-02-21 12:40:29 -0700 | [diff] [blame] | 204 | reproducible_builds (bool): True to set SOURCE_DATE_EPOCH=0 for builds |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 205 | |
| 206 | Private members: |
| 207 | _base_board_dict: Last-summarised Dict of boards |
| 208 | _base_err_lines: Last-summarised list of errors |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 209 | _base_warn_lines: Last-summarised list of warnings |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 210 | _build_period_us: Time taken for a single build (float object). |
| 211 | _complete_delay: Expected delay until completion (timedelta) |
| 212 | _next_delay_update: Next time we plan to display a progress update |
| 213 | (datatime) |
| 214 | _show_unknown: Show unknown boards (those not built) in summary |
Simon Glass | 726ae81 | 2020-04-09 15:08:47 -0600 | [diff] [blame] | 215 | _start_time: Start time for the build |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 216 | _timestamps: List of timestamps for the completion of the last |
| 217 | last _timestamp_count builds. Each is a datetime object. |
| 218 | _timestamp_count: Number of timestamps to keep in our list. |
| 219 | _working_dir: Base working directory containing all threads |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 220 | _single_builder: BuilderThread object for the singer builder, if |
| 221 | threading is not being used |
Simon Glass | 146b602 | 2021-10-19 21:43:24 -0600 | [diff] [blame] | 222 | _terminated: Thread was terminated due to an error |
| 223 | _restarting_config: True if 'Restart config' is detected in output |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 224 | _ide: Produce output suitable for an Integrated Development Environment, |
| 225 | i.e. dont emit progress information and put errors/warnings on stderr |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 226 | """ |
| 227 | class Outcome: |
| 228 | """Records a build outcome for a single make invocation |
| 229 | |
| 230 | Public Members: |
| 231 | rc: Outcome value (OUTCOME_...) |
| 232 | err_lines: List of error lines or [] if none |
| 233 | sizes: Dictionary of image size information, keyed by filename |
| 234 | - Each value is itself a dictionary containing |
| 235 | values for 'text', 'data' and 'bss', being the integer |
| 236 | size in bytes of each section. |
| 237 | func_sizes: Dictionary keyed by filename - e.g. 'u-boot'. Each |
| 238 | value is itself a dictionary: |
| 239 | key: function name |
| 240 | value: Size of function in bytes |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 241 | config: Dictionary keyed by filename - e.g. '.config'. Each |
| 242 | value is itself a dictionary: |
| 243 | key: config name |
| 244 | value: config value |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 245 | environment: Dictionary keyed by environment variable, Each |
| 246 | value is the value of environment variable. |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 247 | """ |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 248 | def __init__(self, rc, err_lines, sizes, func_sizes, config, |
| 249 | environment): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 250 | self.rc = rc |
| 251 | self.err_lines = err_lines |
| 252 | self.sizes = sizes |
| 253 | self.func_sizes = func_sizes |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 254 | self.config = config |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 255 | self.environment = environment |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 256 | |
| 257 | def __init__(self, toolchains, base_dir, git_dir, num_threads, num_jobs, |
Simon Glass | e87bde1 | 2014-12-01 17:33:55 -0700 | [diff] [blame] | 258 | gnu_make='make', checkout=True, show_unknown=True, step=1, |
Tom Rini | 3f6f9b2 | 2024-07-05 14:34:07 -0600 | [diff] [blame] | 259 | no_subdirs=False, full_path=False, verbose_build=False, |
Simon Glass | 222825b | 2024-06-23 11:55:13 -0600 | [diff] [blame] | 260 | mrproper=False, fallback_mrproper=False, |
| 261 | per_board_out_dir=False, config_only=False, |
| 262 | squash_config_y=False, warnings_as_errors=False, |
| 263 | work_in_output=False, test_thread_exceptions=False, |
| 264 | adjust_cfg=None, allow_missing=False, no_lto=False, |
| 265 | reproducible_builds=False, force_build=False, |
| 266 | force_build_failures=False, force_reconfig=False, |
Simon Glass | 600ede9 | 2024-08-15 13:57:45 -0600 | [diff] [blame] | 267 | in_tree=False, force_config_on_failure=False, make_func=None, |
| 268 | dtc_skip=False): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 269 | """Create a new Builder object |
| 270 | |
| 271 | Args: |
| 272 | toolchains: Toolchains object to use for building |
| 273 | base_dir: Base directory to use for builder |
| 274 | git_dir: Git directory containing source repository |
| 275 | num_threads: Number of builder threads to run |
| 276 | num_jobs: Number of jobs to run at once (passed to make as -j) |
Masahiro Yamada | 1fe610d | 2014-07-22 11:19:09 +0900 | [diff] [blame] | 277 | gnu_make: the command name of GNU Make. |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 278 | checkout: True to check out source, False to skip that step. |
| 279 | This is used for testing. |
| 280 | show_unknown: Show unknown boards (those not built) in summary |
| 281 | step: 1 to process every commit, n to process every nth commit |
Simon Glass | d48a46c | 2014-12-01 17:34:00 -0700 | [diff] [blame] | 282 | no_subdirs: Don't create subdirectories when building current |
| 283 | source for a single board |
Tom Rini | 3f6f9b2 | 2024-07-05 14:34:07 -0600 | [diff] [blame] | 284 | full_path: Return the full path in CROSS_COMPILE and don't set |
| 285 | PATH |
Simon Glass | 655b610 | 2014-12-01 17:34:07 -0700 | [diff] [blame] | 286 | verbose_build: Run build with V=1 and don't use 'make -s' |
Simon Glass | 6029af1 | 2020-04-09 15:08:51 -0600 | [diff] [blame] | 287 | mrproper: Always run 'make mrproper' when configuring |
Simon Glass | 222825b | 2024-06-23 11:55:13 -0600 | [diff] [blame] | 288 | fallback_mrproper: Run 'make mrproper' and retry on build failure |
Stephen Warren | 97c9690 | 2016-04-11 10:48:44 -0600 | [diff] [blame] | 289 | per_board_out_dir: Build in a separate persistent directory per |
| 290 | board rather than a thread-specific directory |
Simon Glass | 739e851 | 2016-11-13 14:25:51 -0700 | [diff] [blame] | 291 | config_only: Only configure each build, don't build it |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 292 | squash_config_y: Convert CONFIG options with the value 'y' to '1' |
Daniel Schwierzeck | 20e2ea9 | 2018-01-26 16:31:05 +0100 | [diff] [blame] | 293 | warnings_as_errors: Treat all compiler warnings as errors |
Simon Glass | b6eb8cf | 2020-03-18 09:42:42 -0600 | [diff] [blame] | 294 | work_in_output: Use the output directory as the work directory and |
| 295 | don't write to a separate output directory. |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 296 | test_thread_exceptions: Uses for tests only, True to make the |
| 297 | threads raise an exception instead of reporting their result. |
| 298 | This simulates a failure in the code somewhere |
Simon Glass | e5650a8 | 2022-01-22 05:07:33 -0700 | [diff] [blame] | 299 | adjust_cfg_list (list of str): List of changes to make to .config |
| 300 | file before building. Each is one of (where C is the config |
| 301 | option with or without the CONFIG_ prefix) |
| 302 | |
| 303 | C to enable C |
| 304 | ~C to disable C |
| 305 | C=val to set the value of C (val must have quotes if C is |
| 306 | a string Kconfig |
Tom Rini | 93ebd46 | 2022-11-09 19:14:53 -0700 | [diff] [blame] | 307 | allow_missing: Run build with BINMAN_ALLOW_MISSING=1 |
Simon Glass | f6bfcca | 2023-02-21 12:40:28 -0700 | [diff] [blame] | 308 | no_lto (bool): True to set the NO_LTO flag when building |
Simon Glass | cf91d31 | 2023-07-19 17:48:52 -0600 | [diff] [blame] | 309 | force_build (bool): Rebuild even commits that are already built |
| 310 | force_build_failures (bool): Rebuild commits that have not been |
| 311 | built, or failed to build |
| 312 | force_reconfig (bool): Reconfigure on each commit |
| 313 | in_tree (bool): Bulid in tree instead of out-of-tree |
| 314 | force_config_on_failure (bool): Reconfigure the build before |
| 315 | retrying a failed build |
| 316 | make_func (function): Function to call to run 'make' |
Simon Glass | 600ede9 | 2024-08-15 13:57:45 -0600 | [diff] [blame] | 317 | dtc_skip (bool): True to skip building dtc and use the system one |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 318 | """ |
| 319 | self.toolchains = toolchains |
| 320 | self.base_dir = base_dir |
Simon Glass | b6eb8cf | 2020-03-18 09:42:42 -0600 | [diff] [blame] | 321 | if work_in_output: |
| 322 | self._working_dir = base_dir |
| 323 | else: |
| 324 | self._working_dir = os.path.join(base_dir, '.bm-work') |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 325 | self.threads = [] |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 326 | self.do_make = make_func or self.make |
Masahiro Yamada | 1fe610d | 2014-07-22 11:19:09 +0900 | [diff] [blame] | 327 | self.gnu_make = gnu_make |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 328 | self.checkout = checkout |
| 329 | self.num_threads = num_threads |
| 330 | self.num_jobs = num_jobs |
| 331 | self.already_done = 0 |
| 332 | self.force_build = False |
| 333 | self.git_dir = git_dir |
| 334 | self._show_unknown = show_unknown |
| 335 | self._timestamp_count = 10 |
| 336 | self._build_period_us = None |
| 337 | self._complete_delay = None |
| 338 | self._next_delay_update = datetime.now() |
Simon Glass | 7190a17 | 2023-09-07 10:00:19 -0600 | [diff] [blame] | 339 | self._start_time = None |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 340 | self._step = step |
Simon Glass | bb4dffb | 2014-08-09 15:33:06 -0600 | [diff] [blame] | 341 | self._error_lines = 0 |
Simon Glass | e87bde1 | 2014-12-01 17:33:55 -0700 | [diff] [blame] | 342 | self.no_subdirs = no_subdirs |
Tom Rini | 3f6f9b2 | 2024-07-05 14:34:07 -0600 | [diff] [blame] | 343 | self.full_path = full_path |
Simon Glass | 655b610 | 2014-12-01 17:34:07 -0700 | [diff] [blame] | 344 | self.verbose_build = verbose_build |
Simon Glass | 739e851 | 2016-11-13 14:25:51 -0700 | [diff] [blame] | 345 | self.config_only = config_only |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 346 | self.squash_config_y = squash_config_y |
| 347 | self.config_filenames = BASE_CONFIG_FILENAMES |
Simon Glass | b6eb8cf | 2020-03-18 09:42:42 -0600 | [diff] [blame] | 348 | self.work_in_output = work_in_output |
Simon Glass | e5650a8 | 2022-01-22 05:07:33 -0700 | [diff] [blame] | 349 | self.adjust_cfg = adjust_cfg |
Tom Rini | 93ebd46 | 2022-11-09 19:14:53 -0700 | [diff] [blame] | 350 | self.allow_missing = allow_missing |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 351 | self._ide = False |
Simon Glass | f6bfcca | 2023-02-21 12:40:28 -0700 | [diff] [blame] | 352 | self.no_lto = no_lto |
Simon Glass | 828d70d | 2023-02-21 12:40:29 -0700 | [diff] [blame] | 353 | self.reproducible_builds = reproducible_builds |
Simon Glass | cf91d31 | 2023-07-19 17:48:52 -0600 | [diff] [blame] | 354 | self.force_build = force_build |
| 355 | self.force_build_failures = force_build_failures |
| 356 | self.force_reconfig = force_reconfig |
| 357 | self.in_tree = in_tree |
| 358 | self.force_config_on_failure = force_config_on_failure |
Simon Glass | 222825b | 2024-06-23 11:55:13 -0600 | [diff] [blame] | 359 | self.fallback_mrproper = fallback_mrproper |
Simon Glass | 600ede9 | 2024-08-15 13:57:45 -0600 | [diff] [blame] | 360 | if dtc_skip: |
| 361 | self.dtc = shutil.which('dtc') |
| 362 | if not self.dtc: |
| 363 | raise ValueError('Cannot find dtc') |
| 364 | else: |
| 365 | self.dtc = None |
Simon Glass | e5650a8 | 2022-01-22 05:07:33 -0700 | [diff] [blame] | 366 | |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 367 | if not self.squash_config_y: |
| 368 | self.config_filenames += EXTRA_CONFIG_FILENAMES |
Simon Glass | 146b602 | 2021-10-19 21:43:24 -0600 | [diff] [blame] | 369 | self._terminated = False |
| 370 | self._restarting_config = False |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 371 | |
Daniel Schwierzeck | 20e2ea9 | 2018-01-26 16:31:05 +0100 | [diff] [blame] | 372 | self.warnings_as_errors = warnings_as_errors |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 373 | self.col = terminal.Color() |
| 374 | |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 375 | self._re_function = re.compile('(.*): In function.*') |
| 376 | self._re_files = re.compile('In file included from.*') |
Simon Glass | 1f3a122 | 2024-09-21 19:57:57 +0200 | [diff] [blame] | 377 | self._re_warning = re.compile(r'(.*):(\d*):(\d*): warning: .*') |
Simon Glass | 0db9443 | 2018-11-06 16:02:11 -0700 | [diff] [blame] | 378 | self._re_dtb_warning = re.compile('(.*): Warning .*') |
Simon Glass | 1f3a122 | 2024-09-21 19:57:57 +0200 | [diff] [blame] | 379 | self._re_note = re.compile(r'(.*):(\d*):(\d*): note: this is the location of the previous.*') |
Simon Glass | f4ebfba | 2020-04-09 15:08:53 -0600 | [diff] [blame] | 380 | self._re_migration_warning = re.compile(r'^={21} WARNING ={22}\n.*\n=+\n', |
| 381 | re.MULTILINE | re.DOTALL) |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 382 | |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 383 | self.thread_exceptions = [] |
| 384 | self.test_thread_exceptions = test_thread_exceptions |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 385 | if self.num_threads: |
| 386 | self._single_builder = None |
| 387 | self.queue = queue.Queue() |
| 388 | self.out_queue = queue.Queue() |
| 389 | for i in range(self.num_threads): |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 390 | t = builderthread.BuilderThread( |
| 391 | self, i, mrproper, per_board_out_dir, |
| 392 | test_exception=test_thread_exceptions) |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 393 | t.setDaemon(True) |
| 394 | t.start() |
| 395 | self.threads.append(t) |
| 396 | |
| 397 | t = builderthread.ResultThread(self) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 398 | t.setDaemon(True) |
| 399 | t.start() |
| 400 | self.threads.append(t) |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 401 | else: |
| 402 | self._single_builder = builderthread.BuilderThread( |
| 403 | self, -1, mrproper, per_board_out_dir) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 404 | |
| 405 | ignore_lines = ['(make.*Waiting for unfinished)', '(Segmentation fault)'] |
| 406 | self.re_make_err = re.compile('|'.join(ignore_lines)) |
| 407 | |
Simon Glass | 205ac04 | 2016-09-18 16:48:37 -0600 | [diff] [blame] | 408 | # Handle existing graceful with SIGINT / Ctrl-C |
| 409 | signal.signal(signal.SIGINT, self.signal_handler) |
| 410 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 411 | def __del__(self): |
| 412 | """Get rid of all threads created by the builder""" |
| 413 | for t in self.threads: |
| 414 | del t |
| 415 | |
Simon Glass | 205ac04 | 2016-09-18 16:48:37 -0600 | [diff] [blame] | 416 | def signal_handler(self, signal, frame): |
| 417 | sys.exit(1) |
| 418 | |
Simon Glass | 600ede9 | 2024-08-15 13:57:45 -0600 | [diff] [blame] | 419 | def make_environment(self, toolchain): |
| 420 | """Create the environment to use for building |
| 421 | |
| 422 | Args: |
| 423 | toolchain (Toolchain): Toolchain to use for building |
| 424 | |
| 425 | Returns: |
| 426 | dict: |
| 427 | key (str): Variable name |
| 428 | value (str): Variable value |
| 429 | """ |
| 430 | env = toolchain.MakeEnvironment(self.full_path) |
| 431 | if self.dtc: |
| 432 | env[b'DTC'] = tools.to_bytes(self.dtc) |
| 433 | return env |
| 434 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 435 | def set_display_options(self, show_errors=False, show_sizes=False, |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 436 | show_detail=False, show_bloat=False, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 437 | list_error_boards=False, show_config=False, |
Simon Glass | f4ebfba | 2020-04-09 15:08:53 -0600 | [diff] [blame] | 438 | show_environment=False, filter_dtb_warnings=False, |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 439 | filter_migration_warnings=False, ide=False): |
Simon Glass | eb48bbc | 2014-08-09 15:33:02 -0600 | [diff] [blame] | 440 | """Setup display options for the builder. |
| 441 | |
Simon Glass | 9ea9381 | 2020-04-09 15:08:52 -0600 | [diff] [blame] | 442 | Args: |
| 443 | show_errors: True to show summarised error/warning info |
| 444 | show_sizes: Show size deltas |
| 445 | show_detail: Show size delta detail for each board if show_sizes |
| 446 | show_bloat: Show detail for each function |
| 447 | list_error_boards: Show the boards which caused each error/warning |
| 448 | show_config: Show config deltas |
| 449 | show_environment: Show environment deltas |
| 450 | filter_dtb_warnings: Filter out any warnings from the device-tree |
| 451 | compiler |
Simon Glass | f4ebfba | 2020-04-09 15:08:53 -0600 | [diff] [blame] | 452 | filter_migration_warnings: Filter out any warnings about migrating |
| 453 | a board to driver model |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 454 | ide: Create output that can be parsed by an IDE. There is no '+' prefix on |
| 455 | error lines and output on stderr stays on stderr. |
Simon Glass | eb48bbc | 2014-08-09 15:33:02 -0600 | [diff] [blame] | 456 | """ |
| 457 | self._show_errors = show_errors |
| 458 | self._show_sizes = show_sizes |
| 459 | self._show_detail = show_detail |
| 460 | self._show_bloat = show_bloat |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 461 | self._list_error_boards = list_error_boards |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 462 | self._show_config = show_config |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 463 | self._show_environment = show_environment |
Simon Glass | 9ea9381 | 2020-04-09 15:08:52 -0600 | [diff] [blame] | 464 | self._filter_dtb_warnings = filter_dtb_warnings |
Simon Glass | f4ebfba | 2020-04-09 15:08:53 -0600 | [diff] [blame] | 465 | self._filter_migration_warnings = filter_migration_warnings |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 466 | self._ide = ide |
Simon Glass | eb48bbc | 2014-08-09 15:33:02 -0600 | [diff] [blame] | 467 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 468 | def _add_timestamp(self): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 469 | """Add a new timestamp to the list and record the build period. |
| 470 | |
| 471 | The build period is the length of time taken to perform a single |
| 472 | build (one board, one commit). |
| 473 | """ |
| 474 | now = datetime.now() |
| 475 | self._timestamps.append(now) |
| 476 | count = len(self._timestamps) |
| 477 | delta = self._timestamps[-1] - self._timestamps[0] |
| 478 | seconds = delta.total_seconds() |
| 479 | |
| 480 | # If we have enough data, estimate build period (time taken for a |
| 481 | # single build) and therefore completion time. |
| 482 | if count > 1 and self._next_delay_update < now: |
| 483 | self._next_delay_update = now + timedelta(seconds=2) |
| 484 | if seconds > 0: |
| 485 | self._build_period = float(seconds) / count |
| 486 | todo = self.count - self.upto |
| 487 | self._complete_delay = timedelta(microseconds= |
| 488 | self._build_period * todo * 1000000) |
| 489 | # Round it |
| 490 | self._complete_delay -= timedelta( |
| 491 | microseconds=self._complete_delay.microseconds) |
| 492 | |
| 493 | if seconds > 60: |
| 494 | self._timestamps.popleft() |
| 495 | count -= 1 |
| 496 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 497 | def select_commit(self, commit, checkout=True): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 498 | """Checkout the selected commit for this build |
| 499 | """ |
| 500 | self.commit = commit |
| 501 | if checkout and self.checkout: |
Simon Glass | 761648b | 2022-01-29 14:14:11 -0700 | [diff] [blame] | 502 | gitutil.checkout(commit.hash) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 503 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 504 | def make(self, commit, brd, stage, cwd, *args, **kwargs): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 505 | """Run make |
| 506 | |
| 507 | Args: |
| 508 | commit: Commit object that is being built |
| 509 | brd: Board object that is being built |
Simon Glass | d6c1ec8 | 2023-10-26 14:31:10 -0400 | [diff] [blame] | 510 | stage: Stage that we are at (mrproper, config, oldconfig, build) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 511 | cwd: Directory where make should be run |
| 512 | args: Arguments to pass to make |
Simon Glass | 840be73 | 2022-01-29 14:14:05 -0700 | [diff] [blame] | 513 | kwargs: Arguments to pass to command.run_pipe() |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 514 | """ |
Simon Glass | 146b602 | 2021-10-19 21:43:24 -0600 | [diff] [blame] | 515 | |
| 516 | def check_output(stream, data): |
| 517 | if b'Restart config' in data: |
| 518 | self._restarting_config = True |
| 519 | |
| 520 | # If we see 'Restart config' following by multiple errors |
| 521 | if self._restarting_config: |
| 522 | m = RE_NO_DEFAULT.findall(data) |
| 523 | |
| 524 | # Number of occurences of each Kconfig item |
| 525 | multiple = [m.count(val) for val in set(m)] |
| 526 | |
| 527 | # If any of them occur more than once, we have a loop |
| 528 | if [val for val in multiple if val > 1]: |
| 529 | self._terminated = True |
| 530 | return True |
| 531 | return False |
| 532 | |
| 533 | self._restarting_config = False |
| 534 | self._terminated = False |
Masahiro Yamada | 1fe610d | 2014-07-22 11:19:09 +0900 | [diff] [blame] | 535 | cmd = [self.gnu_make] + list(args) |
Simon Glass | 840be73 | 2022-01-29 14:14:05 -0700 | [diff] [blame] | 536 | result = command.run_pipe([cmd], capture=True, capture_stderr=True, |
Simon Glass | 146b602 | 2021-10-19 21:43:24 -0600 | [diff] [blame] | 537 | cwd=cwd, raise_on_error=False, infile='/dev/null', |
| 538 | output_func=check_output, **kwargs) |
| 539 | |
| 540 | if self._terminated: |
| 541 | # Try to be helpful |
| 542 | result.stderr += '(** did you define an int/hex Kconfig with no default? **)' |
| 543 | |
Simon Glass | 413f91a | 2015-02-05 22:06:12 -0700 | [diff] [blame] | 544 | if self.verbose_build: |
| 545 | result.stdout = '%s\n' % (' '.join(cmd)) + result.stdout |
| 546 | result.combined = '%s\n' % (' '.join(cmd)) + result.combined |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 547 | return result |
| 548 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 549 | def process_result(self, result): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 550 | """Process the result of a build, showing progress information |
| 551 | |
| 552 | Args: |
Simon Glass | 78e418e | 2014-08-09 15:33:03 -0600 | [diff] [blame] | 553 | result: A CommandResult object, which indicates the result for |
| 554 | a single build |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 555 | """ |
| 556 | col = terminal.Color() |
| 557 | if result: |
| 558 | target = result.brd.target |
| 559 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 560 | self.upto += 1 |
| 561 | if result.return_code != 0: |
| 562 | self.fail += 1 |
| 563 | elif result.stderr: |
| 564 | self.warned += 1 |
| 565 | if result.already_done: |
| 566 | self.already_done += 1 |
Simon Glass | 78e418e | 2014-08-09 15:33:03 -0600 | [diff] [blame] | 567 | if self._verbose: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 568 | terminal.print_clear() |
Simon Glass | 78e418e | 2014-08-09 15:33:03 -0600 | [diff] [blame] | 569 | boards_selected = {target : result.brd} |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 570 | self.reset_result_summary(boards_selected) |
| 571 | self.produce_result_summary(result.commit_upto, self.commits, |
Simon Glass | 78e418e | 2014-08-09 15:33:03 -0600 | [diff] [blame] | 572 | boards_selected) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 573 | else: |
| 574 | target = '(starting)' |
| 575 | |
| 576 | # Display separate counts for ok, warned and fail |
| 577 | ok = self.upto - self.warned - self.fail |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 578 | line = '\r' + self.col.build(self.col.GREEN, '%5d' % ok) |
| 579 | line += self.col.build(self.col.YELLOW, '%5d' % self.warned) |
| 580 | line += self.col.build(self.col.RED, '%5d' % self.fail) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 581 | |
Simon Glass | 69c3a8a | 2020-04-09 15:08:45 -0600 | [diff] [blame] | 582 | line += ' /%-5d ' % self.count |
| 583 | remaining = self.count - self.upto |
| 584 | if remaining: |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 585 | line += self.col.build(self.col.MAGENTA, ' -%-5d ' % remaining) |
Simon Glass | 69c3a8a | 2020-04-09 15:08:45 -0600 | [diff] [blame] | 586 | else: |
| 587 | line += ' ' * 8 |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 588 | |
| 589 | # Add our current completion time estimate |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 590 | self._add_timestamp() |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 591 | if self._complete_delay: |
Simon Glass | 69c3a8a | 2020-04-09 15:08:45 -0600 | [diff] [blame] | 592 | line += '%s : ' % self._complete_delay |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 593 | |
Simon Glass | 69c3a8a | 2020-04-09 15:08:45 -0600 | [diff] [blame] | 594 | line += target |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 595 | if not self._ide: |
| 596 | terminal.print_clear() |
| 597 | tprint(line, newline=False, limit_to_line=True) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 598 | |
Simon Glass | 4cb5468 | 2023-07-19 17:49:10 -0600 | [diff] [blame] | 599 | def get_output_dir(self, commit_upto): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 600 | """Get the name of the output directory for a commit number |
| 601 | |
| 602 | The output directory is typically .../<branch>/<commit>. |
| 603 | |
| 604 | Args: |
| 605 | commit_upto: Commit number to use (0..self.count-1) |
| 606 | """ |
Simon Glass | e3c85ab | 2020-04-17 17:51:34 -0600 | [diff] [blame] | 607 | if self.work_in_output: |
| 608 | return self._working_dir |
| 609 | |
Simon Glass | e87bde1 | 2014-12-01 17:33:55 -0700 | [diff] [blame] | 610 | commit_dir = None |
Simon Glass | d326ad7 | 2014-08-09 15:32:59 -0600 | [diff] [blame] | 611 | if self.commits: |
| 612 | commit = self.commits[commit_upto] |
| 613 | subject = commit.subject.translate(trans_valid_chars) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 614 | # See _get_output_space_removals() which parses this name |
Ovidiu Panait | ee8e9cb | 2020-05-15 09:30:12 +0300 | [diff] [blame] | 615 | commit_dir = ('%02d_g%s_%s' % (commit_upto + 1, |
| 616 | commit.hash, subject[:20])) |
Simon Glass | e87bde1 | 2014-12-01 17:33:55 -0700 | [diff] [blame] | 617 | elif not self.no_subdirs: |
Simon Glass | d326ad7 | 2014-08-09 15:32:59 -0600 | [diff] [blame] | 618 | commit_dir = 'current' |
Simon Glass | e87bde1 | 2014-12-01 17:33:55 -0700 | [diff] [blame] | 619 | if not commit_dir: |
| 620 | return self.base_dir |
| 621 | return os.path.join(self.base_dir, commit_dir) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 622 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 623 | def get_build_dir(self, commit_upto, target): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 624 | """Get the name of the build directory for a commit number |
| 625 | |
| 626 | The build directory is typically .../<branch>/<commit>/<target>. |
| 627 | |
| 628 | Args: |
| 629 | commit_upto: Commit number to use (0..self.count-1) |
| 630 | target: Target name |
| 631 | """ |
Simon Glass | 4cb5468 | 2023-07-19 17:49:10 -0600 | [diff] [blame] | 632 | output_dir = self.get_output_dir(commit_upto) |
Simon Glass | e3c85ab | 2020-04-17 17:51:34 -0600 | [diff] [blame] | 633 | if self.work_in_output: |
| 634 | return output_dir |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 635 | return os.path.join(output_dir, target) |
| 636 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 637 | def get_done_file(self, commit_upto, target): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 638 | """Get the name of the done file for a commit number |
| 639 | |
| 640 | Args: |
| 641 | commit_upto: Commit number to use (0..self.count-1) |
| 642 | target: Target name |
| 643 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 644 | return os.path.join(self.get_build_dir(commit_upto, target), 'done') |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 645 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 646 | def get_sizes_file(self, commit_upto, target): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 647 | """Get the name of the sizes file for a commit number |
| 648 | |
| 649 | Args: |
| 650 | commit_upto: Commit number to use (0..self.count-1) |
| 651 | target: Target name |
| 652 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 653 | return os.path.join(self.get_build_dir(commit_upto, target), 'sizes') |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 654 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 655 | def get_func_sizes_file(self, commit_upto, target, elf_fname): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 656 | """Get the name of the funcsizes file for a commit number and ELF file |
| 657 | |
| 658 | Args: |
| 659 | commit_upto: Commit number to use (0..self.count-1) |
| 660 | target: Target name |
| 661 | elf_fname: Filename of elf image |
| 662 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 663 | return os.path.join(self.get_build_dir(commit_upto, target), |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 664 | '%s.sizes' % elf_fname.replace('/', '-')) |
| 665 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 666 | def get_objdump_file(self, commit_upto, target, elf_fname): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 667 | """Get the name of the objdump file for a commit number and ELF file |
| 668 | |
| 669 | Args: |
| 670 | commit_upto: Commit number to use (0..self.count-1) |
| 671 | target: Target name |
| 672 | elf_fname: Filename of elf image |
| 673 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 674 | return os.path.join(self.get_build_dir(commit_upto, target), |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 675 | '%s.objdump' % elf_fname.replace('/', '-')) |
| 676 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 677 | def get_err_file(self, commit_upto, target): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 678 | """Get the name of the err file for a commit number |
| 679 | |
| 680 | Args: |
| 681 | commit_upto: Commit number to use (0..self.count-1) |
| 682 | target: Target name |
| 683 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 684 | output_dir = self.get_build_dir(commit_upto, target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 685 | return os.path.join(output_dir, 'err') |
| 686 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 687 | def filter_errors(self, lines): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 688 | """Filter out errors in which we have no interest |
| 689 | |
| 690 | We should probably use map(). |
| 691 | |
| 692 | Args: |
| 693 | lines: List of error lines, each a string |
| 694 | Returns: |
| 695 | New list with only interesting lines included |
| 696 | """ |
| 697 | out_lines = [] |
Simon Glass | f4ebfba | 2020-04-09 15:08:53 -0600 | [diff] [blame] | 698 | if self._filter_migration_warnings: |
| 699 | text = '\n'.join(lines) |
| 700 | text = self._re_migration_warning.sub('', text) |
| 701 | lines = text.splitlines() |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 702 | for line in lines: |
Simon Glass | 9ea9381 | 2020-04-09 15:08:52 -0600 | [diff] [blame] | 703 | if self.re_make_err.search(line): |
| 704 | continue |
| 705 | if self._filter_dtb_warnings and self._re_dtb_warning.search(line): |
| 706 | continue |
| 707 | out_lines.append(line) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 708 | return out_lines |
| 709 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 710 | def read_func_sizes(self, fname, fd): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 711 | """Read function sizes from the output of 'nm' |
| 712 | |
| 713 | Args: |
| 714 | fd: File containing data to read |
| 715 | fname: Filename we are reading from (just for errors) |
| 716 | |
| 717 | Returns: |
| 718 | Dictionary containing size of each function in bytes, indexed by |
| 719 | function name. |
| 720 | """ |
| 721 | sym = {} |
| 722 | for line in fd.readlines(): |
Simon Glass | 86a2afe | 2022-07-11 19:04:11 -0600 | [diff] [blame] | 723 | line = line.strip() |
| 724 | parts = line.split() |
| 725 | if line and len(parts) == 3: |
| 726 | size, type, name = line.split() |
Simon Glass | dac7371 | 2023-10-23 00:52:43 -0700 | [diff] [blame] | 727 | if type in NM_SYMBOL_TYPES: |
Simon Glass | 86a2afe | 2022-07-11 19:04:11 -0600 | [diff] [blame] | 728 | # function names begin with '.' on 64-bit powerpc |
| 729 | if '.' in name[1:]: |
| 730 | name = 'static.' + name.split('.')[0] |
| 731 | sym[name] = sym.get(name, 0) + int(size, 16) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 732 | return sym |
| 733 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 734 | def _process_config(self, fname): |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 735 | """Read in a .config, autoconf.mk or autoconf.h file |
| 736 | |
| 737 | This function handles all config file types. It ignores comments and |
| 738 | any #defines which don't start with CONFIG_. |
| 739 | |
| 740 | Args: |
| 741 | fname: Filename to read |
| 742 | |
| 743 | Returns: |
| 744 | Dictionary: |
| 745 | key: Config name (e.g. CONFIG_DM) |
| 746 | value: Config value (e.g. 1) |
| 747 | """ |
| 748 | config = {} |
| 749 | if os.path.exists(fname): |
| 750 | with open(fname) as fd: |
| 751 | for line in fd: |
| 752 | line = line.strip() |
| 753 | if line.startswith('#define'): |
| 754 | values = line[8:].split(' ', 1) |
| 755 | if len(values) > 1: |
| 756 | key, value = values |
| 757 | else: |
| 758 | key = values[0] |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 759 | value = '1' if self.squash_config_y else '' |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 760 | if not key.startswith('CONFIG_'): |
| 761 | continue |
| 762 | elif not line or line[0] in ['#', '*', '/']: |
| 763 | continue |
| 764 | else: |
| 765 | key, value = line.split('=', 1) |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 766 | if self.squash_config_y and value == 'y': |
| 767 | value = '1' |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 768 | config[key] = value |
| 769 | return config |
| 770 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 771 | def _process_environment(self, fname): |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 772 | """Read in a uboot.env file |
| 773 | |
| 774 | This function reads in environment variables from a file. |
| 775 | |
| 776 | Args: |
| 777 | fname: Filename to read |
| 778 | |
| 779 | Returns: |
| 780 | Dictionary: |
| 781 | key: environment variable (e.g. bootlimit) |
| 782 | value: value of environment variable (e.g. 1) |
| 783 | """ |
| 784 | environment = {} |
| 785 | if os.path.exists(fname): |
| 786 | with open(fname) as fd: |
| 787 | for line in fd.read().split('\0'): |
| 788 | try: |
| 789 | key, value = line.split('=', 1) |
| 790 | environment[key] = value |
| 791 | except ValueError: |
| 792 | # ignore lines we can't parse |
| 793 | pass |
| 794 | return environment |
| 795 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 796 | def get_build_outcome(self, commit_upto, target, read_func_sizes, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 797 | read_config, read_environment): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 798 | """Work out the outcome of a build. |
| 799 | |
| 800 | Args: |
| 801 | commit_upto: Commit number to check (0..n-1) |
| 802 | target: Target board to check |
| 803 | read_func_sizes: True to read function size information |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 804 | read_config: True to read .config and autoconf.h files |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 805 | read_environment: True to read uboot.env files |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 806 | |
| 807 | Returns: |
| 808 | Outcome object |
| 809 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 810 | done_file = self.get_done_file(commit_upto, target) |
| 811 | sizes_file = self.get_sizes_file(commit_upto, target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 812 | sizes = {} |
| 813 | func_sizes = {} |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 814 | config = {} |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 815 | environment = {} |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 816 | if os.path.exists(done_file): |
| 817 | with open(done_file, 'r') as fd: |
Simon Glass | 91c54a4 | 2019-04-26 19:02:23 -0600 | [diff] [blame] | 818 | try: |
| 819 | return_code = int(fd.readline()) |
| 820 | except ValueError: |
| 821 | # The file may be empty due to running out of disk space. |
| 822 | # Try a rebuild |
| 823 | return_code = 1 |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 824 | err_lines = [] |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 825 | err_file = self.get_err_file(commit_upto, target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 826 | if os.path.exists(err_file): |
| 827 | with open(err_file, 'r') as fd: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 828 | err_lines = self.filter_errors(fd.readlines()) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 829 | |
| 830 | # Decide whether the build was ok, failed or created warnings |
| 831 | if return_code: |
| 832 | rc = OUTCOME_ERROR |
| 833 | elif len(err_lines): |
| 834 | rc = OUTCOME_WARNING |
| 835 | else: |
| 836 | rc = OUTCOME_OK |
| 837 | |
| 838 | # Convert size information to our simple format |
| 839 | if os.path.exists(sizes_file): |
| 840 | with open(sizes_file, 'r') as fd: |
| 841 | for line in fd.readlines(): |
| 842 | values = line.split() |
| 843 | rodata = 0 |
| 844 | if len(values) > 6: |
| 845 | rodata = int(values[6], 16) |
| 846 | size_dict = { |
| 847 | 'all' : int(values[0]) + int(values[1]) + |
| 848 | int(values[2]), |
| 849 | 'text' : int(values[0]) - rodata, |
| 850 | 'data' : int(values[1]), |
| 851 | 'bss' : int(values[2]), |
| 852 | 'rodata' : rodata, |
| 853 | } |
| 854 | sizes[values[5]] = size_dict |
| 855 | |
| 856 | if read_func_sizes: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 857 | pattern = self.get_func_sizes_file(commit_upto, target, '*') |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 858 | for fname in glob.glob(pattern): |
| 859 | with open(fname, 'r') as fd: |
| 860 | dict_name = os.path.basename(fname).replace('.sizes', |
| 861 | '') |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 862 | func_sizes[dict_name] = self.read_func_sizes(fname, fd) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 863 | |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 864 | if read_config: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 865 | output_dir = self.get_build_dir(commit_upto, target) |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 866 | for name in self.config_filenames: |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 867 | fname = os.path.join(output_dir, name) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 868 | config[name] = self._process_config(fname) |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 869 | |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 870 | if read_environment: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 871 | output_dir = self.get_build_dir(commit_upto, target) |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 872 | fname = os.path.join(output_dir, 'uboot.env') |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 873 | environment = self._process_environment(fname) |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 874 | |
| 875 | return Builder.Outcome(rc, err_lines, sizes, func_sizes, config, |
| 876 | environment) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 877 | |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 878 | return Builder.Outcome(OUTCOME_UNKNOWN, [], {}, {}, {}, {}) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 879 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 880 | def get_result_summary(self, boards_selected, commit_upto, read_func_sizes, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 881 | read_config, read_environment): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 882 | """Calculate a summary of the results of building a commit. |
| 883 | |
| 884 | Args: |
| 885 | board_selected: Dict containing boards to summarise |
| 886 | commit_upto: Commit number to summarize (0..self.count-1) |
| 887 | read_func_sizes: True to read function size information |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 888 | read_config: True to read .config and autoconf.h files |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 889 | read_environment: True to read uboot.env files |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 890 | |
| 891 | Returns: |
| 892 | Tuple: |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 893 | Dict containing boards which built this commit: |
| 894 | key: board.target |
| 895 | value: Builder.Outcome object |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 896 | List containing a summary of error lines |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 897 | Dict keyed by error line, containing a list of the Board |
| 898 | objects with that error |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 899 | List containing a summary of warning lines |
| 900 | Dict keyed by error line, containing a list of the Board |
| 901 | objects with that warning |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 902 | Dictionary keyed by board.target. Each value is a dictionary: |
| 903 | key: filename - e.g. '.config' |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 904 | value is itself a dictionary: |
| 905 | key: config name |
| 906 | value: config value |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 907 | Dictionary keyed by board.target. Each value is a dictionary: |
| 908 | key: environment variable |
| 909 | value: value of environment variable |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 910 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 911 | def add_line(lines_summary, lines_boards, line, board): |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 912 | line = line.rstrip() |
| 913 | if line in lines_boards: |
| 914 | lines_boards[line].append(board) |
| 915 | else: |
| 916 | lines_boards[line] = [board] |
| 917 | lines_summary.append(line) |
| 918 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 919 | board_dict = {} |
| 920 | err_lines_summary = [] |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 921 | err_lines_boards = {} |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 922 | warn_lines_summary = [] |
| 923 | warn_lines_boards = {} |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 924 | config = {} |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 925 | environment = {} |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 926 | |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 927 | for brd in boards_selected.values(): |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 928 | outcome = self.get_build_outcome(commit_upto, brd.target, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 929 | read_func_sizes, read_config, |
| 930 | read_environment) |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 931 | board_dict[brd.target] = outcome |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 932 | last_func = None |
| 933 | last_was_warning = False |
| 934 | for line in outcome.err_lines: |
| 935 | if line: |
| 936 | if (self._re_function.match(line) or |
| 937 | self._re_files.match(line)): |
| 938 | last_func = line |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 939 | else: |
Simon Glass | 0db9443 | 2018-11-06 16:02:11 -0700 | [diff] [blame] | 940 | is_warning = (self._re_warning.match(line) or |
| 941 | self._re_dtb_warning.match(line)) |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 942 | is_note = self._re_note.match(line) |
| 943 | if is_warning or (last_was_warning and is_note): |
| 944 | if last_func: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 945 | add_line(warn_lines_summary, warn_lines_boards, |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 946 | last_func, brd) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 947 | add_line(warn_lines_summary, warn_lines_boards, |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 948 | line, brd) |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 949 | else: |
| 950 | if last_func: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 951 | add_line(err_lines_summary, err_lines_boards, |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 952 | last_func, brd) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 953 | add_line(err_lines_summary, err_lines_boards, |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 954 | line, brd) |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 955 | last_was_warning = is_warning |
| 956 | last_func = None |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 957 | tconfig = Config(self.config_filenames, brd.target) |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 958 | for fname in self.config_filenames: |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 959 | if outcome.config: |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 960 | for key, value in outcome.config[fname].items(): |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 961 | tconfig.add(fname, key, value) |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 962 | config[brd.target] = tconfig |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 963 | |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 964 | tenvironment = Environment(brd.target) |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 965 | if outcome.environment: |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 966 | for key, value in outcome.environment.items(): |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 967 | tenvironment.add(key, value) |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 968 | environment[brd.target] = tenvironment |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 969 | |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 970 | return (board_dict, err_lines_summary, err_lines_boards, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 971 | warn_lines_summary, warn_lines_boards, config, environment) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 972 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 973 | def add_outcome(self, board_dict, arch_list, changes, char, color): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 974 | """Add an output to our list of outcomes for each architecture |
| 975 | |
| 976 | This simple function adds failing boards (changes) to the |
| 977 | relevant architecture string, so we can print the results out |
| 978 | sorted by architecture. |
| 979 | |
| 980 | Args: |
| 981 | board_dict: Dict containing all boards |
| 982 | arch_list: Dict keyed by arch name. Value is a string containing |
| 983 | a list of board names which failed for that arch. |
| 984 | changes: List of boards to add to arch_list |
| 985 | color: terminal.Colour object |
| 986 | """ |
| 987 | done_arch = {} |
| 988 | for target in changes: |
| 989 | if target in board_dict: |
| 990 | arch = board_dict[target].arch |
| 991 | else: |
| 992 | arch = 'unknown' |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 993 | str = self.col.build(color, ' ' + target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 994 | if not arch in done_arch: |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 995 | str = ' %s %s' % (self.col.build(color, char), str) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 996 | done_arch[arch] = True |
| 997 | if not arch in arch_list: |
| 998 | arch_list[arch] = str |
| 999 | else: |
| 1000 | arch_list[arch] += str |
| 1001 | |
| 1002 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1003 | def colour_num(self, num): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1004 | color = self.col.RED if num > 0 else self.col.GREEN |
| 1005 | if num == 0: |
| 1006 | return '0' |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 1007 | return self.col.build(color, str(num)) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1008 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1009 | def reset_result_summary(self, board_selected): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1010 | """Reset the results summary ready for use. |
| 1011 | |
| 1012 | Set up the base board list to be all those selected, and set the |
| 1013 | error lines to empty. |
| 1014 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1015 | Following this, calls to print_result_summary() will use this |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1016 | information to work out what has changed. |
| 1017 | |
| 1018 | Args: |
| 1019 | board_selected: Dict containing boards to summarise, keyed by |
| 1020 | board.target |
| 1021 | """ |
| 1022 | self._base_board_dict = {} |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 1023 | for brd in board_selected: |
| 1024 | self._base_board_dict[brd] = Builder.Outcome(0, [], [], {}, {}, {}) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1025 | self._base_err_lines = [] |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1026 | self._base_warn_lines = [] |
| 1027 | self._base_err_line_boards = {} |
| 1028 | self._base_warn_line_boards = {} |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1029 | self._base_config = None |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1030 | self._base_environment = None |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1031 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1032 | def print_func_size_detail(self, fname, old, new): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1033 | grow, shrink, add, remove, up, down = 0, 0, 0, 0, 0, 0 |
| 1034 | delta, common = [], {} |
| 1035 | |
| 1036 | for a in old: |
| 1037 | if a in new: |
| 1038 | common[a] = 1 |
| 1039 | |
| 1040 | for name in old: |
| 1041 | if name not in common: |
| 1042 | remove += 1 |
| 1043 | down += old[name] |
| 1044 | delta.append([-old[name], name]) |
| 1045 | |
| 1046 | for name in new: |
| 1047 | if name not in common: |
| 1048 | add += 1 |
| 1049 | up += new[name] |
| 1050 | delta.append([new[name], name]) |
| 1051 | |
| 1052 | for name in common: |
| 1053 | diff = new.get(name, 0) - old.get(name, 0) |
| 1054 | if diff > 0: |
| 1055 | grow, up = grow + 1, up + diff |
| 1056 | elif diff < 0: |
| 1057 | shrink, down = shrink + 1, down - diff |
| 1058 | delta.append([diff, name]) |
| 1059 | |
| 1060 | delta.sort() |
| 1061 | delta.reverse() |
| 1062 | |
| 1063 | args = [add, -remove, grow, -shrink, up, -down, up - down] |
Tom Rini | 0b48cd6 | 2017-05-22 13:48:52 -0400 | [diff] [blame] | 1064 | if max(args) == 0 and min(args) == 0: |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1065 | return |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1066 | args = [self.colour_num(x) for x in args] |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1067 | indent = ' ' * 15 |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1068 | tprint('%s%s: add: %s/%s, grow: %s/%s bytes: %s/%s (%s)' % |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 1069 | tuple([indent, self.col.build(self.col.YELLOW, fname)] + args)) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1070 | tprint('%s %-38s %7s %7s %+7s' % (indent, 'function', 'old', 'new', |
Simon Glass | 4433aa9 | 2014-09-05 19:00:07 -0600 | [diff] [blame] | 1071 | 'delta')) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1072 | for diff, name in delta: |
| 1073 | if diff: |
| 1074 | color = self.col.RED if diff > 0 else self.col.GREEN |
| 1075 | msg = '%s %-38s %7s %7s %+7d' % (indent, name, |
| 1076 | old.get(name, '-'), new.get(name,'-'), diff) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1077 | tprint(msg, colour=color) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1078 | |
| 1079 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1080 | def print_size_detail(self, target_list, show_bloat): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1081 | """Show details size information for each board |
| 1082 | |
| 1083 | Args: |
| 1084 | target_list: List of targets, each a dict containing: |
| 1085 | 'target': Target name |
| 1086 | 'total_diff': Total difference in bytes across all areas |
| 1087 | <part_name>: Difference for that part |
| 1088 | show_bloat: Show detail for each function |
| 1089 | """ |
| 1090 | targets_by_diff = sorted(target_list, reverse=True, |
| 1091 | key=lambda x: x['_total_diff']) |
| 1092 | for result in targets_by_diff: |
| 1093 | printed_target = False |
| 1094 | for name in sorted(result): |
| 1095 | diff = result[name] |
| 1096 | if name.startswith('_'): |
| 1097 | continue |
| 1098 | if diff != 0: |
| 1099 | color = self.col.RED if diff > 0 else self.col.GREEN |
| 1100 | msg = ' %s %+d' % (name, diff) |
| 1101 | if not printed_target: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1102 | tprint('%10s %-15s:' % ('', result['_target']), |
Simon Glass | 4433aa9 | 2014-09-05 19:00:07 -0600 | [diff] [blame] | 1103 | newline=False) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1104 | printed_target = True |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1105 | tprint(msg, colour=color, newline=False) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1106 | if printed_target: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1107 | tprint() |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1108 | if show_bloat: |
| 1109 | target = result['_target'] |
| 1110 | outcome = result['_outcome'] |
| 1111 | base_outcome = self._base_board_dict[target] |
| 1112 | for fname in outcome.func_sizes: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1113 | self.print_func_size_detail(fname, |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1114 | base_outcome.func_sizes[fname], |
| 1115 | outcome.func_sizes[fname]) |
| 1116 | |
| 1117 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1118 | def print_size_summary(self, board_selected, board_dict, show_detail, |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1119 | show_bloat): |
| 1120 | """Print a summary of image sizes broken down by section. |
| 1121 | |
| 1122 | The summary takes the form of one line per architecture. The |
| 1123 | line contains deltas for each of the sections (+ means the section |
Flavio Suligoi | e5e3c11 | 2020-01-29 09:56:05 +0100 | [diff] [blame] | 1124 | got bigger, - means smaller). The numbers are the average number |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1125 | of bytes that a board in this section increased by. |
| 1126 | |
| 1127 | For example: |
| 1128 | powerpc: (622 boards) text -0.0 |
| 1129 | arm: (285 boards) text -0.0 |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1130 | |
| 1131 | Args: |
| 1132 | board_selected: Dict containing boards to summarise, keyed by |
| 1133 | board.target |
| 1134 | board_dict: Dict containing boards for which we built this |
| 1135 | commit, keyed by board.target. The value is an Outcome object. |
Simon Glass | b400246 | 2020-03-18 09:42:43 -0600 | [diff] [blame] | 1136 | show_detail: Show size delta detail for each board |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1137 | show_bloat: Show detail for each function |
| 1138 | """ |
| 1139 | arch_list = {} |
| 1140 | arch_count = {} |
| 1141 | |
| 1142 | # Calculate changes in size for different image parts |
| 1143 | # The previous sizes are in Board.sizes, for each board |
| 1144 | for target in board_dict: |
| 1145 | if target not in board_selected: |
| 1146 | continue |
| 1147 | base_sizes = self._base_board_dict[target].sizes |
| 1148 | outcome = board_dict[target] |
| 1149 | sizes = outcome.sizes |
| 1150 | |
| 1151 | # Loop through the list of images, creating a dict of size |
| 1152 | # changes for each image/part. We end up with something like |
| 1153 | # {'target' : 'snapper9g45, 'data' : 5, 'u-boot-spl:text' : -4} |
| 1154 | # which means that U-Boot data increased by 5 bytes and SPL |
| 1155 | # text decreased by 4. |
| 1156 | err = {'_target' : target} |
| 1157 | for image in sizes: |
| 1158 | if image in base_sizes: |
| 1159 | base_image = base_sizes[image] |
| 1160 | # Loop through the text, data, bss parts |
| 1161 | for part in sorted(sizes[image]): |
| 1162 | diff = sizes[image][part] - base_image[part] |
| 1163 | col = None |
| 1164 | if diff: |
| 1165 | if image == 'u-boot': |
| 1166 | name = part |
| 1167 | else: |
| 1168 | name = image + ':' + part |
| 1169 | err[name] = diff |
| 1170 | arch = board_selected[target].arch |
| 1171 | if not arch in arch_count: |
| 1172 | arch_count[arch] = 1 |
| 1173 | else: |
| 1174 | arch_count[arch] += 1 |
| 1175 | if not sizes: |
| 1176 | pass # Only add to our list when we have some stats |
| 1177 | elif not arch in arch_list: |
| 1178 | arch_list[arch] = [err] |
| 1179 | else: |
| 1180 | arch_list[arch].append(err) |
| 1181 | |
| 1182 | # We now have a list of image size changes sorted by arch |
| 1183 | # Print out a summary of these |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1184 | for arch, target_list in arch_list.items(): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1185 | # Get total difference for each type |
| 1186 | totals = {} |
| 1187 | for result in target_list: |
| 1188 | total = 0 |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1189 | for name, diff in result.items(): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1190 | if name.startswith('_'): |
| 1191 | continue |
| 1192 | total += diff |
| 1193 | if name in totals: |
| 1194 | totals[name] += diff |
| 1195 | else: |
| 1196 | totals[name] = diff |
| 1197 | result['_total_diff'] = total |
| 1198 | result['_outcome'] = board_dict[result['_target']] |
| 1199 | |
| 1200 | count = len(target_list) |
| 1201 | printed_arch = False |
| 1202 | for name in sorted(totals): |
| 1203 | diff = totals[name] |
| 1204 | if diff: |
| 1205 | # Display the average difference in this name for this |
| 1206 | # architecture |
| 1207 | avg_diff = float(diff) / count |
| 1208 | color = self.col.RED if avg_diff > 0 else self.col.GREEN |
| 1209 | msg = ' %s %+1.1f' % (name, avg_diff) |
| 1210 | if not printed_arch: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1211 | tprint('%10s: (for %d/%d boards)' % (arch, count, |
Simon Glass | 4433aa9 | 2014-09-05 19:00:07 -0600 | [diff] [blame] | 1212 | arch_count[arch]), newline=False) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1213 | printed_arch = True |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1214 | tprint(msg, colour=color, newline=False) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1215 | |
| 1216 | if printed_arch: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1217 | tprint() |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1218 | if show_detail: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1219 | self.print_size_detail(target_list, show_bloat) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1220 | |
| 1221 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1222 | def print_result_summary(self, board_selected, board_dict, err_lines, |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1223 | err_line_boards, warn_lines, warn_line_boards, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1224 | config, environment, show_sizes, show_detail, |
| 1225 | show_bloat, show_config, show_environment): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1226 | """Compare results with the base results and display delta. |
| 1227 | |
| 1228 | Only boards mentioned in board_selected will be considered. This |
| 1229 | function is intended to be called repeatedly with the results of |
| 1230 | each commit. It therefore shows a 'diff' between what it saw in |
| 1231 | the last call and what it sees now. |
| 1232 | |
| 1233 | Args: |
| 1234 | board_selected: Dict containing boards to summarise, keyed by |
| 1235 | board.target |
| 1236 | board_dict: Dict containing boards for which we built this |
| 1237 | commit, keyed by board.target. The value is an Outcome object. |
| 1238 | err_lines: A list of errors for this commit, or [] if there is |
| 1239 | none, or we don't want to print errors |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1240 | err_line_boards: Dict keyed by error line, containing a list of |
| 1241 | the Board objects with that error |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1242 | warn_lines: A list of warnings for this commit, or [] if there is |
| 1243 | none, or we don't want to print errors |
| 1244 | warn_line_boards: Dict keyed by warning line, containing a list of |
| 1245 | the Board objects with that warning |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1246 | config: Dictionary keyed by filename - e.g. '.config'. Each |
| 1247 | value is itself a dictionary: |
| 1248 | key: config name |
| 1249 | value: config value |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1250 | environment: Dictionary keyed by environment variable, Each |
| 1251 | value is the value of environment variable. |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1252 | show_sizes: Show image size deltas |
Simon Glass | b400246 | 2020-03-18 09:42:43 -0600 | [diff] [blame] | 1253 | show_detail: Show size delta detail for each board if show_sizes |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1254 | show_bloat: Show detail for each function |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1255 | show_config: Show config changes |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1256 | show_environment: Show environment changes |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1257 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1258 | def _board_list(line, line_boards): |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1259 | """Helper function to get a line of boards containing a line |
| 1260 | |
| 1261 | Args: |
| 1262 | line: Error line to search for |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1263 | line_boards: boards to search, each a Board |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1264 | Return: |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1265 | List of boards with that error line, or [] if the user has not |
| 1266 | requested such a list |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1267 | """ |
Simon Glass | 5df4522 | 2022-07-11 19:04:00 -0600 | [diff] [blame] | 1268 | brds = [] |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1269 | board_set = set() |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1270 | if self._list_error_boards: |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 1271 | for brd in line_boards[line]: |
| 1272 | if not brd in board_set: |
Simon Glass | 5df4522 | 2022-07-11 19:04:00 -0600 | [diff] [blame] | 1273 | brds.append(brd) |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 1274 | board_set.add(brd) |
Simon Glass | 5df4522 | 2022-07-11 19:04:00 -0600 | [diff] [blame] | 1275 | return brds |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1276 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1277 | def _calc_error_delta(base_lines, base_line_boards, lines, line_boards, |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1278 | char): |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1279 | """Calculate the required output based on changes in errors |
| 1280 | |
| 1281 | Args: |
| 1282 | base_lines: List of errors/warnings for previous commit |
| 1283 | base_line_boards: Dict keyed by error line, containing a list |
| 1284 | of the Board objects with that error in the previous commit |
| 1285 | lines: List of errors/warning for this commit, each a str |
| 1286 | line_boards: Dict keyed by error line, containing a list |
| 1287 | of the Board objects with that error in this commit |
| 1288 | char: Character representing error ('') or warning ('w'). The |
| 1289 | broken ('+') or fixed ('-') characters are added in this |
| 1290 | function |
| 1291 | |
| 1292 | Returns: |
| 1293 | Tuple |
| 1294 | List of ErrLine objects for 'better' lines |
| 1295 | List of ErrLine objects for 'worse' lines |
| 1296 | """ |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1297 | better_lines = [] |
| 1298 | worse_lines = [] |
| 1299 | for line in lines: |
| 1300 | if line not in base_lines: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1301 | errline = ErrLine(char + '+', _board_list(line, line_boards), |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1302 | line) |
| 1303 | worse_lines.append(errline) |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1304 | for line in base_lines: |
| 1305 | if line not in lines: |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1306 | errline = ErrLine(char + '-', |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1307 | _board_list(line, base_line_boards), line) |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1308 | better_lines.append(errline) |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1309 | return better_lines, worse_lines |
| 1310 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1311 | def _calc_config(delta, name, config): |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1312 | """Calculate configuration changes |
| 1313 | |
| 1314 | Args: |
| 1315 | delta: Type of the delta, e.g. '+' |
| 1316 | name: name of the file which changed (e.g. .config) |
| 1317 | config: configuration change dictionary |
| 1318 | key: config name |
| 1319 | value: config value |
| 1320 | Returns: |
| 1321 | String containing the configuration changes which can be |
| 1322 | printed |
| 1323 | """ |
| 1324 | out = '' |
| 1325 | for key in sorted(config.keys()): |
| 1326 | out += '%s=%s ' % (key, config[key]) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1327 | return '%s %s: %s' % (delta, name, out) |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1328 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1329 | def _add_config(lines, name, config_plus, config_minus, config_change): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1330 | """Add changes in configuration to a list |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1331 | |
| 1332 | Args: |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1333 | lines: list to add to |
| 1334 | name: config file name |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1335 | config_plus: configurations added, dictionary |
| 1336 | key: config name |
| 1337 | value: config value |
| 1338 | config_minus: configurations removed, dictionary |
| 1339 | key: config name |
| 1340 | value: config value |
| 1341 | config_change: configurations changed, dictionary |
| 1342 | key: config name |
| 1343 | value: config value |
| 1344 | """ |
| 1345 | if config_plus: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1346 | lines.append(_calc_config('+', name, config_plus)) |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1347 | if config_minus: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1348 | lines.append(_calc_config('-', name, config_minus)) |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1349 | if config_change: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1350 | lines.append(_calc_config('c', name, config_change)) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1351 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1352 | def _output_config_info(lines): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1353 | for line in lines: |
| 1354 | if not line: |
| 1355 | continue |
| 1356 | if line[0] == '+': |
| 1357 | col = self.col.GREEN |
| 1358 | elif line[0] == '-': |
| 1359 | col = self.col.RED |
| 1360 | elif line[0] == 'c': |
| 1361 | col = self.col.YELLOW |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1362 | tprint(' ' + line, newline=True, colour=col) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1363 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1364 | def _output_err_lines(err_lines, colour): |
Simon Glass | ac50022 | 2020-04-09 15:08:28 -0600 | [diff] [blame] | 1365 | """Output the line of error/warning lines, if not empty |
| 1366 | |
| 1367 | Also increments self._error_lines if err_lines not empty |
| 1368 | |
| 1369 | Args: |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1370 | err_lines: List of ErrLine objects, each an error or warning |
| 1371 | line, possibly including a list of boards with that |
| 1372 | error/warning |
Simon Glass | ac50022 | 2020-04-09 15:08:28 -0600 | [diff] [blame] | 1373 | colour: Colour to use for output |
| 1374 | """ |
| 1375 | if err_lines: |
Simon Glass | ea49f9b | 2020-04-09 15:08:37 -0600 | [diff] [blame] | 1376 | out_list = [] |
Simon Glass | de0fefc | 2020-04-09 15:08:36 -0600 | [diff] [blame] | 1377 | for line in err_lines: |
Simon Glass | 5df4522 | 2022-07-11 19:04:00 -0600 | [diff] [blame] | 1378 | names = [brd.target for brd in line.brds] |
Simon Glass | 070589b | 2020-04-09 15:08:38 -0600 | [diff] [blame] | 1379 | board_str = ' '.join(names) if names else '' |
Simon Glass | ea49f9b | 2020-04-09 15:08:37 -0600 | [diff] [blame] | 1380 | if board_str: |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 1381 | out = self.col.build(colour, line.char + '(') |
| 1382 | out += self.col.build(self.col.MAGENTA, board_str, |
Simon Glass | ea49f9b | 2020-04-09 15:08:37 -0600 | [diff] [blame] | 1383 | bright=False) |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 1384 | out += self.col.build(colour, ') %s' % line.errline) |
Simon Glass | ea49f9b | 2020-04-09 15:08:37 -0600 | [diff] [blame] | 1385 | else: |
Simon Glass | f45d374 | 2022-01-29 14:14:17 -0700 | [diff] [blame] | 1386 | out = self.col.build(colour, line.char + line.errline) |
Simon Glass | ea49f9b | 2020-04-09 15:08:37 -0600 | [diff] [blame] | 1387 | out_list.append(out) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1388 | tprint('\n'.join(out_list)) |
Simon Glass | ac50022 | 2020-04-09 15:08:28 -0600 | [diff] [blame] | 1389 | self._error_lines += 1 |
| 1390 | |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1391 | |
Simon Glass | 454507f | 2018-11-06 16:02:12 -0700 | [diff] [blame] | 1392 | ok_boards = [] # List of boards fixed since last commit |
Simon Glass | 071a178 | 2018-11-06 16:02:13 -0700 | [diff] [blame] | 1393 | warn_boards = [] # List of boards with warnings since last commit |
Simon Glass | 454507f | 2018-11-06 16:02:12 -0700 | [diff] [blame] | 1394 | err_boards = [] # List of new broken boards since last commit |
| 1395 | new_boards = [] # List of boards that didn't exist last time |
| 1396 | unknown_boards = [] # List of boards that were not built |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1397 | |
| 1398 | for target in board_dict: |
| 1399 | if target not in board_selected: |
| 1400 | continue |
| 1401 | |
| 1402 | # If the board was built last time, add its outcome to a list |
| 1403 | if target in self._base_board_dict: |
| 1404 | base_outcome = self._base_board_dict[target].rc |
| 1405 | outcome = board_dict[target] |
| 1406 | if outcome.rc == OUTCOME_UNKNOWN: |
Simon Glass | 454507f | 2018-11-06 16:02:12 -0700 | [diff] [blame] | 1407 | unknown_boards.append(target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1408 | elif outcome.rc < base_outcome: |
Simon Glass | 071a178 | 2018-11-06 16:02:13 -0700 | [diff] [blame] | 1409 | if outcome.rc == OUTCOME_WARNING: |
| 1410 | warn_boards.append(target) |
| 1411 | else: |
| 1412 | ok_boards.append(target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1413 | elif outcome.rc > base_outcome: |
Simon Glass | 071a178 | 2018-11-06 16:02:13 -0700 | [diff] [blame] | 1414 | if outcome.rc == OUTCOME_WARNING: |
| 1415 | warn_boards.append(target) |
| 1416 | else: |
| 1417 | err_boards.append(target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1418 | else: |
Simon Glass | 454507f | 2018-11-06 16:02:12 -0700 | [diff] [blame] | 1419 | new_boards.append(target) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1420 | |
Simon Glass | ac50022 | 2020-04-09 15:08:28 -0600 | [diff] [blame] | 1421 | # Get a list of errors and warnings that have appeared, and disappeared |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1422 | better_err, worse_err = _calc_error_delta(self._base_err_lines, |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1423 | self._base_err_line_boards, err_lines, err_line_boards, '') |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1424 | better_warn, worse_warn = _calc_error_delta(self._base_warn_lines, |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1425 | self._base_warn_line_boards, warn_lines, warn_line_boards, 'w') |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1426 | |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 1427 | # For the IDE mode, print out all the output |
| 1428 | if self._ide: |
| 1429 | outcome = board_dict[target] |
| 1430 | for line in outcome.err_lines: |
| 1431 | sys.stderr.write(line) |
| 1432 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1433 | # Display results by arch |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 1434 | elif any((ok_boards, warn_boards, err_boards, unknown_boards, new_boards, |
Simon Glass | 071a178 | 2018-11-06 16:02:13 -0700 | [diff] [blame] | 1435 | worse_err, better_err, worse_warn, better_warn)): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1436 | arch_list = {} |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1437 | self.add_outcome(board_selected, arch_list, ok_boards, '', |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1438 | self.col.GREEN) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1439 | self.add_outcome(board_selected, arch_list, warn_boards, 'w+', |
Simon Glass | 071a178 | 2018-11-06 16:02:13 -0700 | [diff] [blame] | 1440 | self.col.YELLOW) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1441 | self.add_outcome(board_selected, arch_list, err_boards, '+', |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1442 | self.col.RED) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1443 | self.add_outcome(board_selected, arch_list, new_boards, '*', self.col.BLUE) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1444 | if self._show_unknown: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1445 | self.add_outcome(board_selected, arch_list, unknown_boards, '?', |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1446 | self.col.MAGENTA) |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1447 | for arch, target_list in arch_list.items(): |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1448 | tprint('%10s: %s' % (arch, target_list)) |
Simon Glass | bb4dffb | 2014-08-09 15:33:06 -0600 | [diff] [blame] | 1449 | self._error_lines += 1 |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1450 | _output_err_lines(better_err, colour=self.col.GREEN) |
| 1451 | _output_err_lines(worse_err, colour=self.col.RED) |
| 1452 | _output_err_lines(better_warn, colour=self.col.CYAN) |
| 1453 | _output_err_lines(worse_warn, colour=self.col.YELLOW) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1454 | |
| 1455 | if show_sizes: |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1456 | self.print_size_summary(board_selected, board_dict, show_detail, |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1457 | show_bloat) |
| 1458 | |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1459 | if show_environment and self._base_environment: |
| 1460 | lines = [] |
| 1461 | |
| 1462 | for target in board_dict: |
| 1463 | if target not in board_selected: |
| 1464 | continue |
| 1465 | |
| 1466 | tbase = self._base_environment[target] |
| 1467 | tenvironment = environment[target] |
| 1468 | environment_plus = {} |
| 1469 | environment_minus = {} |
| 1470 | environment_change = {} |
| 1471 | base = tbase.environment |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1472 | for key, value in tenvironment.environment.items(): |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1473 | if key not in base: |
| 1474 | environment_plus[key] = value |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1475 | for key, value in base.items(): |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1476 | if key not in tenvironment.environment: |
| 1477 | environment_minus[key] = value |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1478 | for key, value in base.items(): |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1479 | new_value = tenvironment.environment.get(key) |
| 1480 | if new_value and value != new_value: |
| 1481 | desc = '%s -> %s' % (value, new_value) |
| 1482 | environment_change[key] = desc |
| 1483 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1484 | _add_config(lines, target, environment_plus, environment_minus, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1485 | environment_change) |
| 1486 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1487 | _output_config_info(lines) |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1488 | |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1489 | if show_config and self._base_config: |
| 1490 | summary = {} |
| 1491 | arch_config_plus = {} |
| 1492 | arch_config_minus = {} |
| 1493 | arch_config_change = {} |
| 1494 | arch_list = [] |
| 1495 | |
| 1496 | for target in board_dict: |
| 1497 | if target not in board_selected: |
| 1498 | continue |
| 1499 | arch = board_selected[target].arch |
| 1500 | if arch not in arch_list: |
| 1501 | arch_list.append(arch) |
| 1502 | |
| 1503 | for arch in arch_list: |
| 1504 | arch_config_plus[arch] = {} |
| 1505 | arch_config_minus[arch] = {} |
| 1506 | arch_config_change[arch] = {} |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 1507 | for name in self.config_filenames: |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1508 | arch_config_plus[arch][name] = {} |
| 1509 | arch_config_minus[arch][name] = {} |
| 1510 | arch_config_change[arch][name] = {} |
| 1511 | |
| 1512 | for target in board_dict: |
| 1513 | if target not in board_selected: |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1514 | continue |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1515 | |
| 1516 | arch = board_selected[target].arch |
| 1517 | |
| 1518 | all_config_plus = {} |
| 1519 | all_config_minus = {} |
| 1520 | all_config_change = {} |
| 1521 | tbase = self._base_config[target] |
| 1522 | tconfig = config[target] |
| 1523 | lines = [] |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 1524 | for name in self.config_filenames: |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1525 | if not tconfig.config[name]: |
| 1526 | continue |
| 1527 | config_plus = {} |
| 1528 | config_minus = {} |
| 1529 | config_change = {} |
| 1530 | base = tbase.config[name] |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1531 | for key, value in tconfig.config[name].items(): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1532 | if key not in base: |
| 1533 | config_plus[key] = value |
| 1534 | all_config_plus[key] = value |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1535 | for key, value in base.items(): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1536 | if key not in tconfig.config[name]: |
| 1537 | config_minus[key] = value |
| 1538 | all_config_minus[key] = value |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1539 | for key, value in base.items(): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1540 | new_value = tconfig.config.get(key) |
| 1541 | if new_value and value != new_value: |
| 1542 | desc = '%s -> %s' % (value, new_value) |
| 1543 | config_change[key] = desc |
| 1544 | all_config_change[key] = desc |
| 1545 | |
| 1546 | arch_config_plus[arch][name].update(config_plus) |
| 1547 | arch_config_minus[arch][name].update(config_minus) |
| 1548 | arch_config_change[arch][name].update(config_change) |
| 1549 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1550 | _add_config(lines, name, config_plus, config_minus, |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1551 | config_change) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1552 | _add_config(lines, 'all', all_config_plus, all_config_minus, |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1553 | all_config_change) |
| 1554 | summary[target] = '\n'.join(lines) |
| 1555 | |
| 1556 | lines_by_target = {} |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1557 | for target, lines in summary.items(): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1558 | if lines in lines_by_target: |
| 1559 | lines_by_target[lines].append(target) |
| 1560 | else: |
| 1561 | lines_by_target[lines] = [target] |
| 1562 | |
| 1563 | for arch in arch_list: |
| 1564 | lines = [] |
| 1565 | all_plus = {} |
| 1566 | all_minus = {} |
| 1567 | all_change = {} |
Simon Glass | cde5c30 | 2016-11-13 14:25:53 -0700 | [diff] [blame] | 1568 | for name in self.config_filenames: |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1569 | all_plus.update(arch_config_plus[arch][name]) |
| 1570 | all_minus.update(arch_config_minus[arch][name]) |
| 1571 | all_change.update(arch_config_change[arch][name]) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1572 | _add_config(lines, name, arch_config_plus[arch][name], |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1573 | arch_config_minus[arch][name], |
| 1574 | arch_config_change[arch][name]) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1575 | _add_config(lines, 'all', all_plus, all_minus, all_change) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1576 | #arch_summary[target] = '\n'.join(lines) |
| 1577 | if lines: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1578 | tprint('%s:' % arch) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1579 | _output_config_info(lines) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1580 | |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1581 | for lines, targets in lines_by_target.items(): |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1582 | if not lines: |
| 1583 | continue |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1584 | tprint('%s :' % ' '.join(sorted(targets))) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1585 | _output_config_info(lines.split('\n')) |
Simon Glass | cad8abf | 2015-08-25 21:52:14 -0600 | [diff] [blame] | 1586 | |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1587 | |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1588 | # Save our updated information for the next call to this function |
| 1589 | self._base_board_dict = board_dict |
| 1590 | self._base_err_lines = err_lines |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1591 | self._base_warn_lines = warn_lines |
| 1592 | self._base_err_line_boards = err_line_boards |
| 1593 | self._base_warn_line_boards = warn_line_boards |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1594 | self._base_config = config |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1595 | self._base_environment = environment |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1596 | |
| 1597 | # Get a list of boards that did not get built, if needed |
| 1598 | not_built = [] |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 1599 | for brd in board_selected: |
| 1600 | if not brd in board_dict: |
| 1601 | not_built.append(brd) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1602 | if not_built: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1603 | tprint("Boards not built (%d): %s" % (len(not_built), |
Simon Glass | 4433aa9 | 2014-09-05 19:00:07 -0600 | [diff] [blame] | 1604 | ', '.join(not_built))) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1605 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1606 | def produce_result_summary(self, commit_upto, commits, board_selected): |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1607 | (board_dict, err_lines, err_line_boards, warn_lines, |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1608 | warn_line_boards, config, environment) = self.get_result_summary( |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1609 | board_selected, commit_upto, |
Simon Glass | db17fb8 | 2015-02-05 22:06:15 -0700 | [diff] [blame] | 1610 | read_func_sizes=self._show_bloat, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1611 | read_config=self._show_config, |
| 1612 | read_environment=self._show_environment) |
Simon Glass | eb48bbc | 2014-08-09 15:33:02 -0600 | [diff] [blame] | 1613 | if commits: |
| 1614 | msg = '%02d: %s' % (commit_upto + 1, |
| 1615 | commits[commit_upto].subject) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1616 | tprint(msg, colour=self.col.BLUE) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1617 | self.print_result_summary(board_selected, board_dict, |
Simon Glass | 3394c9f | 2014-08-28 09:43:43 -0600 | [diff] [blame] | 1618 | err_lines if self._show_errors else [], err_line_boards, |
Simon Glass | 03749d4 | 2014-08-28 09:43:44 -0600 | [diff] [blame] | 1619 | warn_lines if self._show_errors else [], warn_line_boards, |
Alex Kiernan | 4059e30 | 2018-05-31 04:48:34 +0000 | [diff] [blame] | 1620 | config, environment, self._show_sizes, self._show_detail, |
| 1621 | self._show_bloat, self._show_config, self._show_environment) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1622 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1623 | def show_summary(self, commits, board_selected): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1624 | """Show a build summary for U-Boot for a given board list. |
| 1625 | |
| 1626 | Reset the result summary, then repeatedly call GetResultSummary on |
| 1627 | each commit's results, then display the differences we see. |
| 1628 | |
| 1629 | Args: |
| 1630 | commit: Commit objects to summarise |
| 1631 | board_selected: Dict containing boards to summarise |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1632 | """ |
Simon Glass | d326ad7 | 2014-08-09 15:32:59 -0600 | [diff] [blame] | 1633 | self.commit_count = len(commits) if commits else 1 |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1634 | self.commits = commits |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1635 | self.reset_result_summary(board_selected) |
Simon Glass | bb4dffb | 2014-08-09 15:33:06 -0600 | [diff] [blame] | 1636 | self._error_lines = 0 |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1637 | |
| 1638 | for commit_upto in range(0, self.commit_count, self._step): |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1639 | self.produce_result_summary(commit_upto, commits, board_selected) |
Simon Glass | bb4dffb | 2014-08-09 15:33:06 -0600 | [diff] [blame] | 1640 | if not self._error_lines: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1641 | tprint('(no errors to report)', colour=self.col.GREEN) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1642 | |
| 1643 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1644 | def setup_build(self, board_selected, commits): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1645 | """Set up ready to start a build. |
| 1646 | |
| 1647 | Args: |
| 1648 | board_selected: Selected boards to build |
| 1649 | commits: Selected commits to build |
| 1650 | """ |
| 1651 | # First work out how many commits we will build |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1652 | count = (self.commit_count + self._step - 1) // self._step |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1653 | self.count = len(board_selected) * count |
| 1654 | self.upto = self.warned = self.fail = 0 |
| 1655 | self._timestamps = collections.deque() |
| 1656 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1657 | def get_thread_dir(self, thread_num): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1658 | """Get the directory path to the working dir for a thread. |
| 1659 | |
| 1660 | Args: |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1661 | thread_num: Number of thread to check (-1 for main process, which |
| 1662 | is treated as 0) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1663 | """ |
Simon Glass | b6eb8cf | 2020-03-18 09:42:42 -0600 | [diff] [blame] | 1664 | if self.work_in_output: |
| 1665 | return self._working_dir |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1666 | return os.path.join(self._working_dir, '%02d' % max(thread_num, 0)) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1667 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1668 | def _prepare_thread(self, thread_num, setup_git): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1669 | """Prepare the working directory for a thread. |
| 1670 | |
| 1671 | This clones or fetches the repo into the thread's work directory. |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1672 | Optionally, it can create a linked working tree of the repo in the |
| 1673 | thread's work directory instead. |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1674 | |
| 1675 | Args: |
| 1676 | thread_num: Thread number (0, 1, ...) |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1677 | setup_git: |
| 1678 | 'clone' to set up a git clone |
| 1679 | 'worktree' to set up a git worktree |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1680 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1681 | thread_dir = self.get_thread_dir(thread_num) |
Simon Glass | c5077c3 | 2023-07-19 17:49:08 -0600 | [diff] [blame] | 1682 | builderthread.mkdir(thread_dir) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1683 | git_dir = os.path.join(thread_dir, '.git') |
| 1684 | |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1685 | # Create a worktree or a git repo clone for this thread if it |
| 1686 | # doesn't already exist |
Simon Glass | d326ad7 | 2014-08-09 15:32:59 -0600 | [diff] [blame] | 1687 | if setup_git and self.git_dir: |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1688 | src_dir = os.path.abspath(self.git_dir) |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1689 | if os.path.isdir(git_dir): |
| 1690 | # This is a clone of the src_dir repo, we can keep using |
| 1691 | # it but need to fetch from src_dir. |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1692 | tprint('\rFetching repo for thread %d' % thread_num, |
Simon Glass | 4305493 | 2020-04-09 15:08:43 -0600 | [diff] [blame] | 1693 | newline=False) |
Simon Glass | 761648b | 2022-01-29 14:14:11 -0700 | [diff] [blame] | 1694 | gitutil.fetch(git_dir, thread_dir) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1695 | terminal.print_clear() |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1696 | elif os.path.isfile(git_dir): |
| 1697 | # This is a worktree of the src_dir repo, we don't need to |
| 1698 | # create it again or update it in any way. |
| 1699 | pass |
| 1700 | elif os.path.exists(git_dir): |
| 1701 | # Don't know what could trigger this, but we probably |
| 1702 | # can't create a git worktree/clone here. |
| 1703 | raise ValueError('Git dir %s exists, but is not a file ' |
| 1704 | 'or a directory.' % git_dir) |
| 1705 | elif setup_git == 'worktree': |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1706 | tprint('\rChecking out worktree for thread %d' % thread_num, |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1707 | newline=False) |
Simon Glass | 761648b | 2022-01-29 14:14:11 -0700 | [diff] [blame] | 1708 | gitutil.add_worktree(src_dir, thread_dir) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1709 | terminal.print_clear() |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1710 | elif setup_git == 'clone' or setup_git == True: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1711 | tprint('\rCloning repo for thread %d' % thread_num, |
Simon Glass | 2e2a6e6 | 2016-09-18 16:48:31 -0600 | [diff] [blame] | 1712 | newline=False) |
Simon Glass | 761648b | 2022-01-29 14:14:11 -0700 | [diff] [blame] | 1713 | gitutil.clone(src_dir, thread_dir) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1714 | terminal.print_clear() |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1715 | else: |
| 1716 | raise ValueError("Can't setup git repo with %s." % setup_git) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1717 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1718 | def _prepare_working_space(self, max_threads, setup_git): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1719 | """Prepare the working directory for use. |
| 1720 | |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1721 | Set up the git repo for each thread. Creates a linked working tree |
| 1722 | if git-worktree is available, or clones the repo if it isn't. |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1723 | |
| 1724 | Args: |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1725 | max_threads: Maximum number of threads we expect to need. If 0 then |
| 1726 | 1 is set up, since the main process still needs somewhere to |
| 1727 | work |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1728 | setup_git: True to set up a git worktree or a git clone |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1729 | """ |
Simon Glass | c5077c3 | 2023-07-19 17:49:08 -0600 | [diff] [blame] | 1730 | builderthread.mkdir(self._working_dir) |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1731 | if setup_git and self.git_dir: |
| 1732 | src_dir = os.path.abspath(self.git_dir) |
Simon Glass | 761648b | 2022-01-29 14:14:11 -0700 | [diff] [blame] | 1733 | if gitutil.check_worktree_is_available(src_dir): |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1734 | setup_git = 'worktree' |
| 1735 | # If we previously added a worktree but the directory for it |
| 1736 | # got deleted, we need to prune its files from the repo so |
| 1737 | # that we can check out another in its place. |
Simon Glass | 761648b | 2022-01-29 14:14:11 -0700 | [diff] [blame] | 1738 | gitutil.prune_worktrees(src_dir) |
Alper Nebi Yasak | fede44a | 2020-09-03 15:51:03 +0300 | [diff] [blame] | 1739 | else: |
| 1740 | setup_git = 'clone' |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1741 | |
| 1742 | # Always do at least one thread |
| 1743 | for thread in range(max(max_threads, 1)): |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1744 | self._prepare_thread(thread, setup_git) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1745 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1746 | def _get_output_space_removals(self): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1747 | """Get the output directories ready to receive files. |
| 1748 | |
Simon Glass | 5dc1ca7 | 2020-03-18 09:42:45 -0600 | [diff] [blame] | 1749 | Figure out what needs to be deleted in the output directory before it |
| 1750 | can be used. We only delete old buildman directories which have the |
Simon Glass | 4cb5468 | 2023-07-19 17:49:10 -0600 | [diff] [blame] | 1751 | expected name pattern. See get_output_dir(). |
Simon Glass | 5dc1ca7 | 2020-03-18 09:42:45 -0600 | [diff] [blame] | 1752 | |
| 1753 | Returns: |
| 1754 | List of full paths of directories to remove |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1755 | """ |
Simon Glass | b9a9b7c | 2014-12-01 17:33:53 -0700 | [diff] [blame] | 1756 | if not self.commits: |
| 1757 | return |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1758 | dir_list = [] |
| 1759 | for commit_upto in range(self.commit_count): |
Simon Glass | 4cb5468 | 2023-07-19 17:49:10 -0600 | [diff] [blame] | 1760 | dir_list.append(self.get_output_dir(commit_upto)) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1761 | |
Simon Glass | 83cb6cc | 2016-09-18 16:48:32 -0600 | [diff] [blame] | 1762 | to_remove = [] |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1763 | for dirname in glob.glob(os.path.join(self.base_dir, '*')): |
| 1764 | if dirname not in dir_list: |
Simon Glass | 5dc1ca7 | 2020-03-18 09:42:45 -0600 | [diff] [blame] | 1765 | leaf = dirname[len(self.base_dir) + 1:] |
Ovidiu Panait | ee8e9cb | 2020-05-15 09:30:12 +0300 | [diff] [blame] | 1766 | m = re.match('[0-9]+_g[0-9a-f]+_.*', leaf) |
Simon Glass | 5dc1ca7 | 2020-03-18 09:42:45 -0600 | [diff] [blame] | 1767 | if m: |
| 1768 | to_remove.append(dirname) |
| 1769 | return to_remove |
| 1770 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1771 | def _prepare_output_space(self): |
Simon Glass | 5dc1ca7 | 2020-03-18 09:42:45 -0600 | [diff] [blame] | 1772 | """Get the output directories ready to receive files. |
| 1773 | |
| 1774 | We delete any output directories which look like ones we need to |
| 1775 | create. Having left over directories is confusing when the user wants |
| 1776 | to check the output manually. |
| 1777 | """ |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1778 | to_remove = self._get_output_space_removals() |
Simon Glass | 83cb6cc | 2016-09-18 16:48:32 -0600 | [diff] [blame] | 1779 | if to_remove: |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1780 | tprint('Removing %d old build directories...' % len(to_remove), |
Simon Glass | 83cb6cc | 2016-09-18 16:48:32 -0600 | [diff] [blame] | 1781 | newline=False) |
| 1782 | for dirname in to_remove: |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1783 | shutil.rmtree(dirname) |
Simon Glass | 0281158 | 2022-01-29 14:14:18 -0700 | [diff] [blame] | 1784 | terminal.print_clear() |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1785 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1786 | def build_boards(self, commits, board_selected, keep_outputs, verbose): |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1787 | """Build all commits for a list of boards |
| 1788 | |
| 1789 | Args: |
| 1790 | commits: List of commits to be build, each a Commit object |
| 1791 | boards_selected: Dict of selected boards, key is target name, |
| 1792 | value is Board object |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1793 | keep_outputs: True to save build output files |
Simon Glass | 78e418e | 2014-08-09 15:33:03 -0600 | [diff] [blame] | 1794 | verbose: Display build results as they are completed |
Simon Glass | c2f9107 | 2014-08-28 09:43:39 -0600 | [diff] [blame] | 1795 | Returns: |
| 1796 | Tuple containing: |
| 1797 | - number of boards that failed to build |
| 1798 | - number of boards that issued warnings |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 1799 | - list of thread exceptions raised |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1800 | """ |
Simon Glass | d326ad7 | 2014-08-09 15:32:59 -0600 | [diff] [blame] | 1801 | self.commit_count = len(commits) if commits else 1 |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1802 | self.commits = commits |
Simon Glass | 78e418e | 2014-08-09 15:33:03 -0600 | [diff] [blame] | 1803 | self._verbose = verbose |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1804 | |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1805 | self.reset_result_summary(board_selected) |
Simon Glass | c5077c3 | 2023-07-19 17:49:08 -0600 | [diff] [blame] | 1806 | builderthread.mkdir(self.base_dir, parents = True) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1807 | self._prepare_working_space(min(self.num_threads, len(board_selected)), |
Simon Glass | d326ad7 | 2014-08-09 15:32:59 -0600 | [diff] [blame] | 1808 | commits is not None) |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1809 | self._prepare_output_space() |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 1810 | if not self._ide: |
| 1811 | tprint('\rStarting build...', newline=False) |
Simon Glass | 7190a17 | 2023-09-07 10:00:19 -0600 | [diff] [blame] | 1812 | self._start_time = datetime.now() |
Simon Glass | bc74d94 | 2023-07-19 17:49:06 -0600 | [diff] [blame] | 1813 | self.setup_build(board_selected, commits) |
| 1814 | self.process_result(None) |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 1815 | self.thread_exceptions = [] |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1816 | # Create jobs to build all commits for each board |
Simon Glass | c78ed66 | 2019-10-31 07:42:53 -0600 | [diff] [blame] | 1817 | for brd in board_selected.values(): |
Simon Glass | 4a1e88b | 2014-08-09 15:33:00 -0600 | [diff] [blame] | 1818 | job = builderthread.BuilderJob() |
Simon Glass | 8132f98 | 2022-07-11 19:03:57 -0600 | [diff] [blame] | 1819 | job.brd = brd |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1820 | job.commits = commits |
| 1821 | job.keep_outputs = keep_outputs |
Simon Glass | b6eb8cf | 2020-03-18 09:42:42 -0600 | [diff] [blame] | 1822 | job.work_in_output = self.work_in_output |
Simon Glass | e5650a8 | 2022-01-22 05:07:33 -0700 | [diff] [blame] | 1823 | job.adjust_cfg = self.adjust_cfg |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1824 | job.step = self._step |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1825 | if self.num_threads: |
| 1826 | self.queue.put(job) |
| 1827 | else: |
Simon Glass | c5077c3 | 2023-07-19 17:49:08 -0600 | [diff] [blame] | 1828 | self._single_builder.run_job(job) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1829 | |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1830 | if self.num_threads: |
| 1831 | term = threading.Thread(target=self.queue.join) |
| 1832 | term.setDaemon(True) |
| 1833 | term.start() |
| 1834 | while term.is_alive(): |
| 1835 | term.join(100) |
Simon Glass | c05694f | 2013-04-03 11:07:16 +0000 | [diff] [blame] | 1836 | |
Simon Glass | c635d89 | 2021-01-30 22:17:46 -0700 | [diff] [blame] | 1837 | # Wait until we have processed all output |
| 1838 | self.out_queue.join() |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 1839 | if not self._ide: |
| 1840 | tprint() |
Simon Glass | 726ae81 | 2020-04-09 15:08:47 -0600 | [diff] [blame] | 1841 | |
Simon Glass | 6c43562 | 2022-07-11 19:03:56 -0600 | [diff] [blame] | 1842 | msg = 'Completed: %d total built' % self.count |
| 1843 | if self.already_done: |
| 1844 | msg += ' (%d previously' % self.already_done |
| 1845 | if self.already_done != self.count: |
| 1846 | msg += ', %d newly' % (self.count - self.already_done) |
| 1847 | msg += ')' |
| 1848 | duration = datetime.now() - self._start_time |
| 1849 | if duration > timedelta(microseconds=1000000): |
| 1850 | if duration.microseconds >= 500000: |
| 1851 | duration = duration + timedelta(seconds=1) |
| 1852 | duration = duration - timedelta(microseconds=duration.microseconds) |
| 1853 | rate = float(self.count) / duration.total_seconds() |
| 1854 | msg += ', duration %s, rate %1.2f' % (duration, rate) |
| 1855 | tprint(msg) |
| 1856 | if self.thread_exceptions: |
| 1857 | tprint('Failed: %d thread exceptions' % len(self.thread_exceptions), |
| 1858 | colour=self.col.RED) |
Simon Glass | 726ae81 | 2020-04-09 15:08:47 -0600 | [diff] [blame] | 1859 | |
Simon Glass | 9bf9a72 | 2021-04-11 16:27:27 +1200 | [diff] [blame] | 1860 | return (self.fail, self.warned, self.thread_exceptions) |