[][kernel][common][hnat][Fix issues detected by Coverity scan]
[Description]
Fix issues detected by Coverity scan
1. mtk_hnat_ipv4_nf_pre_routing:
- dereference before null check(skb null check)
[Release-log]
N/A
Change-Id: Idd2e8596b525eda76e0aa63484e59ca40292ea96
Reviewed-on: https://gerrit.mediatek.inc/c/openwrt/feeds/mtk_openwrt_feeds/+/8857331
diff --git a/21.02/files/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_hnat/hnat_nf_hook.c b/21.02/files/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_hnat/hnat_nf_hook.c
index 9fe85fb..5a428e1 100644
--- a/21.02/files/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_hnat/hnat_nf_hook.c
+++ b/21.02/files/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_hnat/hnat_nf_hook.c
@@ -832,8 +832,7 @@
mtk_hnat_ipv4_nf_pre_routing(void *priv, struct sk_buff *skb,
const struct nf_hook_state *state)
{
- struct flow_offload_hw_path hw_path = { .dev = skb->dev,
- .virt_dev = skb->dev };
+ struct flow_offload_hw_path hw_path;
if (!skb)
goto drop;
@@ -848,6 +847,9 @@
hnat_set_head_frags(state, skb, -1, hnat_set_iif);
+ hw_path.dev = skb->dev;
+ hw_path.virt_dev = skb->dev;
+
/*
* Avoid mistakenly binding of outer IP, ports in SW L2TP decap flow.
* In pre-routing, if dev is virtual iface, TOPS module is not loaded,