blob: dae3d4ab9ff676159041ff3be72ff40597679c99 [file] [log] [blame]
Tom Rini10e47792018-05-06 17:58:06 -04001# SPDX-License-Identifier: GPL-2.0+
Simon Glass4a1e88b2014-08-09 15:33:00 -06002# Copyright (c) 2014 Google, Inc
3#
Simon Glass4a1e88b2014-08-09 15:33:00 -06004
5import errno
6import glob
7import os
8import shutil
Lothar Waßmannce6df922018-04-08 05:14:11 -06009import sys
Simon Glass4a1e88b2014-08-09 15:33:00 -060010import threading
11
Simon Glasse5650a82022-01-22 05:07:33 -070012from buildman import cfgutil
Simon Glassa997ea52020-04-17 18:09:04 -060013from patman import command
14from patman import gitutil
Simon Glass4a1e88b2014-08-09 15:33:00 -060015
Simon Glassfd3eea12015-02-05 22:06:13 -070016RETURN_CODE_RETRY = -1
Simon Glasse0f19712020-12-16 17:24:17 -070017BASE_ELF_FILENAMES = ['u-boot', 'spl/u-boot-spl', 'tpl/u-boot-tpl']
Simon Glassfd3eea12015-02-05 22:06:13 -070018
Thierry Reding336d5bd2014-08-19 10:22:39 +020019def Mkdir(dirname, parents = False):
Simon Glass4a1e88b2014-08-09 15:33:00 -060020 """Make a directory if it doesn't already exist.
21
22 Args:
23 dirname: Directory to create
24 """
25 try:
Thierry Reding336d5bd2014-08-19 10:22:39 +020026 if parents:
27 os.makedirs(dirname)
28 else:
29 os.mkdir(dirname)
Simon Glass4a1e88b2014-08-09 15:33:00 -060030 except OSError as err:
31 if err.errno == errno.EEXIST:
Lothar Waßmannce6df922018-04-08 05:14:11 -060032 if os.path.realpath('.') == os.path.realpath(dirname):
Simon Glassc78ed662019-10-31 07:42:53 -060033 print("Cannot create the current working directory '%s'!" % dirname)
Lothar Waßmannce6df922018-04-08 05:14:11 -060034 sys.exit(1)
Simon Glass4a1e88b2014-08-09 15:33:00 -060035 pass
36 else:
37 raise
38
39class BuilderJob:
40 """Holds information about a job to be performed by a thread
41
42 Members:
Simon Glass8132f982022-07-11 19:03:57 -060043 brd: Board object to build
Simon Glassdf890152020-03-18 09:42:41 -060044 commits: List of Commit objects to build
45 keep_outputs: True to save build output files
46 step: 1 to process every commit, n to process every nth commit
Simon Glassb6eb8cf2020-03-18 09:42:42 -060047 work_in_output: Use the output directory as the work directory and
48 don't write to a separate output directory.
Simon Glass4a1e88b2014-08-09 15:33:00 -060049 """
50 def __init__(self):
Simon Glass8132f982022-07-11 19:03:57 -060051 self.brd = None
Simon Glass4a1e88b2014-08-09 15:33:00 -060052 self.commits = []
Simon Glassdf890152020-03-18 09:42:41 -060053 self.keep_outputs = False
54 self.step = 1
Simon Glassb6eb8cf2020-03-18 09:42:42 -060055 self.work_in_output = False
Simon Glass4a1e88b2014-08-09 15:33:00 -060056
57
58class ResultThread(threading.Thread):
59 """This thread processes results from builder threads.
60
61 It simply passes the results on to the builder. There is only one
62 result thread, and this helps to serialise the build output.
63 """
64 def __init__(self, builder):
65 """Set up a new result thread
66
67 Args:
68 builder: Builder which will be sent each result
69 """
70 threading.Thread.__init__(self)
71 self.builder = builder
72
73 def run(self):
74 """Called to start up the result thread.
75
76 We collect the next result job and pass it on to the build.
77 """
78 while True:
79 result = self.builder.out_queue.get()
80 self.builder.ProcessResult(result)
81 self.builder.out_queue.task_done()
82
83
84class BuilderThread(threading.Thread):
85 """This thread builds U-Boot for a particular board.
86
87 An input queue provides each new job. We run 'make' to build U-Boot
88 and then pass the results on to the output queue.
89
90 Members:
91 builder: The builder which contains information we might need
92 thread_num: Our thread number (0-n-1), used to decide on a
Simon Glassa29b3ea2021-04-11 16:27:25 +120093 temporary directory. If this is -1 then there are no threads
94 and we are the (only) main process
95 mrproper: Use 'make mrproper' before each reconfigure
96 per_board_out_dir: True to build in a separate persistent directory per
97 board rather than a thread-specific directory
98 test_exception: Used for testing; True to raise an exception instead of
99 reporting the build result
Simon Glass4a1e88b2014-08-09 15:33:00 -0600100 """
Simon Glass9bf9a722021-04-11 16:27:27 +1200101 def __init__(self, builder, thread_num, mrproper, per_board_out_dir,
102 test_exception=False):
Simon Glass4a1e88b2014-08-09 15:33:00 -0600103 """Set up a new builder thread"""
104 threading.Thread.__init__(self)
105 self.builder = builder
106 self.thread_num = thread_num
Simon Glass6029af12020-04-09 15:08:51 -0600107 self.mrproper = mrproper
Stephen Warren97c96902016-04-11 10:48:44 -0600108 self.per_board_out_dir = per_board_out_dir
Simon Glass9bf9a722021-04-11 16:27:27 +1200109 self.test_exception = test_exception
Simon Glass4a1e88b2014-08-09 15:33:00 -0600110
111 def Make(self, commit, brd, stage, cwd, *args, **kwargs):
112 """Run 'make' on a particular commit and board.
113
114 The source code will already be checked out, so the 'commit'
115 argument is only for information.
116
117 Args:
118 commit: Commit object that is being built
119 brd: Board object that is being built
120 stage: Stage of the build. Valid stages are:
Roger Meiere0a0e552014-08-20 22:10:29 +0200121 mrproper - can be called to clean source
Simon Glass4a1e88b2014-08-09 15:33:00 -0600122 config - called to configure for a board
123 build - the main make invocation - it does the build
124 args: A list of arguments to pass to 'make'
Simon Glass840be732022-01-29 14:14:05 -0700125 kwargs: A list of keyword arguments to pass to command.run_pipe()
Simon Glass4a1e88b2014-08-09 15:33:00 -0600126
127 Returns:
128 CommandResult object
129 """
130 return self.builder.do_make(commit, brd, stage, cwd, *args,
131 **kwargs)
132
Simon Glassb55b57d2016-11-16 14:09:25 -0700133 def RunCommit(self, commit_upto, brd, work_dir, do_config, config_only,
Simon Glasse5650a82022-01-22 05:07:33 -0700134 force_build, force_build_failures, work_in_output,
135 adjust_cfg):
Simon Glass4a1e88b2014-08-09 15:33:00 -0600136 """Build a particular commit.
137
138 If the build is already done, and we are not forcing a build, we skip
139 the build and just return the previously-saved results.
140
141 Args:
142 commit_upto: Commit number to build (0...n-1)
143 brd: Board object to build
144 work_dir: Directory to which the source will be checked out
145 do_config: True to run a make <board>_defconfig on the source
Simon Glassb55b57d2016-11-16 14:09:25 -0700146 config_only: Only configure the source, do not build it
Simon Glass4a1e88b2014-08-09 15:33:00 -0600147 force_build: Force a build even if one was previously done
148 force_build_failures: Force a bulid if the previous result showed
149 failure
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600150 work_in_output: Use the output directory as the work directory and
151 don't write to a separate output directory.
Simon Glasse5650a82022-01-22 05:07:33 -0700152 adjust_cfg (list of str): List of changes to make to .config file
153 before building. Each is one of (where C is either CONFIG_xxx
154 or just xxx):
155 C to enable C
156 ~C to disable C
157 C=val to set the value of C (val must have quotes if C is
158 a string Kconfig
Simon Glass4a1e88b2014-08-09 15:33:00 -0600159
160 Returns:
161 tuple containing:
162 - CommandResult object containing the results of the build
163 - boolean indicating whether 'make config' is still needed
164 """
165 # Create a default result - it will be overwritte by the call to
166 # self.Make() below, in the event that we do a build.
167 result = command.CommandResult()
168 result.return_code = 0
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600169 if work_in_output or self.builder.in_tree:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600170 out_dir = work_dir
171 else:
Stephen Warren97c96902016-04-11 10:48:44 -0600172 if self.per_board_out_dir:
173 out_rel_dir = os.path.join('..', brd.target)
174 else:
175 out_rel_dir = 'build'
176 out_dir = os.path.join(work_dir, out_rel_dir)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600177
178 # Check if the job was already completed last time
179 done_file = self.builder.GetDoneFile(commit_upto, brd.target)
180 result.already_done = os.path.exists(done_file)
181 will_build = (force_build or force_build_failures or
182 not result.already_done)
Simon Glass09f1fe52014-09-05 19:00:17 -0600183 if result.already_done:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600184 # Get the return code from that build and use it
185 with open(done_file, 'r') as fd:
Simon Glass4345a6d2018-12-10 09:05:23 -0700186 try:
187 result.return_code = int(fd.readline())
188 except ValueError:
189 # The file may be empty due to running out of disk space.
190 # Try a rebuild
191 result.return_code = RETURN_CODE_RETRY
Simon Glassfd3eea12015-02-05 22:06:13 -0700192
193 # Check the signal that the build needs to be retried
194 if result.return_code == RETURN_CODE_RETRY:
195 will_build = True
196 elif will_build:
Simon Glass09f1fe52014-09-05 19:00:17 -0600197 err_file = self.builder.GetErrFile(commit_upto, brd.target)
198 if os.path.exists(err_file) and os.stat(err_file).st_size:
199 result.stderr = 'bad'
200 elif not force_build:
201 # The build passed, so no need to build it again
202 will_build = False
Simon Glass4a1e88b2014-08-09 15:33:00 -0600203
204 if will_build:
205 # We are going to have to build it. First, get a toolchain
206 if not self.toolchain:
207 try:
208 self.toolchain = self.builder.toolchains.Select(brd.arch)
209 except ValueError as err:
210 result.return_code = 10
211 result.stdout = ''
212 result.stderr = str(err)
213 # TODO(sjg@chromium.org): This gets swallowed, but needs
214 # to be reported.
215
216 if self.toolchain:
217 # Checkout the right commit
218 if self.builder.commits:
219 commit = self.builder.commits[commit_upto]
220 if self.builder.checkout:
221 git_dir = os.path.join(work_dir, '.git')
Simon Glass761648b2022-01-29 14:14:11 -0700222 gitutil.checkout(commit.hash, git_dir, work_dir,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600223 force=True)
224 else:
225 commit = 'current'
226
227 # Set up the environment and command line
Simon Glassd48a46c2014-12-01 17:34:00 -0700228 env = self.toolchain.MakeEnvironment(self.builder.full_path)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600229 Mkdir(out_dir)
230 args = []
231 cwd = work_dir
Simon Glasse3096252014-08-28 09:43:42 -0600232 src_dir = os.path.realpath(work_dir)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600233 if not self.builder.in_tree:
234 if commit_upto is None:
235 # In this case we are building in the original source
236 # directory (i.e. the current directory where buildman
237 # is invoked. The output directory is set to this
238 # thread's selected work directory.
239 #
240 # Symlinks can confuse U-Boot's Makefile since
241 # we may use '..' in our path, so remove them.
Stephen Warren97c96902016-04-11 10:48:44 -0600242 out_dir = os.path.realpath(out_dir)
243 args.append('O=%s' % out_dir)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600244 cwd = None
Simon Glasse3096252014-08-28 09:43:42 -0600245 src_dir = os.getcwd()
Simon Glass4a1e88b2014-08-09 15:33:00 -0600246 else:
Stephen Warren97c96902016-04-11 10:48:44 -0600247 args.append('O=%s' % out_rel_dir)
Tom Rinif06dd812015-04-01 07:47:41 -0400248 if self.builder.verbose_build:
249 args.append('V=1')
250 else:
Simon Glass655b6102014-12-01 17:34:07 -0700251 args.append('-s')
Simon Glass4a1e88b2014-08-09 15:33:00 -0600252 if self.builder.num_jobs is not None:
253 args.extend(['-j', str(self.builder.num_jobs)])
Daniel Schwierzeck20e2ea92018-01-26 16:31:05 +0100254 if self.builder.warnings_as_errors:
255 args.append('KCFLAGS=-Werror')
Tom Rini93ebd462022-11-09 19:14:53 -0700256 if self.builder.allow_missing:
257 args.append('BINMAN_ALLOW_MISSING=1')
Simon Glassf6bfcca2023-02-21 12:40:28 -0700258 if self.builder.no_lto:
259 args.append('NO_LTO=1')
Simon Glass4a1e88b2014-08-09 15:33:00 -0600260 config_args = ['%s_defconfig' % brd.target]
261 config_out = ''
262 args.extend(self.builder.toolchains.GetMakeArguments(brd))
Simon Glassf77ca5b2019-01-07 16:44:20 -0700263 args.extend(self.toolchain.MakeArgs())
Simon Glass4a1e88b2014-08-09 15:33:00 -0600264
Simon Glasse0f19712020-12-16 17:24:17 -0700265 # Remove any output targets. Since we use a build directory that
266 # was previously used by another board, it may have produced an
267 # SPL image. If we don't remove it (i.e. see do_config and
268 # self.mrproper below) then it will appear to be the output of
269 # this build, even if it does not produce SPL images.
270 build_dir = self.builder.GetBuildDir(commit_upto, brd.target)
271 for elf in BASE_ELF_FILENAMES:
272 fname = os.path.join(out_dir, elf)
273 if os.path.exists(fname):
274 os.remove(fname)
275
Simon Glass4a1e88b2014-08-09 15:33:00 -0600276 # If we need to reconfigure, do that now
Simon Glasse5650a82022-01-22 05:07:33 -0700277 cfg_file = os.path.join(out_dir, '.config')
Simon Glass1382b1d2023-02-21 12:40:27 -0700278 cmd_list = []
Simon Glasse5650a82022-01-22 05:07:33 -0700279 if do_config or adjust_cfg:
Stephen Warren97c96902016-04-11 10:48:44 -0600280 config_out = ''
Simon Glass6029af12020-04-09 15:08:51 -0600281 if self.mrproper:
Stephen Warren97c96902016-04-11 10:48:44 -0600282 result = self.Make(commit, brd, 'mrproper', cwd,
283 'mrproper', *args, env=env)
284 config_out += result.combined
Simon Glass1382b1d2023-02-21 12:40:27 -0700285 cmd_list.append([self.builder.gnu_make, 'mrproper',
286 *args])
Simon Glass4a1e88b2014-08-09 15:33:00 -0600287 result = self.Make(commit, brd, 'config', cwd,
288 *(args + config_args), env=env)
Simon Glass1382b1d2023-02-21 12:40:27 -0700289 cmd_list.append([self.builder.gnu_make] + args +
290 config_args)
Simon Glass413f91a2015-02-05 22:06:12 -0700291 config_out += result.combined
Simon Glass4a1e88b2014-08-09 15:33:00 -0600292 do_config = False # No need to configure next time
Simon Glasse5650a82022-01-22 05:07:33 -0700293 if adjust_cfg:
294 cfgutil.adjust_cfg_file(cfg_file, adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600295 if result.return_code == 0:
Simon Glassb55b57d2016-11-16 14:09:25 -0700296 if config_only:
Simon Glass739e8512016-11-13 14:25:51 -0700297 args.append('cfg')
Simon Glass4a1e88b2014-08-09 15:33:00 -0600298 result = self.Make(commit, brd, 'build', cwd, *args,
299 env=env)
Simon Glass1382b1d2023-02-21 12:40:27 -0700300 cmd_list.append([self.builder.gnu_make] + args)
Simon Glass199da412022-11-09 19:14:48 -0700301 if (result.return_code == 2 and
302 ('Some images are invalid' in result.stderr)):
303 # This is handled later by the check for output in
304 # stderr
305 result.return_code = 0
Simon Glasse5650a82022-01-22 05:07:33 -0700306 if adjust_cfg:
307 errs = cfgutil.check_cfg_file(cfg_file, adjust_cfg)
308 if errs:
Simon Glasse5650a82022-01-22 05:07:33 -0700309 result.stderr += errs
310 result.return_code = 1
Simon Glasse3096252014-08-28 09:43:42 -0600311 result.stderr = result.stderr.replace(src_dir + '/', '')
Simon Glass413f91a2015-02-05 22:06:12 -0700312 if self.builder.verbose_build:
313 result.stdout = config_out + result.stdout
Simon Glass1382b1d2023-02-21 12:40:27 -0700314 result.cmd_list = cmd_list
Simon Glass4a1e88b2014-08-09 15:33:00 -0600315 else:
316 result.return_code = 1
317 result.stderr = 'No tool chain for %s\n' % brd.arch
318 result.already_done = False
319
320 result.toolchain = self.toolchain
321 result.brd = brd
322 result.commit_upto = commit_upto
323 result.out_dir = out_dir
324 return result, do_config
325
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600326 def _WriteResult(self, result, keep_outputs, work_in_output):
Simon Glass4a1e88b2014-08-09 15:33:00 -0600327 """Write a built result to the output directory.
328
329 Args:
330 result: CommandResult object containing result to write
331 keep_outputs: True to store the output binaries, False
332 to delete them
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600333 work_in_output: Use the output directory as the work directory and
334 don't write to a separate output directory.
Simon Glass4a1e88b2014-08-09 15:33:00 -0600335 """
Simon Glassfd3eea12015-02-05 22:06:13 -0700336 # If we think this might have been aborted with Ctrl-C, record the
337 # failure but not that we are 'done' with this board. A retry may fix
338 # it.
Simon Glass2e737452021-10-19 21:43:23 -0600339 maybe_aborted = result.stderr and 'No child processes' in result.stderr
Simon Glass4a1e88b2014-08-09 15:33:00 -0600340
Simon Glass2e737452021-10-19 21:43:23 -0600341 if result.return_code >= 0 and result.already_done:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600342 return
343
344 # Write the output and stderr
345 output_dir = self.builder._GetOutputDir(result.commit_upto)
346 Mkdir(output_dir)
347 build_dir = self.builder.GetBuildDir(result.commit_upto,
348 result.brd.target)
349 Mkdir(build_dir)
350
351 outfile = os.path.join(build_dir, 'log')
352 with open(outfile, 'w') as fd:
353 if result.stdout:
Simon Glassc78ed662019-10-31 07:42:53 -0600354 fd.write(result.stdout)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600355
356 errfile = self.builder.GetErrFile(result.commit_upto,
357 result.brd.target)
358 if result.stderr:
359 with open(errfile, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600360 fd.write(result.stderr)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600361 elif os.path.exists(errfile):
362 os.remove(errfile)
363
Simon Glass2e737452021-10-19 21:43:23 -0600364 # Fatal error
365 if result.return_code < 0:
366 return
367
Simon Glass4a1e88b2014-08-09 15:33:00 -0600368 if result.toolchain:
369 # Write the build result and toolchain information.
370 done_file = self.builder.GetDoneFile(result.commit_upto,
371 result.brd.target)
372 with open(done_file, 'w') as fd:
Simon Glassfd3eea12015-02-05 22:06:13 -0700373 if maybe_aborted:
374 # Special code to indicate we need to retry
375 fd.write('%s' % RETURN_CODE_RETRY)
376 else:
377 fd.write('%s' % result.return_code)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600378 with open(os.path.join(build_dir, 'toolchain'), 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600379 print('gcc', result.toolchain.gcc, file=fd)
380 print('path', result.toolchain.path, file=fd)
381 print('cross', result.toolchain.cross, file=fd)
382 print('arch', result.toolchain.arch, file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600383 fd.write('%s' % result.return_code)
384
Simon Glass4a1e88b2014-08-09 15:33:00 -0600385 # Write out the image and function size information and an objdump
Simon Glassd48a46c2014-12-01 17:34:00 -0700386 env = result.toolchain.MakeEnvironment(self.builder.full_path)
Simon Glass93008e22021-04-11 16:27:28 +1200387 with open(os.path.join(build_dir, 'out-env'), 'wb') as fd:
Simon Glass9e90d312019-01-07 16:44:23 -0700388 for var in sorted(env.keys()):
Simon Glass93008e22021-04-11 16:27:28 +1200389 fd.write(b'%s="%s"' % (var, env[var]))
Simon Glass1382b1d2023-02-21 12:40:27 -0700390
391 with open(os.path.join(build_dir, 'out-cmd'), 'w',
392 encoding='utf-8') as fd:
393 for cmd in result.cmd_list:
394 print(' '.join(cmd), file=fd)
395
Simon Glass4a1e88b2014-08-09 15:33:00 -0600396 lines = []
Simon Glasse0f19712020-12-16 17:24:17 -0700397 for fname in BASE_ELF_FILENAMES:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600398 cmd = ['%snm' % self.toolchain.cross, '--size-sort', fname]
Simon Glass840be732022-01-29 14:14:05 -0700399 nm_result = command.run_pipe([cmd], capture=True,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600400 capture_stderr=True, cwd=result.out_dir,
401 raise_on_error=False, env=env)
402 if nm_result.stdout:
403 nm = self.builder.GetFuncSizesFile(result.commit_upto,
404 result.brd.target, fname)
405 with open(nm, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600406 print(nm_result.stdout, end=' ', file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600407
408 cmd = ['%sobjdump' % self.toolchain.cross, '-h', fname]
Simon Glass840be732022-01-29 14:14:05 -0700409 dump_result = command.run_pipe([cmd], capture=True,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600410 capture_stderr=True, cwd=result.out_dir,
411 raise_on_error=False, env=env)
412 rodata_size = ''
413 if dump_result.stdout:
414 objdump = self.builder.GetObjdumpFile(result.commit_upto,
415 result.brd.target, fname)
416 with open(objdump, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600417 print(dump_result.stdout, end=' ', file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600418 for line in dump_result.stdout.splitlines():
419 fields = line.split()
420 if len(fields) > 5 and fields[1] == '.rodata':
421 rodata_size = fields[2]
422
423 cmd = ['%ssize' % self.toolchain.cross, fname]
Simon Glass840be732022-01-29 14:14:05 -0700424 size_result = command.run_pipe([cmd], capture=True,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600425 capture_stderr=True, cwd=result.out_dir,
426 raise_on_error=False, env=env)
427 if size_result.stdout:
428 lines.append(size_result.stdout.splitlines()[1] + ' ' +
429 rodata_size)
430
Alex Kiernanf07ed232018-05-31 04:48:33 +0000431 # Extract the environment from U-Boot and dump it out
432 cmd = ['%sobjcopy' % self.toolchain.cross, '-O', 'binary',
433 '-j', '.rodata.default_environment',
434 'env/built-in.o', 'uboot.env']
Simon Glass840be732022-01-29 14:14:05 -0700435 command.run_pipe([cmd], capture=True,
Alex Kiernanf07ed232018-05-31 04:48:33 +0000436 capture_stderr=True, cwd=result.out_dir,
437 raise_on_error=False, env=env)
438 ubootenv = os.path.join(result.out_dir, 'uboot.env')
Simon Glasse3c85ab2020-04-17 17:51:34 -0600439 if not work_in_output:
440 self.CopyFiles(result.out_dir, build_dir, '', ['uboot.env'])
Alex Kiernanf07ed232018-05-31 04:48:33 +0000441
Simon Glass4a1e88b2014-08-09 15:33:00 -0600442 # Write out the image sizes file. This is similar to the output
443 # of binutil's 'size' utility, but it omits the header line and
444 # adds an additional hex value at the end of each line for the
445 # rodata size
446 if len(lines):
447 sizes = self.builder.GetSizesFile(result.commit_upto,
448 result.brd.target)
449 with open(sizes, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600450 print('\n'.join(lines), file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600451
Simon Glasse3c85ab2020-04-17 17:51:34 -0600452 if not work_in_output:
453 # Write out the configuration files, with a special case for SPL
454 for dirname in ['', 'spl', 'tpl']:
455 self.CopyFiles(
456 result.out_dir, build_dir, dirname,
457 ['u-boot.cfg', 'spl/u-boot-spl.cfg', 'tpl/u-boot-tpl.cfg',
458 '.config', 'include/autoconf.mk',
459 'include/generated/autoconf.h'])
Simon Glass4b14c532015-02-05 22:06:14 -0700460
Simon Glasse3c85ab2020-04-17 17:51:34 -0600461 # Now write the actual build output
462 if keep_outputs:
463 self.CopyFiles(
464 result.out_dir, build_dir, '',
465 ['u-boot*', '*.bin', '*.map', '*.img', 'MLO', 'SPL',
466 'include/autoconf.mk', 'spl/u-boot-spl*'])
Simon Glass4b14c532015-02-05 22:06:14 -0700467
468 def CopyFiles(self, out_dir, build_dir, dirname, patterns):
469 """Copy files from the build directory to the output.
Simon Glass4a1e88b2014-08-09 15:33:00 -0600470
Simon Glass4b14c532015-02-05 22:06:14 -0700471 Args:
472 out_dir: Path to output directory containing the files
473 build_dir: Place to copy the files
474 dirname: Source directory, '' for normal U-Boot, 'spl' for SPL
475 patterns: A list of filenames (strings) to copy, each relative
476 to the build directory
477 """
478 for pattern in patterns:
479 file_list = glob.glob(os.path.join(out_dir, dirname, pattern))
480 for fname in file_list:
481 target = os.path.basename(fname)
482 if dirname:
483 base, ext = os.path.splitext(target)
484 if ext:
485 target = '%s-%s%s' % (base, dirname, ext)
486 shutil.copy(fname, os.path.join(build_dir, target))
Simon Glass4a1e88b2014-08-09 15:33:00 -0600487
Simon Glassa3d01442021-04-11 16:27:26 +1200488 def _SendResult(self, result):
489 """Send a result to the builder for processing
490
491 Args:
492 result: CommandResult object containing the results of the build
Simon Glass9bf9a722021-04-11 16:27:27 +1200493
494 Raises:
495 ValueError if self.test_exception is true (for testing)
Simon Glassa3d01442021-04-11 16:27:26 +1200496 """
Simon Glass9bf9a722021-04-11 16:27:27 +1200497 if self.test_exception:
498 raise ValueError('test exception')
Simon Glassa3d01442021-04-11 16:27:26 +1200499 if self.thread_num != -1:
500 self.builder.out_queue.put(result)
501 else:
502 self.builder.ProcessResult(result)
503
Simon Glass4a1e88b2014-08-09 15:33:00 -0600504 def RunJob(self, job):
505 """Run a single job
506
507 A job consists of a building a list of commits for a particular board.
508
509 Args:
510 job: Job to build
Simon Glassc635d892021-01-30 22:17:46 -0700511
512 Returns:
513 List of Result objects
Simon Glass4a1e88b2014-08-09 15:33:00 -0600514 """
Simon Glass8132f982022-07-11 19:03:57 -0600515 brd = job.brd
Simon Glass4a1e88b2014-08-09 15:33:00 -0600516 work_dir = self.builder.GetThreadDir(self.thread_num)
517 self.toolchain = None
518 if job.commits:
519 # Run 'make board_defconfig' on the first commit
520 do_config = True
521 commit_upto = 0
522 force_build = False
523 for commit_upto in range(0, len(job.commits), job.step):
524 result, request_config = self.RunCommit(commit_upto, brd,
Simon Glassb55b57d2016-11-16 14:09:25 -0700525 work_dir, do_config, self.builder.config_only,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600526 force_build or self.builder.force_build,
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600527 self.builder.force_build_failures,
Simon Glasse5650a82022-01-22 05:07:33 -0700528 job.work_in_output, job.adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600529 failed = result.return_code or result.stderr
530 did_config = do_config
531 if failed and not do_config:
532 # If our incremental build failed, try building again
533 # with a reconfig.
534 if self.builder.force_config_on_failure:
535 result, request_config = self.RunCommit(commit_upto,
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600536 brd, work_dir, True, False, True, False,
Simon Glasse5650a82022-01-22 05:07:33 -0700537 job.work_in_output, job.adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600538 did_config = True
539 if not self.builder.force_reconfig:
540 do_config = request_config
541
542 # If we built that commit, then config is done. But if we got
543 # an warning, reconfig next time to force it to build the same
544 # files that created warnings this time. Otherwise an
545 # incremental build may not build the same file, and we will
546 # think that the warning has gone away.
547 # We could avoid this by using -Werror everywhere...
548 # For errors, the problem doesn't happen, since presumably
549 # the build stopped and didn't generate output, so will retry
550 # that file next time. So we could detect warnings and deal
551 # with them specially here. For now, we just reconfigure if
552 # anything goes work.
553 # Of course this is substantially slower if there are build
554 # errors/warnings (e.g. 2-3x slower even if only 10% of builds
555 # have problems).
556 if (failed and not result.already_done and not did_config and
557 self.builder.force_config_on_failure):
558 # If this build failed, try the next one with a
559 # reconfigure.
560 # Sometimes if the board_config.h file changes it can mess
561 # with dependencies, and we get:
562 # make: *** No rule to make target `include/autoconf.mk',
563 # needed by `depend'.
564 do_config = True
565 force_build = True
566 else:
567 force_build = False
568 if self.builder.force_config_on_failure:
569 if failed:
570 do_config = True
571 result.commit_upto = commit_upto
572 if result.return_code < 0:
573 raise ValueError('Interrupt')
574
575 # We have the build results, so output the result
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600576 self._WriteResult(result, job.keep_outputs, job.work_in_output)
Simon Glassa3d01442021-04-11 16:27:26 +1200577 self._SendResult(result)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600578 else:
579 # Just build the currently checked-out build
580 result, request_config = self.RunCommit(None, brd, work_dir, True,
Simon Glassb55b57d2016-11-16 14:09:25 -0700581 self.builder.config_only, True,
Simon Glasse5650a82022-01-22 05:07:33 -0700582 self.builder.force_build_failures, job.work_in_output,
583 job.adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600584 result.commit_upto = 0
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600585 self._WriteResult(result, job.keep_outputs, job.work_in_output)
Simon Glassa3d01442021-04-11 16:27:26 +1200586 self._SendResult(result)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600587
588 def run(self):
589 """Our thread's run function
590
591 This thread picks a job from the queue, runs it, and then goes to the
592 next job.
593 """
Simon Glass4a1e88b2014-08-09 15:33:00 -0600594 while True:
595 job = self.builder.queue.get()
Simon Glass9bf9a722021-04-11 16:27:27 +1200596 try:
597 self.RunJob(job)
598 except Exception as e:
Simon Glass9bac1672022-01-22 05:07:32 -0700599 print('Thread exception (use -T0 to run without threads):', e)
Simon Glass9bf9a722021-04-11 16:27:27 +1200600 self.builder.thread_exceptions.append(e)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600601 self.builder.queue.task_done()