blob: c2ff267de70140afba5d6d5b4315b8fea98ed0a8 [file] [log] [blame]
Simon Glassbfb0bb22019-10-31 07:42:55 -06001#!/usr/bin/env python3
Tom Rini10e47792018-05-06 17:58:06 -04002# SPDX-License-Identifier: GPL-2.0+
Simon Glass9d2eb922017-06-18 22:09:06 -06003# Copyright (c) 2012 The Chromium OS Authors.
4#
Simon Glass9d2eb922017-06-18 22:09:06 -06005
6"""Tests for the dtb_platdata module
7
Simon Glass70cd0d72018-07-06 10:27:20 -06008This includes unit tests for some functions and functional tests for the dtoc
9tool.
Simon Glass9d2eb922017-06-18 22:09:06 -060010"""
11
12import collections
13import os
14import struct
Walter Lozanoa324e412020-06-25 01:10:08 -030015import sys
Walter Lozanod82062b2020-07-28 19:06:23 -030016import tempfile
Simon Glass9d2eb922017-06-18 22:09:06 -060017import unittest
18
Simon Glassa997ea52020-04-17 18:09:04 -060019from dtoc import dtb_platdata
Simon Glass9d2eb922017-06-18 22:09:06 -060020from dtb_platdata import conv_name_to_c
21from dtb_platdata import get_compat_name
22from dtb_platdata import get_value
23from dtb_platdata import tab_to
Simon Glassa997ea52020-04-17 18:09:04 -060024from dtoc import fdt
25from dtoc import fdt_util
26from patman import test_util
27from patman import tools
Simon Glass9d2eb922017-06-18 22:09:06 -060028
29our_path = os.path.dirname(os.path.realpath(__file__))
30
31
Simon Glasseb37e2d2017-11-12 21:52:17 -070032HEADER = '''/*
33 * DO NOT MODIFY
34 *
35 * This file was generated by dtoc from a .dtb (device tree binary) file.
36 */
37
38#include <stdbool.h>
Masahiro Yamada75f82d02018-03-05 01:20:11 +090039#include <linux/libfdt.h>'''
Simon Glasseb37e2d2017-11-12 21:52:17 -070040
41C_HEADER = '''/*
42 * DO NOT MODIFY
43 *
44 * This file was generated by dtoc from a .dtb (device tree binary) file.
45 */
46
47#include <common.h>
48#include <dm.h>
49#include <dt-structs.h>
50'''
51
Walter Lozanodc5b4372020-06-25 01:10:13 -030052C_EMPTY_POPULATE_PHANDLE_DATA = '''void dm_populate_phandle_data(void) {
53}
54'''
Simon Glasseb37e2d2017-11-12 21:52:17 -070055
Simon Glass3bce93d2018-07-06 10:27:37 -060056
57def get_dtb_file(dts_fname, capture_stderr=False):
Simon Glass9d2eb922017-06-18 22:09:06 -060058 """Compile a .dts file to a .dtb
59
60 Args:
61 dts_fname: Filename of .dts file in the current directory
Simon Glass3bce93d2018-07-06 10:27:37 -060062 capture_stderr: True to capture and discard stderr output
Simon Glass9d2eb922017-06-18 22:09:06 -060063
64 Returns:
65 Filename of compiled file in output directory
66 """
Simon Glass3bce93d2018-07-06 10:27:37 -060067 return fdt_util.EnsureCompiled(os.path.join(our_path, dts_fname),
68 capture_stderr=capture_stderr)
Simon Glass9d2eb922017-06-18 22:09:06 -060069
70
71class TestDtoc(unittest.TestCase):
72 """Tests for dtoc"""
73 @classmethod
74 def setUpClass(cls):
75 tools.PrepareOutputDir(None)
Simon Glass7f5e2262020-07-07 21:32:06 -060076 cls.maxDiff = None
Simon Glass9d2eb922017-06-18 22:09:06 -060077
78 @classmethod
79 def tearDownClass(cls):
80 tools._RemoveOutputDir()
81
Simon Glassc47c2b32018-07-06 10:27:25 -060082 def _WritePythonString(self, fname, data):
83 """Write a string with tabs expanded as done in this Python file
84
85 Args:
86 fname: Filename to write to
87 data: Raw string to convert
88 """
89 data = data.replace('\t', '\\t')
90 with open(fname, 'w') as fd:
91 fd.write(data)
92
93 def _CheckStrings(self, expected, actual):
94 """Check that a string matches its expected value
95
96 If the strings do not match, they are written to the /tmp directory in
97 the same Python format as is used here in the test. This allows for
98 easy comparison and update of the tests.
99
100 Args:
101 expected: Expected string
102 actual: Actual string
103 """
104 if expected != actual:
105 self._WritePythonString('/tmp/binman.expected', expected)
106 self._WritePythonString('/tmp/binman.actual', actual)
Simon Glass61b88e52019-05-17 22:00:31 -0600107 print('Failures written to /tmp/binman.{expected,actual}')
Simon Glassc47c2b32018-07-06 10:27:25 -0600108 self.assertEquals(expected, actual)
109
Walter Lozanoa324e412020-06-25 01:10:08 -0300110
111 def run_test(self, args, dtb_file, output):
112 dtb_platdata.run_steps(args, dtb_file, False, output, True)
113
Simon Glass9d2eb922017-06-18 22:09:06 -0600114 def test_name(self):
115 """Test conversion of device tree names to C identifiers"""
116 self.assertEqual('serial_at_0x12', conv_name_to_c('serial@0x12'))
117 self.assertEqual('vendor_clock_frequency',
118 conv_name_to_c('vendor,clock-frequency'))
119 self.assertEqual('rockchip_rk3399_sdhci_5_1',
120 conv_name_to_c('rockchip,rk3399-sdhci-5.1'))
121
122 def test_tab_to(self):
123 """Test operation of tab_to() function"""
124 self.assertEqual('fred ', tab_to(0, 'fred'))
125 self.assertEqual('fred\t', tab_to(1, 'fred'))
126 self.assertEqual('fred was here ', tab_to(1, 'fred was here'))
127 self.assertEqual('fred was here\t\t', tab_to(3, 'fred was here'))
128 self.assertEqual('exactly8 ', tab_to(1, 'exactly8'))
129 self.assertEqual('exactly8\t', tab_to(2, 'exactly8'))
130
131 def test_get_value(self):
132 """Test operation of get_value() function"""
133 self.assertEqual('0x45',
134 get_value(fdt.TYPE_INT, struct.pack('>I', 0x45)))
135 self.assertEqual('0x45',
136 get_value(fdt.TYPE_BYTE, struct.pack('<I', 0x45)))
137 self.assertEqual('0x0',
138 get_value(fdt.TYPE_BYTE, struct.pack('>I', 0x45)))
139 self.assertEqual('"test"', get_value(fdt.TYPE_STRING, 'test'))
140 self.assertEqual('true', get_value(fdt.TYPE_BOOL, None))
141
142 def test_get_compat_name(self):
143 """Test operation of get_compat_name() function"""
144 Prop = collections.namedtuple('Prop', ['value'])
145 Node = collections.namedtuple('Node', ['props'])
146
147 prop = Prop(['rockchip,rk3399-sdhci-5.1', 'arasan,sdhci-5.1'])
148 node = Node({'compatible': prop})
Walter Lozano5fe734c2020-07-23 00:22:03 -0300149 self.assertEqual((['rockchip_rk3399_sdhci_5_1', 'arasan_sdhci_5_1']),
Simon Glass9d2eb922017-06-18 22:09:06 -0600150 get_compat_name(node))
151
152 prop = Prop(['rockchip,rk3399-sdhci-5.1'])
153 node = Node({'compatible': prop})
Walter Lozano5fe734c2020-07-23 00:22:03 -0300154 self.assertEqual((['rockchip_rk3399_sdhci_5_1']),
Simon Glass9d2eb922017-06-18 22:09:06 -0600155 get_compat_name(node))
156
157 prop = Prop(['rockchip,rk3399-sdhci-5.1', 'arasan,sdhci-5.1', 'third'])
158 node = Node({'compatible': prop})
Walter Lozano5fe734c2020-07-23 00:22:03 -0300159 self.assertEqual((['rockchip_rk3399_sdhci_5_1',
160 'arasan_sdhci_5_1', 'third']),
Simon Glass9d2eb922017-06-18 22:09:06 -0600161 get_compat_name(node))
162
163 def test_empty_file(self):
164 """Test output from a device tree file with no nodes"""
165 dtb_file = get_dtb_file('dtoc_test_empty.dts')
166 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300167 self.run_test(['struct'], dtb_file, output)
Simon Glass9d2eb922017-06-18 22:09:06 -0600168 with open(output) as infile:
169 lines = infile.read().splitlines()
Simon Glasseb37e2d2017-11-12 21:52:17 -0700170 self.assertEqual(HEADER.splitlines(), lines)
Simon Glass9d2eb922017-06-18 22:09:06 -0600171
Walter Lozanoa324e412020-06-25 01:10:08 -0300172 self.run_test(['platdata'], dtb_file, output)
Simon Glass9d2eb922017-06-18 22:09:06 -0600173 with open(output) as infile:
174 lines = infile.read().splitlines()
Walter Lozanodc5b4372020-06-25 01:10:13 -0300175 self.assertEqual(C_HEADER.splitlines() + [''] +
176 C_EMPTY_POPULATE_PHANDLE_DATA.splitlines(), lines)
Simon Glass9d2eb922017-06-18 22:09:06 -0600177
178 def test_simple(self):
179 """Test output from some simple nodes with various types of data"""
180 dtb_file = get_dtb_file('dtoc_test_simple.dts')
181 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300182 self.run_test(['struct'], dtb_file, output)
Simon Glass9d2eb922017-06-18 22:09:06 -0600183 with open(output) as infile:
184 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600185 self._CheckStrings(HEADER + '''
Simon Glass90e5f0a2017-08-29 14:15:51 -0600186struct dtd_sandbox_i2c_test {
187};
188struct dtd_sandbox_pmic_test {
189\tbool\t\tlow_power;
190\tfdt64_t\t\treg[2];
191};
Simon Glass9d2eb922017-06-18 22:09:06 -0600192struct dtd_sandbox_spl_test {
Simon Glass7f5e2262020-07-07 21:32:06 -0600193\tconst char * acpi_name;
Simon Glass9d2eb922017-06-18 22:09:06 -0600194\tbool\t\tboolval;
195\tunsigned char\tbytearray[3];
196\tunsigned char\tbyteval;
197\tfdt32_t\t\tintarray[4];
198\tfdt32_t\t\tintval;
199\tunsigned char\tlongbytearray[9];
Simon Glass9c526332018-07-06 10:27:28 -0600200\tunsigned char\tnotstring[5];
Simon Glass9d2eb922017-06-18 22:09:06 -0600201\tconst char *\tstringarray[3];
202\tconst char *\tstringval;
203};
204struct dtd_sandbox_spl_test_2 {
205};
206''', data)
207
Walter Lozanoa324e412020-06-25 01:10:08 -0300208 self.run_test(['platdata'], dtb_file, output)
Simon Glass9d2eb922017-06-18 22:09:06 -0600209 with open(output) as infile:
210 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600211 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300212static struct dtd_sandbox_spl_test dtv_spl_test = {
Simon Glassc82de562019-05-17 22:00:32 -0600213\t.boolval\t\t= true,
Simon Glass9d2eb922017-06-18 22:09:06 -0600214\t.bytearray\t\t= {0x6, 0x0, 0x0},
215\t.byteval\t\t= 0x5,
Simon Glassc82de562019-05-17 22:00:32 -0600216\t.intarray\t\t= {0x2, 0x3, 0x4, 0x0},
Simon Glass9d2eb922017-06-18 22:09:06 -0600217\t.intval\t\t\t= 0x1,
Simon Glass131e0b02017-08-29 14:15:49 -0600218\t.longbytearray\t\t= {0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0x10,
219\t\t0x11},
Simon Glassc82de562019-05-17 22:00:32 -0600220\t.notstring\t\t= {0x20, 0x21, 0x22, 0x10, 0x0},
Simon Glass9d2eb922017-06-18 22:09:06 -0600221\t.stringarray\t\t= {"multi-word", "message", ""},
Simon Glassc82de562019-05-17 22:00:32 -0600222\t.stringval\t\t= "message",
Simon Glass9d2eb922017-06-18 22:09:06 -0600223};
224U_BOOT_DEVICE(spl_test) = {
225\t.name\t\t= "sandbox_spl_test",
226\t.platdata\t= &dtv_spl_test,
227\t.platdata_size\t= sizeof(dtv_spl_test),
228};
229
Walter Lozanodc5b4372020-06-25 01:10:13 -0300230static struct dtd_sandbox_spl_test dtv_spl_test2 = {
Simon Glass7f5e2262020-07-07 21:32:06 -0600231\t.acpi_name\t\t= "\\\\_SB.GPO0",
Simon Glass9d2eb922017-06-18 22:09:06 -0600232\t.bytearray\t\t= {0x1, 0x23, 0x34},
233\t.byteval\t\t= 0x8,
Simon Glassc82de562019-05-17 22:00:32 -0600234\t.intarray\t\t= {0x5, 0x0, 0x0, 0x0},
Simon Glass9d2eb922017-06-18 22:09:06 -0600235\t.intval\t\t\t= 0x3,
Simon Glass131e0b02017-08-29 14:15:49 -0600236\t.longbytearray\t\t= {0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
237\t\t0x0},
Simon Glass9d2eb922017-06-18 22:09:06 -0600238\t.stringarray\t\t= {"another", "multi-word", "message"},
Simon Glassc82de562019-05-17 22:00:32 -0600239\t.stringval\t\t= "message2",
Simon Glass9d2eb922017-06-18 22:09:06 -0600240};
241U_BOOT_DEVICE(spl_test2) = {
242\t.name\t\t= "sandbox_spl_test",
243\t.platdata\t= &dtv_spl_test2,
244\t.platdata_size\t= sizeof(dtv_spl_test2),
245};
246
Walter Lozanodc5b4372020-06-25 01:10:13 -0300247static struct dtd_sandbox_spl_test dtv_spl_test3 = {
Simon Glass9d2eb922017-06-18 22:09:06 -0600248\t.stringarray\t\t= {"one", "", ""},
249};
250U_BOOT_DEVICE(spl_test3) = {
251\t.name\t\t= "sandbox_spl_test",
252\t.platdata\t= &dtv_spl_test3,
253\t.platdata_size\t= sizeof(dtv_spl_test3),
254};
255
Walter Lozanodc5b4372020-06-25 01:10:13 -0300256static struct dtd_sandbox_spl_test_2 dtv_spl_test4 = {
Simon Glass9d2eb922017-06-18 22:09:06 -0600257};
258U_BOOT_DEVICE(spl_test4) = {
259\t.name\t\t= "sandbox_spl_test_2",
260\t.platdata\t= &dtv_spl_test4,
261\t.platdata_size\t= sizeof(dtv_spl_test4),
262};
263
Walter Lozanodc5b4372020-06-25 01:10:13 -0300264static struct dtd_sandbox_i2c_test dtv_i2c_at_0 = {
Simon Glass90e5f0a2017-08-29 14:15:51 -0600265};
266U_BOOT_DEVICE(i2c_at_0) = {
267\t.name\t\t= "sandbox_i2c_test",
268\t.platdata\t= &dtv_i2c_at_0,
269\t.platdata_size\t= sizeof(dtv_i2c_at_0),
270};
271
Walter Lozanodc5b4372020-06-25 01:10:13 -0300272static struct dtd_sandbox_pmic_test dtv_pmic_at_9 = {
Simon Glass90e5f0a2017-08-29 14:15:51 -0600273\t.low_power\t\t= true,
274\t.reg\t\t\t= {0x9, 0x0},
275};
276U_BOOT_DEVICE(pmic_at_9) = {
277\t.name\t\t= "sandbox_pmic_test",
278\t.platdata\t= &dtv_pmic_at_9,
279\t.platdata_size\t= sizeof(dtv_pmic_at_9),
280};
281
Walter Lozanodc5b4372020-06-25 01:10:13 -0300282''' + C_EMPTY_POPULATE_PHANDLE_DATA, data)
Simon Glass9d2eb922017-06-18 22:09:06 -0600283
Walter Lozanoe675d962020-07-03 08:07:17 -0300284 def test_driver_alias(self):
285 """Test output from a device tree file with a driver alias"""
286 dtb_file = get_dtb_file('dtoc_test_driver_alias.dts')
287 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300288 self.run_test(['struct'], dtb_file, output)
Walter Lozanoe675d962020-07-03 08:07:17 -0300289 with open(output) as infile:
290 data = infile.read()
291 self._CheckStrings(HEADER + '''
292struct dtd_sandbox_gpio {
293\tconst char *\tgpio_bank_name;
294\tbool\t\tgpio_controller;
295\tfdt32_t\t\tsandbox_gpio_count;
296};
Walter Lozanoe675d962020-07-03 08:07:17 -0300297''', data)
298
Walter Lozanoa324e412020-06-25 01:10:08 -0300299 self.run_test(['platdata'], dtb_file, output)
Walter Lozanoe675d962020-07-03 08:07:17 -0300300 with open(output) as infile:
301 data = infile.read()
302 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300303static struct dtd_sandbox_gpio dtv_gpios_at_0 = {
Walter Lozanoe675d962020-07-03 08:07:17 -0300304\t.gpio_bank_name\t\t= "a",
305\t.gpio_controller\t= true,
306\t.sandbox_gpio_count\t= 0x14,
307};
308U_BOOT_DEVICE(gpios_at_0) = {
309\t.name\t\t= "sandbox_gpio",
310\t.platdata\t= &dtv_gpios_at_0,
311\t.platdata_size\t= sizeof(dtv_gpios_at_0),
312};
313
Walter Lozanodc5b4372020-06-25 01:10:13 -0300314void dm_populate_phandle_data(void) {
315}
Walter Lozanoe675d962020-07-03 08:07:17 -0300316''', data)
317
Walter Lozanoa324e412020-06-25 01:10:08 -0300318 def test_invalid_driver(self):
319 """Test output from a device tree file with an invalid driver"""
320 dtb_file = get_dtb_file('dtoc_test_invalid_driver.dts')
321 output = tools.GetOutputFilename('output')
322 with test_util.capture_sys_output() as (stdout, stderr):
323 dtb_platdata.run_steps(['struct'], dtb_file, False, output)
324 with open(output) as infile:
325 data = infile.read()
326 self._CheckStrings(HEADER + '''
327struct dtd_invalid {
328};
329''', data)
330
331 with test_util.capture_sys_output() as (stdout, stderr):
332 dtb_platdata.run_steps(['platdata'], dtb_file, False, output)
333 with open(output) as infile:
334 data = infile.read()
335 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300336static struct dtd_invalid dtv_spl_test = {
Walter Lozanoa324e412020-06-25 01:10:08 -0300337};
338U_BOOT_DEVICE(spl_test) = {
339\t.name\t\t= "invalid",
340\t.platdata\t= &dtv_spl_test,
341\t.platdata_size\t= sizeof(dtv_spl_test),
342};
343
Walter Lozanodc5b4372020-06-25 01:10:13 -0300344void dm_populate_phandle_data(void) {
345}
Walter Lozanoa324e412020-06-25 01:10:08 -0300346''', data)
347
Simon Glass9d2eb922017-06-18 22:09:06 -0600348 def test_phandle(self):
349 """Test output from a node containing a phandle reference"""
350 dtb_file = get_dtb_file('dtoc_test_phandle.dts')
351 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300352 self.run_test(['struct'], dtb_file, output)
Simon Glass9d2eb922017-06-18 22:09:06 -0600353 with open(output) as infile:
354 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600355 self._CheckStrings(HEADER + '''
Simon Glass9d2eb922017-06-18 22:09:06 -0600356struct dtd_source {
Simon Glass3deeb472017-08-29 14:15:59 -0600357\tstruct phandle_2_arg clocks[4];
Simon Glass9d2eb922017-06-18 22:09:06 -0600358};
359struct dtd_target {
360\tfdt32_t\t\tintval;
361};
362''', data)
363
Walter Lozanoa324e412020-06-25 01:10:08 -0300364 self.run_test(['platdata'], dtb_file, output)
Simon Glass9d2eb922017-06-18 22:09:06 -0600365 with open(output) as infile:
366 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600367 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300368static struct dtd_target dtv_phandle_target = {
Simon Glass3deeb472017-08-29 14:15:59 -0600369\t.intval\t\t\t= 0x0,
Simon Glass9d2eb922017-06-18 22:09:06 -0600370};
371U_BOOT_DEVICE(phandle_target) = {
372\t.name\t\t= "target",
373\t.platdata\t= &dtv_phandle_target,
374\t.platdata_size\t= sizeof(dtv_phandle_target),
375};
376
Walter Lozanodc5b4372020-06-25 01:10:13 -0300377static struct dtd_target dtv_phandle2_target = {
Simon Glass3deeb472017-08-29 14:15:59 -0600378\t.intval\t\t\t= 0x1,
379};
380U_BOOT_DEVICE(phandle2_target) = {
381\t.name\t\t= "target",
382\t.platdata\t= &dtv_phandle2_target,
383\t.platdata_size\t= sizeof(dtv_phandle2_target),
384};
385
Walter Lozanodc5b4372020-06-25 01:10:13 -0300386static struct dtd_target dtv_phandle3_target = {
Simon Glass3deeb472017-08-29 14:15:59 -0600387\t.intval\t\t\t= 0x2,
388};
389U_BOOT_DEVICE(phandle3_target) = {
390\t.name\t\t= "target",
391\t.platdata\t= &dtv_phandle3_target,
392\t.platdata_size\t= sizeof(dtv_phandle3_target),
393};
394
Walter Lozanodc5b4372020-06-25 01:10:13 -0300395static struct dtd_source dtv_phandle_source = {
Simon Glassd0cd0752017-08-29 14:15:57 -0600396\t.clocks\t\t\t= {
Walter Lozanodc5b4372020-06-25 01:10:13 -0300397\t\t\t{NULL, {}},
398\t\t\t{NULL, {11}},
399\t\t\t{NULL, {12, 13}},
400\t\t\t{NULL, {}},},
Simon Glass9d2eb922017-06-18 22:09:06 -0600401};
402U_BOOT_DEVICE(phandle_source) = {
403\t.name\t\t= "source",
404\t.platdata\t= &dtv_phandle_source,
405\t.platdata_size\t= sizeof(dtv_phandle_source),
406};
407
Walter Lozanodc5b4372020-06-25 01:10:13 -0300408static struct dtd_source dtv_phandle_source2 = {
Simon Glass609e2b12018-07-06 10:27:31 -0600409\t.clocks\t\t\t= {
Walter Lozanodc5b4372020-06-25 01:10:13 -0300410\t\t\t{NULL, {}},},
Simon Glass609e2b12018-07-06 10:27:31 -0600411};
412U_BOOT_DEVICE(phandle_source2) = {
413\t.name\t\t= "source",
414\t.platdata\t= &dtv_phandle_source2,
415\t.platdata_size\t= sizeof(dtv_phandle_source2),
416};
417
Walter Lozanodc5b4372020-06-25 01:10:13 -0300418void dm_populate_phandle_data(void) {
419\tdtv_phandle_source.clocks[0].node = DM_GET_DEVICE(phandle_target);
420\tdtv_phandle_source.clocks[1].node = DM_GET_DEVICE(phandle2_target);
421\tdtv_phandle_source.clocks[2].node = DM_GET_DEVICE(phandle3_target);
422\tdtv_phandle_source.clocks[3].node = DM_GET_DEVICE(phandle_target);
423\tdtv_phandle_source2.clocks[0].node = DM_GET_DEVICE(phandle_target);
424}
Simon Glass9d2eb922017-06-18 22:09:06 -0600425''', data)
426
Simon Glass961c1ce2018-07-06 10:27:35 -0600427 def test_phandle_single(self):
428 """Test output from a node containing a phandle reference"""
429 dtb_file = get_dtb_file('dtoc_test_phandle_single.dts')
430 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300431 self.run_test(['struct'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600432 with open(output) as infile:
433 data = infile.read()
434 self._CheckStrings(HEADER + '''
435struct dtd_source {
436\tstruct phandle_0_arg clocks[1];
437};
438struct dtd_target {
439\tfdt32_t\t\tintval;
440};
441''', data)
442
443 def test_phandle_reorder(self):
444 """Test that phandle targets are generated before their references"""
445 dtb_file = get_dtb_file('dtoc_test_phandle_reorder.dts')
446 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300447 self.run_test(['platdata'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600448 with open(output) as infile:
449 data = infile.read()
450 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300451static struct dtd_target dtv_phandle_target = {
Simon Glass961c1ce2018-07-06 10:27:35 -0600452};
453U_BOOT_DEVICE(phandle_target) = {
454\t.name\t\t= "target",
455\t.platdata\t= &dtv_phandle_target,
456\t.platdata_size\t= sizeof(dtv_phandle_target),
457};
458
Walter Lozanodc5b4372020-06-25 01:10:13 -0300459static struct dtd_source dtv_phandle_source2 = {
Simon Glass961c1ce2018-07-06 10:27:35 -0600460\t.clocks\t\t\t= {
Walter Lozanodc5b4372020-06-25 01:10:13 -0300461\t\t\t{NULL, {}},},
Simon Glass961c1ce2018-07-06 10:27:35 -0600462};
463U_BOOT_DEVICE(phandle_source2) = {
464\t.name\t\t= "source",
465\t.platdata\t= &dtv_phandle_source2,
466\t.platdata_size\t= sizeof(dtv_phandle_source2),
467};
468
Walter Lozanodc5b4372020-06-25 01:10:13 -0300469void dm_populate_phandle_data(void) {
470\tdtv_phandle_source2.clocks[0].node = DM_GET_DEVICE(phandle_target);
471}
Simon Glass961c1ce2018-07-06 10:27:35 -0600472''', data)
473
Walter Lozano5541fc02020-06-25 01:10:17 -0300474 def test_phandle_cd_gpio(self):
475 """Test that phandle targets are generated when unsing cd-gpios"""
476 dtb_file = get_dtb_file('dtoc_test_phandle_cd_gpios.dts')
477 output = tools.GetOutputFilename('output')
478 dtb_platdata.run_steps(['platdata'], dtb_file, False, output, True)
479 with open(output) as infile:
480 data = infile.read()
481 self._CheckStrings(C_HEADER + '''
482static struct dtd_target dtv_phandle_target = {
483\t.intval\t\t\t= 0x0,
484};
485U_BOOT_DEVICE(phandle_target) = {
486\t.name\t\t= "target",
487\t.platdata\t= &dtv_phandle_target,
488\t.platdata_size\t= sizeof(dtv_phandle_target),
489};
490
491static struct dtd_target dtv_phandle2_target = {
492\t.intval\t\t\t= 0x1,
493};
494U_BOOT_DEVICE(phandle2_target) = {
495\t.name\t\t= "target",
496\t.platdata\t= &dtv_phandle2_target,
497\t.platdata_size\t= sizeof(dtv_phandle2_target),
498};
499
500static struct dtd_target dtv_phandle3_target = {
501\t.intval\t\t\t= 0x2,
502};
503U_BOOT_DEVICE(phandle3_target) = {
504\t.name\t\t= "target",
505\t.platdata\t= &dtv_phandle3_target,
506\t.platdata_size\t= sizeof(dtv_phandle3_target),
507};
508
509static struct dtd_source dtv_phandle_source = {
510\t.cd_gpios\t\t= {
511\t\t\t{NULL, {}},
512\t\t\t{NULL, {11}},
513\t\t\t{NULL, {12, 13}},
514\t\t\t{NULL, {}},},
515};
516U_BOOT_DEVICE(phandle_source) = {
517\t.name\t\t= "source",
518\t.platdata\t= &dtv_phandle_source,
519\t.platdata_size\t= sizeof(dtv_phandle_source),
520};
521
522static struct dtd_source dtv_phandle_source2 = {
523\t.cd_gpios\t\t= {
524\t\t\t{NULL, {}},},
525};
526U_BOOT_DEVICE(phandle_source2) = {
527\t.name\t\t= "source",
528\t.platdata\t= &dtv_phandle_source2,
529\t.platdata_size\t= sizeof(dtv_phandle_source2),
530};
531
532void dm_populate_phandle_data(void) {
533\tdtv_phandle_source.cd_gpios[0].node = DM_GET_DEVICE(phandle_target);
534\tdtv_phandle_source.cd_gpios[1].node = DM_GET_DEVICE(phandle2_target);
535\tdtv_phandle_source.cd_gpios[2].node = DM_GET_DEVICE(phandle3_target);
536\tdtv_phandle_source.cd_gpios[3].node = DM_GET_DEVICE(phandle_target);
537\tdtv_phandle_source2.cd_gpios[0].node = DM_GET_DEVICE(phandle_target);
538}
539''', data)
540
Simon Glass961c1ce2018-07-06 10:27:35 -0600541 def test_phandle_bad(self):
542 """Test a node containing an invalid phandle fails"""
Simon Glass04150022018-10-01 21:12:43 -0600543 dtb_file = get_dtb_file('dtoc_test_phandle_bad.dts',
544 capture_stderr=True)
Simon Glass961c1ce2018-07-06 10:27:35 -0600545 output = tools.GetOutputFilename('output')
546 with self.assertRaises(ValueError) as e:
Walter Lozanoa324e412020-06-25 01:10:08 -0300547 self.run_test(['struct'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600548 self.assertIn("Cannot parse 'clocks' in node 'phandle-source'",
549 str(e.exception))
550
551 def test_phandle_bad2(self):
552 """Test a phandle target missing its #*-cells property"""
Simon Glass04150022018-10-01 21:12:43 -0600553 dtb_file = get_dtb_file('dtoc_test_phandle_bad2.dts',
554 capture_stderr=True)
Simon Glass961c1ce2018-07-06 10:27:35 -0600555 output = tools.GetOutputFilename('output')
556 with self.assertRaises(ValueError) as e:
Walter Lozanoa324e412020-06-25 01:10:08 -0300557 self.run_test(['struct'], dtb_file, output)
Walter Lozano179f0b62020-06-25 01:10:16 -0300558 self.assertIn("Node 'phandle-target' has no cells property",
Simon Glass961c1ce2018-07-06 10:27:35 -0600559 str(e.exception))
560
Simon Glass1b1fe412017-08-29 14:15:50 -0600561 def test_addresses64(self):
562 """Test output from a node with a 'reg' property with na=2, ns=2"""
563 dtb_file = get_dtb_file('dtoc_test_addr64.dts')
564 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300565 self.run_test(['struct'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600566 with open(output) as infile:
567 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600568 self._CheckStrings(HEADER + '''
Simon Glass1b1fe412017-08-29 14:15:50 -0600569struct dtd_test1 {
570\tfdt64_t\t\treg[2];
571};
572struct dtd_test2 {
573\tfdt64_t\t\treg[2];
574};
575struct dtd_test3 {
576\tfdt64_t\t\treg[4];
577};
578''', data)
579
Walter Lozanoa324e412020-06-25 01:10:08 -0300580 self.run_test(['platdata'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600581 with open(output) as infile:
582 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600583 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300584static struct dtd_test1 dtv_test1 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600585\t.reg\t\t\t= {0x1234, 0x5678},
586};
587U_BOOT_DEVICE(test1) = {
588\t.name\t\t= "test1",
589\t.platdata\t= &dtv_test1,
590\t.platdata_size\t= sizeof(dtv_test1),
591};
592
Walter Lozanodc5b4372020-06-25 01:10:13 -0300593static struct dtd_test2 dtv_test2 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600594\t.reg\t\t\t= {0x1234567890123456, 0x9876543210987654},
595};
596U_BOOT_DEVICE(test2) = {
597\t.name\t\t= "test2",
598\t.platdata\t= &dtv_test2,
599\t.platdata_size\t= sizeof(dtv_test2),
600};
601
Walter Lozanodc5b4372020-06-25 01:10:13 -0300602static struct dtd_test3 dtv_test3 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600603\t.reg\t\t\t= {0x1234567890123456, 0x9876543210987654, 0x2, 0x3},
604};
605U_BOOT_DEVICE(test3) = {
606\t.name\t\t= "test3",
607\t.platdata\t= &dtv_test3,
608\t.platdata_size\t= sizeof(dtv_test3),
609};
610
Walter Lozanodc5b4372020-06-25 01:10:13 -0300611''' + C_EMPTY_POPULATE_PHANDLE_DATA, data)
Simon Glass1b1fe412017-08-29 14:15:50 -0600612
613 def test_addresses32(self):
614 """Test output from a node with a 'reg' property with na=1, ns=1"""
615 dtb_file = get_dtb_file('dtoc_test_addr32.dts')
616 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300617 self.run_test(['struct'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600618 with open(output) as infile:
619 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600620 self._CheckStrings(HEADER + '''
Simon Glass1b1fe412017-08-29 14:15:50 -0600621struct dtd_test1 {
622\tfdt32_t\t\treg[2];
623};
624struct dtd_test2 {
625\tfdt32_t\t\treg[4];
626};
627''', data)
628
Walter Lozanoa324e412020-06-25 01:10:08 -0300629 self.run_test(['platdata'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600630 with open(output) as infile:
631 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600632 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300633static struct dtd_test1 dtv_test1 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600634\t.reg\t\t\t= {0x1234, 0x5678},
635};
636U_BOOT_DEVICE(test1) = {
637\t.name\t\t= "test1",
638\t.platdata\t= &dtv_test1,
639\t.platdata_size\t= sizeof(dtv_test1),
640};
641
Walter Lozanodc5b4372020-06-25 01:10:13 -0300642static struct dtd_test2 dtv_test2 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600643\t.reg\t\t\t= {0x12345678, 0x98765432, 0x2, 0x3},
644};
645U_BOOT_DEVICE(test2) = {
646\t.name\t\t= "test2",
647\t.platdata\t= &dtv_test2,
648\t.platdata_size\t= sizeof(dtv_test2),
649};
650
Walter Lozanodc5b4372020-06-25 01:10:13 -0300651''' + C_EMPTY_POPULATE_PHANDLE_DATA, data)
Simon Glass1b1fe412017-08-29 14:15:50 -0600652
653 def test_addresses64_32(self):
654 """Test output from a node with a 'reg' property with na=2, ns=1"""
655 dtb_file = get_dtb_file('dtoc_test_addr64_32.dts')
656 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300657 self.run_test(['struct'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600658 with open(output) as infile:
659 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600660 self._CheckStrings(HEADER + '''
Simon Glass1b1fe412017-08-29 14:15:50 -0600661struct dtd_test1 {
662\tfdt64_t\t\treg[2];
663};
664struct dtd_test2 {
665\tfdt64_t\t\treg[2];
666};
667struct dtd_test3 {
668\tfdt64_t\t\treg[4];
669};
670''', data)
671
Walter Lozanoa324e412020-06-25 01:10:08 -0300672 self.run_test(['platdata'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600673 with open(output) as infile:
674 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600675 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300676static struct dtd_test1 dtv_test1 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600677\t.reg\t\t\t= {0x123400000000, 0x5678},
678};
679U_BOOT_DEVICE(test1) = {
680\t.name\t\t= "test1",
681\t.platdata\t= &dtv_test1,
682\t.platdata_size\t= sizeof(dtv_test1),
683};
684
Walter Lozanodc5b4372020-06-25 01:10:13 -0300685static struct dtd_test2 dtv_test2 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600686\t.reg\t\t\t= {0x1234567890123456, 0x98765432},
687};
688U_BOOT_DEVICE(test2) = {
689\t.name\t\t= "test2",
690\t.platdata\t= &dtv_test2,
691\t.platdata_size\t= sizeof(dtv_test2),
692};
693
Walter Lozanodc5b4372020-06-25 01:10:13 -0300694static struct dtd_test3 dtv_test3 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600695\t.reg\t\t\t= {0x1234567890123456, 0x98765432, 0x2, 0x3},
696};
697U_BOOT_DEVICE(test3) = {
698\t.name\t\t= "test3",
699\t.platdata\t= &dtv_test3,
700\t.platdata_size\t= sizeof(dtv_test3),
701};
702
Walter Lozanodc5b4372020-06-25 01:10:13 -0300703''' + C_EMPTY_POPULATE_PHANDLE_DATA, data)
Simon Glass1b1fe412017-08-29 14:15:50 -0600704
705 def test_addresses32_64(self):
706 """Test output from a node with a 'reg' property with na=1, ns=2"""
707 dtb_file = get_dtb_file('dtoc_test_addr32_64.dts')
708 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300709 self.run_test(['struct'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600710 with open(output) as infile:
711 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600712 self._CheckStrings(HEADER + '''
Simon Glass1b1fe412017-08-29 14:15:50 -0600713struct dtd_test1 {
714\tfdt64_t\t\treg[2];
715};
716struct dtd_test2 {
717\tfdt64_t\t\treg[2];
718};
719struct dtd_test3 {
720\tfdt64_t\t\treg[4];
721};
722''', data)
723
Walter Lozanoa324e412020-06-25 01:10:08 -0300724 self.run_test(['platdata'], dtb_file, output)
Simon Glass1b1fe412017-08-29 14:15:50 -0600725 with open(output) as infile:
726 data = infile.read()
Simon Glassc47c2b32018-07-06 10:27:25 -0600727 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300728static struct dtd_test1 dtv_test1 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600729\t.reg\t\t\t= {0x1234, 0x567800000000},
730};
731U_BOOT_DEVICE(test1) = {
732\t.name\t\t= "test1",
733\t.platdata\t= &dtv_test1,
734\t.platdata_size\t= sizeof(dtv_test1),
735};
736
Walter Lozanodc5b4372020-06-25 01:10:13 -0300737static struct dtd_test2 dtv_test2 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600738\t.reg\t\t\t= {0x12345678, 0x9876543210987654},
739};
740U_BOOT_DEVICE(test2) = {
741\t.name\t\t= "test2",
742\t.platdata\t= &dtv_test2,
743\t.platdata_size\t= sizeof(dtv_test2),
744};
745
Walter Lozanodc5b4372020-06-25 01:10:13 -0300746static struct dtd_test3 dtv_test3 = {
Simon Glass1b1fe412017-08-29 14:15:50 -0600747\t.reg\t\t\t= {0x12345678, 0x9876543210987654, 0x2, 0x3},
748};
749U_BOOT_DEVICE(test3) = {
750\t.name\t\t= "test3",
751\t.platdata\t= &dtv_test3,
752\t.platdata_size\t= sizeof(dtv_test3),
753};
754
Walter Lozanodc5b4372020-06-25 01:10:13 -0300755''' + C_EMPTY_POPULATE_PHANDLE_DATA, data)
Simon Glass961c1ce2018-07-06 10:27:35 -0600756
757 def test_bad_reg(self):
758 """Test that a reg property with an invalid type generates an error"""
Simon Glass3bce93d2018-07-06 10:27:37 -0600759 # Capture stderr since dtc will emit warnings for this file
760 dtb_file = get_dtb_file('dtoc_test_bad_reg.dts', capture_stderr=True)
Simon Glass961c1ce2018-07-06 10:27:35 -0600761 output = tools.GetOutputFilename('output')
762 with self.assertRaises(ValueError) as e:
Walter Lozanoa324e412020-06-25 01:10:08 -0300763 self.run_test(['struct'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600764 self.assertIn("Node 'spl-test' reg property is not an int",
765 str(e.exception))
766
767 def test_bad_reg2(self):
768 """Test that a reg property with an invalid cell count is detected"""
Simon Glass3bce93d2018-07-06 10:27:37 -0600769 # Capture stderr since dtc will emit warnings for this file
770 dtb_file = get_dtb_file('dtoc_test_bad_reg2.dts', capture_stderr=True)
Simon Glass961c1ce2018-07-06 10:27:35 -0600771 output = tools.GetOutputFilename('output')
772 with self.assertRaises(ValueError) as e:
Walter Lozanoa324e412020-06-25 01:10:08 -0300773 self.run_test(['struct'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600774 self.assertIn("Node 'spl-test' reg property has 3 cells which is not a multiple of na + ns = 1 + 1)",
775 str(e.exception))
776
777 def test_add_prop(self):
778 """Test that a subequent node can add a new property to a struct"""
779 dtb_file = get_dtb_file('dtoc_test_add_prop.dts')
780 output = tools.GetOutputFilename('output')
Walter Lozanoa324e412020-06-25 01:10:08 -0300781 self.run_test(['struct'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600782 with open(output) as infile:
783 data = infile.read()
784 self._CheckStrings(HEADER + '''
785struct dtd_sandbox_spl_test {
786\tfdt32_t\t\tintarray;
787\tfdt32_t\t\tintval;
788};
789''', data)
790
Walter Lozanoa324e412020-06-25 01:10:08 -0300791 self.run_test(['platdata'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600792 with open(output) as infile:
793 data = infile.read()
794 self._CheckStrings(C_HEADER + '''
Walter Lozanodc5b4372020-06-25 01:10:13 -0300795static struct dtd_sandbox_spl_test dtv_spl_test = {
Simon Glass961c1ce2018-07-06 10:27:35 -0600796\t.intval\t\t\t= 0x1,
797};
798U_BOOT_DEVICE(spl_test) = {
799\t.name\t\t= "sandbox_spl_test",
800\t.platdata\t= &dtv_spl_test,
801\t.platdata_size\t= sizeof(dtv_spl_test),
802};
803
Walter Lozanodc5b4372020-06-25 01:10:13 -0300804static struct dtd_sandbox_spl_test dtv_spl_test2 = {
Simon Glass961c1ce2018-07-06 10:27:35 -0600805\t.intarray\t\t= 0x5,
806};
807U_BOOT_DEVICE(spl_test2) = {
808\t.name\t\t= "sandbox_spl_test",
809\t.platdata\t= &dtv_spl_test2,
810\t.platdata_size\t= sizeof(dtv_spl_test2),
811};
812
Walter Lozanodc5b4372020-06-25 01:10:13 -0300813''' + C_EMPTY_POPULATE_PHANDLE_DATA, data)
Simon Glass961c1ce2018-07-06 10:27:35 -0600814
815 def testStdout(self):
816 """Test output to stdout"""
817 dtb_file = get_dtb_file('dtoc_test_simple.dts')
818 with test_util.capture_sys_output() as (stdout, stderr):
Walter Lozanoa324e412020-06-25 01:10:08 -0300819 self.run_test(['struct'], dtb_file, '-')
Simon Glass961c1ce2018-07-06 10:27:35 -0600820
821 def testNoCommand(self):
822 """Test running dtoc without a command"""
823 with self.assertRaises(ValueError) as e:
Walter Lozanoa324e412020-06-25 01:10:08 -0300824 self.run_test([], '', '')
Simon Glass961c1ce2018-07-06 10:27:35 -0600825 self.assertIn("Please specify a command: struct, platdata",
826 str(e.exception))
827
828 def testBadCommand(self):
829 """Test running dtoc with an invalid command"""
830 dtb_file = get_dtb_file('dtoc_test_simple.dts')
831 output = tools.GetOutputFilename('output')
832 with self.assertRaises(ValueError) as e:
Walter Lozanoa324e412020-06-25 01:10:08 -0300833 self.run_test(['invalid-cmd'], dtb_file, output)
Simon Glass961c1ce2018-07-06 10:27:35 -0600834 self.assertIn("Unknown command 'invalid-cmd': (use: struct, platdata)",
835 str(e.exception))
Walter Lozanod82062b2020-07-28 19:06:23 -0300836
837 def testScanDrivers(self):
838 """Test running dtoc with additional drivers to scan"""
839 dtb_file = get_dtb_file('dtoc_test_simple.dts')
840 output = tools.GetOutputFilename('output')
841 with test_util.capture_sys_output() as (stdout, stderr):
842 dtb_platdata.run_steps(['struct'], dtb_file, False, output, True,
843 [None, '', 'tools/dtoc/dtoc_test_scan_drivers.cxx'])
844
845 def testUnicodeError(self):
846 """Test running dtoc with an invalid unicode file
847
848 To be able to perform this test without adding a weird text file which
849 would produce issues when using checkpatch.pl or patman, generate the
850 file at runtime and then process it.
851 """
852 dtb_file = get_dtb_file('dtoc_test_simple.dts')
853 output = tools.GetOutputFilename('output')
854 driver_fn = '/tmp/' + next(tempfile._get_candidate_names())
855 with open(driver_fn, 'wb+') as df:
856 df.write(b'\x81')
857
858 with test_util.capture_sys_output() as (stdout, stderr):
859 dtb_platdata.run_steps(['struct'], dtb_file, False, output, True,
860 [driver_fn])