blob: 680efae02d7f52d7af8ebd7286d5b5fb0842ea6a [file] [log] [blame]
Tom Rini10e47792018-05-06 17:58:06 -04001# SPDX-License-Identifier: GPL-2.0+
Simon Glass4a1e88b2014-08-09 15:33:00 -06002# Copyright (c) 2014 Google, Inc
3#
Simon Glass4a1e88b2014-08-09 15:33:00 -06004
5import errno
6import glob
7import os
8import shutil
Lothar Waßmannce6df922018-04-08 05:14:11 -06009import sys
Simon Glass4a1e88b2014-08-09 15:33:00 -060010import threading
11
Simon Glasse5650a82022-01-22 05:07:33 -070012from buildman import cfgutil
Simon Glassa997ea52020-04-17 18:09:04 -060013from patman import command
14from patman import gitutil
Simon Glass4a1e88b2014-08-09 15:33:00 -060015
Simon Glassfd3eea12015-02-05 22:06:13 -070016RETURN_CODE_RETRY = -1
Simon Glasse0f19712020-12-16 17:24:17 -070017BASE_ELF_FILENAMES = ['u-boot', 'spl/u-boot-spl', 'tpl/u-boot-tpl']
Simon Glassfd3eea12015-02-05 22:06:13 -070018
Thierry Reding336d5bd2014-08-19 10:22:39 +020019def Mkdir(dirname, parents = False):
Simon Glass4a1e88b2014-08-09 15:33:00 -060020 """Make a directory if it doesn't already exist.
21
22 Args:
23 dirname: Directory to create
24 """
25 try:
Thierry Reding336d5bd2014-08-19 10:22:39 +020026 if parents:
27 os.makedirs(dirname)
28 else:
29 os.mkdir(dirname)
Simon Glass4a1e88b2014-08-09 15:33:00 -060030 except OSError as err:
31 if err.errno == errno.EEXIST:
Lothar Waßmannce6df922018-04-08 05:14:11 -060032 if os.path.realpath('.') == os.path.realpath(dirname):
Simon Glassc78ed662019-10-31 07:42:53 -060033 print("Cannot create the current working directory '%s'!" % dirname)
Lothar Waßmannce6df922018-04-08 05:14:11 -060034 sys.exit(1)
Simon Glass4a1e88b2014-08-09 15:33:00 -060035 pass
36 else:
37 raise
38
39class BuilderJob:
40 """Holds information about a job to be performed by a thread
41
42 Members:
Simon Glass8132f982022-07-11 19:03:57 -060043 brd: Board object to build
Simon Glassdf890152020-03-18 09:42:41 -060044 commits: List of Commit objects to build
45 keep_outputs: True to save build output files
46 step: 1 to process every commit, n to process every nth commit
Simon Glassb6eb8cf2020-03-18 09:42:42 -060047 work_in_output: Use the output directory as the work directory and
48 don't write to a separate output directory.
Simon Glass4a1e88b2014-08-09 15:33:00 -060049 """
50 def __init__(self):
Simon Glass8132f982022-07-11 19:03:57 -060051 self.brd = None
Simon Glass4a1e88b2014-08-09 15:33:00 -060052 self.commits = []
Simon Glassdf890152020-03-18 09:42:41 -060053 self.keep_outputs = False
54 self.step = 1
Simon Glassb6eb8cf2020-03-18 09:42:42 -060055 self.work_in_output = False
Simon Glass4a1e88b2014-08-09 15:33:00 -060056
57
58class ResultThread(threading.Thread):
59 """This thread processes results from builder threads.
60
61 It simply passes the results on to the builder. There is only one
62 result thread, and this helps to serialise the build output.
63 """
64 def __init__(self, builder):
65 """Set up a new result thread
66
67 Args:
68 builder: Builder which will be sent each result
69 """
70 threading.Thread.__init__(self)
71 self.builder = builder
72
73 def run(self):
74 """Called to start up the result thread.
75
76 We collect the next result job and pass it on to the build.
77 """
78 while True:
79 result = self.builder.out_queue.get()
80 self.builder.ProcessResult(result)
81 self.builder.out_queue.task_done()
82
83
84class BuilderThread(threading.Thread):
85 """This thread builds U-Boot for a particular board.
86
87 An input queue provides each new job. We run 'make' to build U-Boot
88 and then pass the results on to the output queue.
89
90 Members:
91 builder: The builder which contains information we might need
92 thread_num: Our thread number (0-n-1), used to decide on a
Simon Glassa29b3ea2021-04-11 16:27:25 +120093 temporary directory. If this is -1 then there are no threads
94 and we are the (only) main process
95 mrproper: Use 'make mrproper' before each reconfigure
96 per_board_out_dir: True to build in a separate persistent directory per
97 board rather than a thread-specific directory
98 test_exception: Used for testing; True to raise an exception instead of
99 reporting the build result
Simon Glass4a1e88b2014-08-09 15:33:00 -0600100 """
Simon Glass9bf9a722021-04-11 16:27:27 +1200101 def __init__(self, builder, thread_num, mrproper, per_board_out_dir,
102 test_exception=False):
Simon Glass4a1e88b2014-08-09 15:33:00 -0600103 """Set up a new builder thread"""
104 threading.Thread.__init__(self)
105 self.builder = builder
106 self.thread_num = thread_num
Simon Glass6029af12020-04-09 15:08:51 -0600107 self.mrproper = mrproper
Stephen Warren97c96902016-04-11 10:48:44 -0600108 self.per_board_out_dir = per_board_out_dir
Simon Glass9bf9a722021-04-11 16:27:27 +1200109 self.test_exception = test_exception
Simon Glass4a1e88b2014-08-09 15:33:00 -0600110
111 def Make(self, commit, brd, stage, cwd, *args, **kwargs):
112 """Run 'make' on a particular commit and board.
113
114 The source code will already be checked out, so the 'commit'
115 argument is only for information.
116
117 Args:
118 commit: Commit object that is being built
119 brd: Board object that is being built
120 stage: Stage of the build. Valid stages are:
Roger Meiere0a0e552014-08-20 22:10:29 +0200121 mrproper - can be called to clean source
Simon Glass4a1e88b2014-08-09 15:33:00 -0600122 config - called to configure for a board
123 build - the main make invocation - it does the build
124 args: A list of arguments to pass to 'make'
Simon Glass840be732022-01-29 14:14:05 -0700125 kwargs: A list of keyword arguments to pass to command.run_pipe()
Simon Glass4a1e88b2014-08-09 15:33:00 -0600126
127 Returns:
128 CommandResult object
129 """
130 return self.builder.do_make(commit, brd, stage, cwd, *args,
131 **kwargs)
132
Simon Glassb55b57d2016-11-16 14:09:25 -0700133 def RunCommit(self, commit_upto, brd, work_dir, do_config, config_only,
Simon Glasse5650a82022-01-22 05:07:33 -0700134 force_build, force_build_failures, work_in_output,
135 adjust_cfg):
Simon Glass4a1e88b2014-08-09 15:33:00 -0600136 """Build a particular commit.
137
138 If the build is already done, and we are not forcing a build, we skip
139 the build and just return the previously-saved results.
140
141 Args:
142 commit_upto: Commit number to build (0...n-1)
143 brd: Board object to build
144 work_dir: Directory to which the source will be checked out
145 do_config: True to run a make <board>_defconfig on the source
Simon Glassb55b57d2016-11-16 14:09:25 -0700146 config_only: Only configure the source, do not build it
Simon Glass4a1e88b2014-08-09 15:33:00 -0600147 force_build: Force a build even if one was previously done
148 force_build_failures: Force a bulid if the previous result showed
149 failure
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600150 work_in_output: Use the output directory as the work directory and
151 don't write to a separate output directory.
Simon Glasse5650a82022-01-22 05:07:33 -0700152 adjust_cfg (list of str): List of changes to make to .config file
153 before building. Each is one of (where C is either CONFIG_xxx
154 or just xxx):
155 C to enable C
156 ~C to disable C
157 C=val to set the value of C (val must have quotes if C is
158 a string Kconfig
Simon Glass4a1e88b2014-08-09 15:33:00 -0600159
160 Returns:
161 tuple containing:
162 - CommandResult object containing the results of the build
163 - boolean indicating whether 'make config' is still needed
164 """
165 # Create a default result - it will be overwritte by the call to
166 # self.Make() below, in the event that we do a build.
167 result = command.CommandResult()
168 result.return_code = 0
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600169 if work_in_output or self.builder.in_tree:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600170 out_dir = work_dir
171 else:
Stephen Warren97c96902016-04-11 10:48:44 -0600172 if self.per_board_out_dir:
173 out_rel_dir = os.path.join('..', brd.target)
174 else:
175 out_rel_dir = 'build'
176 out_dir = os.path.join(work_dir, out_rel_dir)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600177
178 # Check if the job was already completed last time
179 done_file = self.builder.GetDoneFile(commit_upto, brd.target)
180 result.already_done = os.path.exists(done_file)
181 will_build = (force_build or force_build_failures or
182 not result.already_done)
Simon Glass09f1fe52014-09-05 19:00:17 -0600183 if result.already_done:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600184 # Get the return code from that build and use it
185 with open(done_file, 'r') as fd:
Simon Glass4345a6d2018-12-10 09:05:23 -0700186 try:
187 result.return_code = int(fd.readline())
188 except ValueError:
189 # The file may be empty due to running out of disk space.
190 # Try a rebuild
191 result.return_code = RETURN_CODE_RETRY
Simon Glassfd3eea12015-02-05 22:06:13 -0700192
193 # Check the signal that the build needs to be retried
194 if result.return_code == RETURN_CODE_RETRY:
195 will_build = True
196 elif will_build:
Simon Glass09f1fe52014-09-05 19:00:17 -0600197 err_file = self.builder.GetErrFile(commit_upto, brd.target)
198 if os.path.exists(err_file) and os.stat(err_file).st_size:
199 result.stderr = 'bad'
200 elif not force_build:
201 # The build passed, so no need to build it again
202 will_build = False
Simon Glass4a1e88b2014-08-09 15:33:00 -0600203
204 if will_build:
205 # We are going to have to build it. First, get a toolchain
206 if not self.toolchain:
207 try:
208 self.toolchain = self.builder.toolchains.Select(brd.arch)
209 except ValueError as err:
210 result.return_code = 10
211 result.stdout = ''
212 result.stderr = str(err)
213 # TODO(sjg@chromium.org): This gets swallowed, but needs
214 # to be reported.
215
216 if self.toolchain:
217 # Checkout the right commit
218 if self.builder.commits:
219 commit = self.builder.commits[commit_upto]
220 if self.builder.checkout:
221 git_dir = os.path.join(work_dir, '.git')
Simon Glass761648b2022-01-29 14:14:11 -0700222 gitutil.checkout(commit.hash, git_dir, work_dir,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600223 force=True)
224 else:
225 commit = 'current'
226
227 # Set up the environment and command line
Simon Glassd48a46c2014-12-01 17:34:00 -0700228 env = self.toolchain.MakeEnvironment(self.builder.full_path)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600229 Mkdir(out_dir)
230 args = []
231 cwd = work_dir
Simon Glasse3096252014-08-28 09:43:42 -0600232 src_dir = os.path.realpath(work_dir)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600233 if not self.builder.in_tree:
234 if commit_upto is None:
235 # In this case we are building in the original source
236 # directory (i.e. the current directory where buildman
237 # is invoked. The output directory is set to this
238 # thread's selected work directory.
239 #
240 # Symlinks can confuse U-Boot's Makefile since
241 # we may use '..' in our path, so remove them.
Stephen Warren97c96902016-04-11 10:48:44 -0600242 out_dir = os.path.realpath(out_dir)
243 args.append('O=%s' % out_dir)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600244 cwd = None
Simon Glasse3096252014-08-28 09:43:42 -0600245 src_dir = os.getcwd()
Simon Glass4a1e88b2014-08-09 15:33:00 -0600246 else:
Stephen Warren97c96902016-04-11 10:48:44 -0600247 args.append('O=%s' % out_rel_dir)
Tom Rinif06dd812015-04-01 07:47:41 -0400248 if self.builder.verbose_build:
249 args.append('V=1')
250 else:
Simon Glass655b6102014-12-01 17:34:07 -0700251 args.append('-s')
Simon Glass4a1e88b2014-08-09 15:33:00 -0600252 if self.builder.num_jobs is not None:
253 args.extend(['-j', str(self.builder.num_jobs)])
Daniel Schwierzeck20e2ea92018-01-26 16:31:05 +0100254 if self.builder.warnings_as_errors:
255 args.append('KCFLAGS=-Werror')
Tom Rini93ebd462022-11-09 19:14:53 -0700256 if self.builder.allow_missing:
257 args.append('BINMAN_ALLOW_MISSING=1')
Simon Glass4a1e88b2014-08-09 15:33:00 -0600258 config_args = ['%s_defconfig' % brd.target]
259 config_out = ''
260 args.extend(self.builder.toolchains.GetMakeArguments(brd))
Simon Glassf77ca5b2019-01-07 16:44:20 -0700261 args.extend(self.toolchain.MakeArgs())
Simon Glass4a1e88b2014-08-09 15:33:00 -0600262
Simon Glasse0f19712020-12-16 17:24:17 -0700263 # Remove any output targets. Since we use a build directory that
264 # was previously used by another board, it may have produced an
265 # SPL image. If we don't remove it (i.e. see do_config and
266 # self.mrproper below) then it will appear to be the output of
267 # this build, even if it does not produce SPL images.
268 build_dir = self.builder.GetBuildDir(commit_upto, brd.target)
269 for elf in BASE_ELF_FILENAMES:
270 fname = os.path.join(out_dir, elf)
271 if os.path.exists(fname):
272 os.remove(fname)
273
Simon Glass4a1e88b2014-08-09 15:33:00 -0600274 # If we need to reconfigure, do that now
Simon Glasse5650a82022-01-22 05:07:33 -0700275 cfg_file = os.path.join(out_dir, '.config')
276 if do_config or adjust_cfg:
Stephen Warren97c96902016-04-11 10:48:44 -0600277 config_out = ''
Simon Glass6029af12020-04-09 15:08:51 -0600278 if self.mrproper:
Stephen Warren97c96902016-04-11 10:48:44 -0600279 result = self.Make(commit, brd, 'mrproper', cwd,
280 'mrproper', *args, env=env)
281 config_out += result.combined
Simon Glass4a1e88b2014-08-09 15:33:00 -0600282 result = self.Make(commit, brd, 'config', cwd,
283 *(args + config_args), env=env)
Simon Glass413f91a2015-02-05 22:06:12 -0700284 config_out += result.combined
Simon Glass4a1e88b2014-08-09 15:33:00 -0600285 do_config = False # No need to configure next time
Simon Glasse5650a82022-01-22 05:07:33 -0700286 if adjust_cfg:
287 cfgutil.adjust_cfg_file(cfg_file, adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600288 if result.return_code == 0:
Simon Glassb55b57d2016-11-16 14:09:25 -0700289 if config_only:
Simon Glass739e8512016-11-13 14:25:51 -0700290 args.append('cfg')
Simon Glass4a1e88b2014-08-09 15:33:00 -0600291 result = self.Make(commit, brd, 'build', cwd, *args,
292 env=env)
Simon Glass199da412022-11-09 19:14:48 -0700293 if (result.return_code == 2 and
294 ('Some images are invalid' in result.stderr)):
295 # This is handled later by the check for output in
296 # stderr
297 result.return_code = 0
Simon Glasse5650a82022-01-22 05:07:33 -0700298 if adjust_cfg:
299 errs = cfgutil.check_cfg_file(cfg_file, adjust_cfg)
300 if errs:
Simon Glasse5650a82022-01-22 05:07:33 -0700301 result.stderr += errs
302 result.return_code = 1
Simon Glasse3096252014-08-28 09:43:42 -0600303 result.stderr = result.stderr.replace(src_dir + '/', '')
Simon Glass413f91a2015-02-05 22:06:12 -0700304 if self.builder.verbose_build:
305 result.stdout = config_out + result.stdout
Simon Glass4a1e88b2014-08-09 15:33:00 -0600306 else:
307 result.return_code = 1
308 result.stderr = 'No tool chain for %s\n' % brd.arch
309 result.already_done = False
310
311 result.toolchain = self.toolchain
312 result.brd = brd
313 result.commit_upto = commit_upto
314 result.out_dir = out_dir
315 return result, do_config
316
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600317 def _WriteResult(self, result, keep_outputs, work_in_output):
Simon Glass4a1e88b2014-08-09 15:33:00 -0600318 """Write a built result to the output directory.
319
320 Args:
321 result: CommandResult object containing result to write
322 keep_outputs: True to store the output binaries, False
323 to delete them
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600324 work_in_output: Use the output directory as the work directory and
325 don't write to a separate output directory.
Simon Glass4a1e88b2014-08-09 15:33:00 -0600326 """
Simon Glassfd3eea12015-02-05 22:06:13 -0700327 # If we think this might have been aborted with Ctrl-C, record the
328 # failure but not that we are 'done' with this board. A retry may fix
329 # it.
Simon Glass2e737452021-10-19 21:43:23 -0600330 maybe_aborted = result.stderr and 'No child processes' in result.stderr
Simon Glass4a1e88b2014-08-09 15:33:00 -0600331
Simon Glass2e737452021-10-19 21:43:23 -0600332 if result.return_code >= 0 and result.already_done:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600333 return
334
335 # Write the output and stderr
336 output_dir = self.builder._GetOutputDir(result.commit_upto)
337 Mkdir(output_dir)
338 build_dir = self.builder.GetBuildDir(result.commit_upto,
339 result.brd.target)
340 Mkdir(build_dir)
341
342 outfile = os.path.join(build_dir, 'log')
343 with open(outfile, 'w') as fd:
344 if result.stdout:
Simon Glassc78ed662019-10-31 07:42:53 -0600345 fd.write(result.stdout)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600346
347 errfile = self.builder.GetErrFile(result.commit_upto,
348 result.brd.target)
349 if result.stderr:
350 with open(errfile, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600351 fd.write(result.stderr)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600352 elif os.path.exists(errfile):
353 os.remove(errfile)
354
Simon Glass2e737452021-10-19 21:43:23 -0600355 # Fatal error
356 if result.return_code < 0:
357 return
358
Simon Glass4a1e88b2014-08-09 15:33:00 -0600359 if result.toolchain:
360 # Write the build result and toolchain information.
361 done_file = self.builder.GetDoneFile(result.commit_upto,
362 result.brd.target)
363 with open(done_file, 'w') as fd:
Simon Glassfd3eea12015-02-05 22:06:13 -0700364 if maybe_aborted:
365 # Special code to indicate we need to retry
366 fd.write('%s' % RETURN_CODE_RETRY)
367 else:
368 fd.write('%s' % result.return_code)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600369 with open(os.path.join(build_dir, 'toolchain'), 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600370 print('gcc', result.toolchain.gcc, file=fd)
371 print('path', result.toolchain.path, file=fd)
372 print('cross', result.toolchain.cross, file=fd)
373 print('arch', result.toolchain.arch, file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600374 fd.write('%s' % result.return_code)
375
Simon Glass4a1e88b2014-08-09 15:33:00 -0600376 # Write out the image and function size information and an objdump
Simon Glassd48a46c2014-12-01 17:34:00 -0700377 env = result.toolchain.MakeEnvironment(self.builder.full_path)
Simon Glass93008e22021-04-11 16:27:28 +1200378 with open(os.path.join(build_dir, 'out-env'), 'wb') as fd:
Simon Glass9e90d312019-01-07 16:44:23 -0700379 for var in sorted(env.keys()):
Simon Glass93008e22021-04-11 16:27:28 +1200380 fd.write(b'%s="%s"' % (var, env[var]))
Simon Glass4a1e88b2014-08-09 15:33:00 -0600381 lines = []
Simon Glasse0f19712020-12-16 17:24:17 -0700382 for fname in BASE_ELF_FILENAMES:
Simon Glass4a1e88b2014-08-09 15:33:00 -0600383 cmd = ['%snm' % self.toolchain.cross, '--size-sort', fname]
Simon Glass840be732022-01-29 14:14:05 -0700384 nm_result = command.run_pipe([cmd], capture=True,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600385 capture_stderr=True, cwd=result.out_dir,
386 raise_on_error=False, env=env)
387 if nm_result.stdout:
388 nm = self.builder.GetFuncSizesFile(result.commit_upto,
389 result.brd.target, fname)
390 with open(nm, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600391 print(nm_result.stdout, end=' ', file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600392
393 cmd = ['%sobjdump' % self.toolchain.cross, '-h', fname]
Simon Glass840be732022-01-29 14:14:05 -0700394 dump_result = command.run_pipe([cmd], capture=True,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600395 capture_stderr=True, cwd=result.out_dir,
396 raise_on_error=False, env=env)
397 rodata_size = ''
398 if dump_result.stdout:
399 objdump = self.builder.GetObjdumpFile(result.commit_upto,
400 result.brd.target, fname)
401 with open(objdump, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600402 print(dump_result.stdout, end=' ', file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600403 for line in dump_result.stdout.splitlines():
404 fields = line.split()
405 if len(fields) > 5 and fields[1] == '.rodata':
406 rodata_size = fields[2]
407
408 cmd = ['%ssize' % self.toolchain.cross, fname]
Simon Glass840be732022-01-29 14:14:05 -0700409 size_result = command.run_pipe([cmd], capture=True,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600410 capture_stderr=True, cwd=result.out_dir,
411 raise_on_error=False, env=env)
412 if size_result.stdout:
413 lines.append(size_result.stdout.splitlines()[1] + ' ' +
414 rodata_size)
415
Alex Kiernanf07ed232018-05-31 04:48:33 +0000416 # Extract the environment from U-Boot and dump it out
417 cmd = ['%sobjcopy' % self.toolchain.cross, '-O', 'binary',
418 '-j', '.rodata.default_environment',
419 'env/built-in.o', 'uboot.env']
Simon Glass840be732022-01-29 14:14:05 -0700420 command.run_pipe([cmd], capture=True,
Alex Kiernanf07ed232018-05-31 04:48:33 +0000421 capture_stderr=True, cwd=result.out_dir,
422 raise_on_error=False, env=env)
423 ubootenv = os.path.join(result.out_dir, 'uboot.env')
Simon Glasse3c85ab2020-04-17 17:51:34 -0600424 if not work_in_output:
425 self.CopyFiles(result.out_dir, build_dir, '', ['uboot.env'])
Alex Kiernanf07ed232018-05-31 04:48:33 +0000426
Simon Glass4a1e88b2014-08-09 15:33:00 -0600427 # Write out the image sizes file. This is similar to the output
428 # of binutil's 'size' utility, but it omits the header line and
429 # adds an additional hex value at the end of each line for the
430 # rodata size
431 if len(lines):
432 sizes = self.builder.GetSizesFile(result.commit_upto,
433 result.brd.target)
434 with open(sizes, 'w') as fd:
Simon Glassc78ed662019-10-31 07:42:53 -0600435 print('\n'.join(lines), file=fd)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600436
Simon Glasse3c85ab2020-04-17 17:51:34 -0600437 if not work_in_output:
438 # Write out the configuration files, with a special case for SPL
439 for dirname in ['', 'spl', 'tpl']:
440 self.CopyFiles(
441 result.out_dir, build_dir, dirname,
442 ['u-boot.cfg', 'spl/u-boot-spl.cfg', 'tpl/u-boot-tpl.cfg',
443 '.config', 'include/autoconf.mk',
444 'include/generated/autoconf.h'])
Simon Glass4b14c532015-02-05 22:06:14 -0700445
Simon Glasse3c85ab2020-04-17 17:51:34 -0600446 # Now write the actual build output
447 if keep_outputs:
448 self.CopyFiles(
449 result.out_dir, build_dir, '',
450 ['u-boot*', '*.bin', '*.map', '*.img', 'MLO', 'SPL',
451 'include/autoconf.mk', 'spl/u-boot-spl*'])
Simon Glass4b14c532015-02-05 22:06:14 -0700452
453 def CopyFiles(self, out_dir, build_dir, dirname, patterns):
454 """Copy files from the build directory to the output.
Simon Glass4a1e88b2014-08-09 15:33:00 -0600455
Simon Glass4b14c532015-02-05 22:06:14 -0700456 Args:
457 out_dir: Path to output directory containing the files
458 build_dir: Place to copy the files
459 dirname: Source directory, '' for normal U-Boot, 'spl' for SPL
460 patterns: A list of filenames (strings) to copy, each relative
461 to the build directory
462 """
463 for pattern in patterns:
464 file_list = glob.glob(os.path.join(out_dir, dirname, pattern))
465 for fname in file_list:
466 target = os.path.basename(fname)
467 if dirname:
468 base, ext = os.path.splitext(target)
469 if ext:
470 target = '%s-%s%s' % (base, dirname, ext)
471 shutil.copy(fname, os.path.join(build_dir, target))
Simon Glass4a1e88b2014-08-09 15:33:00 -0600472
Simon Glassa3d01442021-04-11 16:27:26 +1200473 def _SendResult(self, result):
474 """Send a result to the builder for processing
475
476 Args:
477 result: CommandResult object containing the results of the build
Simon Glass9bf9a722021-04-11 16:27:27 +1200478
479 Raises:
480 ValueError if self.test_exception is true (for testing)
Simon Glassa3d01442021-04-11 16:27:26 +1200481 """
Simon Glass9bf9a722021-04-11 16:27:27 +1200482 if self.test_exception:
483 raise ValueError('test exception')
Simon Glassa3d01442021-04-11 16:27:26 +1200484 if self.thread_num != -1:
485 self.builder.out_queue.put(result)
486 else:
487 self.builder.ProcessResult(result)
488
Simon Glass4a1e88b2014-08-09 15:33:00 -0600489 def RunJob(self, job):
490 """Run a single job
491
492 A job consists of a building a list of commits for a particular board.
493
494 Args:
495 job: Job to build
Simon Glassc635d892021-01-30 22:17:46 -0700496
497 Returns:
498 List of Result objects
Simon Glass4a1e88b2014-08-09 15:33:00 -0600499 """
Simon Glass8132f982022-07-11 19:03:57 -0600500 brd = job.brd
Simon Glass4a1e88b2014-08-09 15:33:00 -0600501 work_dir = self.builder.GetThreadDir(self.thread_num)
502 self.toolchain = None
503 if job.commits:
504 # Run 'make board_defconfig' on the first commit
505 do_config = True
506 commit_upto = 0
507 force_build = False
508 for commit_upto in range(0, len(job.commits), job.step):
509 result, request_config = self.RunCommit(commit_upto, brd,
Simon Glassb55b57d2016-11-16 14:09:25 -0700510 work_dir, do_config, self.builder.config_only,
Simon Glass4a1e88b2014-08-09 15:33:00 -0600511 force_build or self.builder.force_build,
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600512 self.builder.force_build_failures,
Simon Glasse5650a82022-01-22 05:07:33 -0700513 job.work_in_output, job.adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600514 failed = result.return_code or result.stderr
515 did_config = do_config
516 if failed and not do_config:
517 # If our incremental build failed, try building again
518 # with a reconfig.
519 if self.builder.force_config_on_failure:
520 result, request_config = self.RunCommit(commit_upto,
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600521 brd, work_dir, True, False, True, False,
Simon Glasse5650a82022-01-22 05:07:33 -0700522 job.work_in_output, job.adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600523 did_config = True
524 if not self.builder.force_reconfig:
525 do_config = request_config
526
527 # If we built that commit, then config is done. But if we got
528 # an warning, reconfig next time to force it to build the same
529 # files that created warnings this time. Otherwise an
530 # incremental build may not build the same file, and we will
531 # think that the warning has gone away.
532 # We could avoid this by using -Werror everywhere...
533 # For errors, the problem doesn't happen, since presumably
534 # the build stopped and didn't generate output, so will retry
535 # that file next time. So we could detect warnings and deal
536 # with them specially here. For now, we just reconfigure if
537 # anything goes work.
538 # Of course this is substantially slower if there are build
539 # errors/warnings (e.g. 2-3x slower even if only 10% of builds
540 # have problems).
541 if (failed and not result.already_done and not did_config and
542 self.builder.force_config_on_failure):
543 # If this build failed, try the next one with a
544 # reconfigure.
545 # Sometimes if the board_config.h file changes it can mess
546 # with dependencies, and we get:
547 # make: *** No rule to make target `include/autoconf.mk',
548 # needed by `depend'.
549 do_config = True
550 force_build = True
551 else:
552 force_build = False
553 if self.builder.force_config_on_failure:
554 if failed:
555 do_config = True
556 result.commit_upto = commit_upto
557 if result.return_code < 0:
558 raise ValueError('Interrupt')
559
560 # We have the build results, so output the result
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600561 self._WriteResult(result, job.keep_outputs, job.work_in_output)
Simon Glassa3d01442021-04-11 16:27:26 +1200562 self._SendResult(result)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600563 else:
564 # Just build the currently checked-out build
565 result, request_config = self.RunCommit(None, brd, work_dir, True,
Simon Glassb55b57d2016-11-16 14:09:25 -0700566 self.builder.config_only, True,
Simon Glasse5650a82022-01-22 05:07:33 -0700567 self.builder.force_build_failures, job.work_in_output,
568 job.adjust_cfg)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600569 result.commit_upto = 0
Simon Glassb6eb8cf2020-03-18 09:42:42 -0600570 self._WriteResult(result, job.keep_outputs, job.work_in_output)
Simon Glassa3d01442021-04-11 16:27:26 +1200571 self._SendResult(result)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600572
573 def run(self):
574 """Our thread's run function
575
576 This thread picks a job from the queue, runs it, and then goes to the
577 next job.
578 """
Simon Glass4a1e88b2014-08-09 15:33:00 -0600579 while True:
580 job = self.builder.queue.get()
Simon Glass9bf9a722021-04-11 16:27:27 +1200581 try:
582 self.RunJob(job)
583 except Exception as e:
Simon Glass9bac1672022-01-22 05:07:32 -0700584 print('Thread exception (use -T0 to run without threads):', e)
Simon Glass9bf9a722021-04-11 16:27:27 +1200585 self.builder.thread_exceptions.append(e)
Simon Glass4a1e88b2014-08-09 15:33:00 -0600586 self.builder.queue.task_done()