blob: 3ec33e022d0c37456b4146022a1e78236e3567a1 [file] [log] [blame]
Tom Rini10e47792018-05-06 17:58:06 -04001# SPDX-License-Identifier: GPL-2.0+
Simon Glass26132882012-01-14 15:12:45 +00002# Copyright (c) 2011 The Chromium OS Authors.
3#
Simon Glass26132882012-01-14 15:12:45 +00004
Sean Anderson48f46d62020-05-04 16:28:34 -04005from __future__ import print_function
6
7import collections
Simon Glass620639c2023-03-08 10:52:54 -08008import concurrent.futures
Doug Anderson05416af2012-12-03 14:40:43 +00009import itertools
Simon Glass26132882012-01-14 15:12:45 +000010import os
Simon Glass620639c2023-03-08 10:52:54 -080011import sys
12import time
Simon Glass26132882012-01-14 15:12:45 +000013
Simon Glassa997ea52020-04-17 18:09:04 -060014from patman import get_maintainer
Simon Glassa997ea52020-04-17 18:09:04 -060015from patman import settings
Simon Glassba1b3b92025-02-09 14:26:00 -070016from u_boot_pylib import gitutil
Simon Glass131444f2023-02-23 18:18:04 -070017from u_boot_pylib import terminal
18from u_boot_pylib import tools
Simon Glass26132882012-01-14 15:12:45 +000019
20# Series-xxx tags that we understand
Simon Glassc72f3da2013-03-20 16:43:00 +000021valid_series = ['to', 'cc', 'version', 'changes', 'prefix', 'notes', 'name',
Sean Andersondc1cd132021-10-22 19:07:04 -040022 'cover_cc', 'process_log', 'links', 'patchwork_url', 'postfix']
Simon Glass26132882012-01-14 15:12:45 +000023
24class Series(dict):
25 """Holds information about a patch series, including all tags.
26
27 Vars:
28 cc: List of aliases/emails to Cc all patches to
29 commits: List of Commit objects, one for each patch
30 cover: List of lines in the cover letter
31 notes: List of lines in the notes
32 changes: (dict) List of changes for each version, The key is
33 the integer version number
Simon Glass29c5abc2013-05-02 14:46:02 +000034 allow_overwrite: Allow tags to overwrite an existing tag
Simon Glass26132882012-01-14 15:12:45 +000035 """
36 def __init__(self):
37 self.cc = []
38 self.to = []
Simon Glassc72f3da2013-03-20 16:43:00 +000039 self.cover_cc = []
Simon Glass26132882012-01-14 15:12:45 +000040 self.commits = []
41 self.cover = None
42 self.notes = []
43 self.changes = {}
Simon Glass29c5abc2013-05-02 14:46:02 +000044 self.allow_overwrite = False
Simon Glass414f1e02025-02-27 12:27:30 -070045 self.base_commit = None
46 self.branch = None
Simon Glass26132882012-01-14 15:12:45 +000047
Doug Anderson507e8e82012-12-03 14:40:42 +000048 # Written in MakeCcFile()
49 # key: name of patch file
50 # value: list of email addresses
51 self._generated_cc = {}
52
Simon Glass26132882012-01-14 15:12:45 +000053 # These make us more like a dictionary
54 def __setattr__(self, name, value):
55 self[name] = value
56
57 def __getattr__(self, name):
58 return self[name]
59
60 def AddTag(self, commit, line, name, value):
61 """Add a new Series-xxx tag along with its value.
62
63 Args:
64 line: Source line containing tag (useful for debug/error messages)
65 name: Tag name (part after 'Series-')
66 value: Tag value (part after 'Series-xxx: ')
Simon Glass8093a8f2020-10-29 21:46:25 -060067
68 Returns:
69 String warning if something went wrong, else None
Simon Glass26132882012-01-14 15:12:45 +000070 """
71 # If we already have it, then add to our list
Simon Glassc72f3da2013-03-20 16:43:00 +000072 name = name.replace('-', '_')
Simon Glass29c5abc2013-05-02 14:46:02 +000073 if name in self and not self.allow_overwrite:
Simon Glass26132882012-01-14 15:12:45 +000074 values = value.split(',')
75 values = [str.strip() for str in values]
76 if type(self[name]) != type([]):
77 raise ValueError("In %s: line '%s': Cannot add another value "
78 "'%s' to series '%s'" %
79 (commit.hash, line, values, self[name]))
80 self[name] += values
81
82 # Otherwise just set the value
83 elif name in valid_series:
Albert ARIBAUD77ec8bc2016-02-02 10:24:53 +010084 if name=="notes":
85 self[name] = [value]
86 else:
87 self[name] = value
Simon Glass26132882012-01-14 15:12:45 +000088 else:
Simon Glass8093a8f2020-10-29 21:46:25 -060089 return ("In %s: line '%s': Unknown 'Series-%s': valid "
Simon Glasse7ecd3f2012-09-27 15:06:02 +000090 "options are %s" % (commit.hash, line, name,
Simon Glass26132882012-01-14 15:12:45 +000091 ', '.join(valid_series)))
Simon Glass8093a8f2020-10-29 21:46:25 -060092 return None
Simon Glass26132882012-01-14 15:12:45 +000093
94 def AddCommit(self, commit):
95 """Add a commit into our list of commits
96
97 We create a list of tags in the commit subject also.
98
99 Args:
100 commit: Commit object to add
101 """
Simon Glass530ac272022-01-29 14:14:07 -0700102 commit.check_tags()
Simon Glass26132882012-01-14 15:12:45 +0000103 self.commits.append(commit)
104
Simon Glass32f12a7e2025-04-07 22:51:47 +1200105 def ShowActions(self, args, cmd, process_tags, alias):
Simon Glass26132882012-01-14 15:12:45 +0000106 """Show what actions we will/would perform
107
108 Args:
109 args: List of patch files we created
110 cmd: The git command we would have run
111 process_tags: Process tags as if they were aliases
Simon Glass32f12a7e2025-04-07 22:51:47 +1200112 alias (dict): Alias dictionary
113 key: alias
114 value: list of aliases or email addresses
Simon Glass26132882012-01-14 15:12:45 +0000115 """
Simon Glass32f12a7e2025-04-07 22:51:47 +1200116 to_set = set(gitutil.build_email_list(self.to, alias));
117 cc_set = set(gitutil.build_email_list(self.cc, alias));
Peter Tyserc6af8022015-01-26 11:42:21 -0600118
Simon Glass26132882012-01-14 15:12:45 +0000119 col = terminal.Color()
Paul Burtonc3931342016-09-27 16:03:50 +0100120 print('Dry run, so not doing much. But I would do this:')
121 print()
122 print('Send a total of %d patch%s with %scover letter.' % (
Simon Glass26132882012-01-14 15:12:45 +0000123 len(args), '' if len(args) == 1 else 'es',
Paul Burtonc3931342016-09-27 16:03:50 +0100124 self.get('cover') and 'a ' or 'no '))
Simon Glass26132882012-01-14 15:12:45 +0000125
126 # TODO: Colour the patches according to whether they passed checks
127 for upto in range(len(args)):
128 commit = self.commits[upto]
Simon Glassf45d3742022-01-29 14:14:17 -0700129 print(col.build(col.GREEN, ' %s' % args[upto]))
Doug Anderson507e8e82012-12-03 14:40:42 +0000130 cc_list = list(self._generated_cc[commit.patch])
Simon Glass3ab178f2019-05-14 15:53:51 -0600131 for email in sorted(set(cc_list) - to_set - cc_set):
Simon Glass26132882012-01-14 15:12:45 +0000132 if email == None:
Simon Glass547cba62022-02-11 13:23:18 -0700133 email = col.build(col.YELLOW, '<alias not found>')
Simon Glass26132882012-01-14 15:12:45 +0000134 if email:
Simon Glass22c58342017-05-29 15:31:23 -0600135 print(' Cc: ', email)
Simon Glass26132882012-01-14 15:12:45 +0000136 print
Simon Glass3ab178f2019-05-14 15:53:51 -0600137 for item in sorted(to_set):
Paul Burtonc3931342016-09-27 16:03:50 +0100138 print('To:\t ', item)
Simon Glass3ab178f2019-05-14 15:53:51 -0600139 for item in sorted(cc_set - to_set):
Paul Burtonc3931342016-09-27 16:03:50 +0100140 print('Cc:\t ', item)
141 print('Version: ', self.get('version'))
142 print('Prefix:\t ', self.get('prefix'))
Sean Andersondc1cd132021-10-22 19:07:04 -0400143 print('Postfix:\t ', self.get('postfix'))
Simon Glass26132882012-01-14 15:12:45 +0000144 if self.cover:
Paul Burtonc3931342016-09-27 16:03:50 +0100145 print('Cover: %d lines' % len(self.cover))
Simon Glassdea1ddf2025-04-07 22:51:44 +1200146 cover_cc = gitutil.build_email_list(self.get('cover_cc', ''),
Simon Glass32f12a7e2025-04-07 22:51:47 +1200147 alias)
Simon Glassc72f3da2013-03-20 16:43:00 +0000148 all_ccs = itertools.chain(cover_cc, *self._generated_cc.values())
Simon Glass3ab178f2019-05-14 15:53:51 -0600149 for email in sorted(set(all_ccs) - to_set - cc_set):
Paul Burtonc3931342016-09-27 16:03:50 +0100150 print(' Cc: ', email)
Simon Glass26132882012-01-14 15:12:45 +0000151 if cmd:
Paul Burtonc3931342016-09-27 16:03:50 +0100152 print('Git command: %s' % cmd)
Simon Glass26132882012-01-14 15:12:45 +0000153
154 def MakeChangeLog(self, commit):
155 """Create a list of changes for each version.
156
157 Return:
158 The change log as a list of strings, one per line
159
Simon Glassaa912af2012-10-30 06:15:16 +0000160 Changes in v4:
Otavio Salvadorcc1fbaa2012-08-18 07:46:04 +0000161 - Jog the dial back closer to the widget
162
Simon Glassaa912af2012-10-30 06:15:16 +0000163 Changes in v2:
Simon Glass26132882012-01-14 15:12:45 +0000164 - Fix the widget
165 - Jog the dial
166
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400167 If there are no new changes in a patch, a note will be added
168
169 (no changes since v2)
170
171 Changes in v2:
172 - Fix the widget
173 - Jog the dial
Simon Glass26132882012-01-14 15:12:45 +0000174 """
Sean Anderson48f46d62020-05-04 16:28:34 -0400175 # Collect changes from the series and this commit
176 changes = collections.defaultdict(list)
177 for version, changelist in self.changes.items():
178 changes[version] += changelist
179 if commit:
180 for version, changelist in commit.changes.items():
181 changes[version] += [[commit, text] for text in changelist]
182
183 versions = sorted(changes, reverse=True)
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400184 newest_version = 1
185 if 'version' in self:
186 newest_version = max(newest_version, int(self.version))
187 if versions:
188 newest_version = max(newest_version, versions[0])
189
Simon Glass26132882012-01-14 15:12:45 +0000190 final = []
Simon Glassec1d0422013-03-26 13:09:44 +0000191 process_it = self.get('process_log', '').split(',')
192 process_it = [item.strip() for item in process_it]
Simon Glass26132882012-01-14 15:12:45 +0000193 need_blank = False
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400194 for version in versions:
Simon Glass26132882012-01-14 15:12:45 +0000195 out = []
Sean Anderson48f46d62020-05-04 16:28:34 -0400196 for this_commit, text in changes[version]:
Simon Glass26132882012-01-14 15:12:45 +0000197 if commit and this_commit != commit:
198 continue
Simon Glassec1d0422013-03-26 13:09:44 +0000199 if 'uniq' not in process_it or text not in out:
200 out.append(text)
Simon Glassec1d0422013-03-26 13:09:44 +0000201 if 'sort' in process_it:
202 out = sorted(out)
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400203 have_changes = len(out) > 0
204 line = 'Changes in v%d:' % version
Simon Glassaa912af2012-10-30 06:15:16 +0000205 if have_changes:
206 out.insert(0, line)
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400207 if version < newest_version and len(final) == 0:
208 out.insert(0, '')
209 out.insert(0, '(no changes since v%d)' % version)
210 newest_version = 0
211 # Only add a new line if we output something
212 if need_blank:
213 out.insert(0, '')
214 need_blank = False
Simon Glassaa912af2012-10-30 06:15:16 +0000215 final += out
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400216 need_blank = need_blank or have_changes
217
218 if len(final) > 0:
Simon Glass26132882012-01-14 15:12:45 +0000219 final.append('')
Sean Anderson5ae4e8d2020-05-04 16:28:33 -0400220 elif newest_version != 1:
221 final = ['(no changes since v1)', '']
Simon Glass26132882012-01-14 15:12:45 +0000222 return final
223
224 def DoChecks(self):
225 """Check that each version has a change log
226
227 Print an error if something is wrong.
228 """
229 col = terminal.Color()
230 if self.get('version'):
231 changes_copy = dict(self.changes)
Otavio Salvadorfe07d072012-08-13 10:08:22 +0000232 for version in range(1, int(self.version) + 1):
Simon Glass26132882012-01-14 15:12:45 +0000233 if self.changes.get(version):
234 del changes_copy[version]
235 else:
Otavio Salvadorfe07d072012-08-13 10:08:22 +0000236 if version > 1:
237 str = 'Change log missing for v%d' % version
Simon Glassf45d3742022-01-29 14:14:17 -0700238 print(col.build(col.RED, str))
Simon Glass26132882012-01-14 15:12:45 +0000239 for version in changes_copy:
240 str = 'Change log for unknown version v%d' % version
Simon Glassf45d3742022-01-29 14:14:17 -0700241 print(col.build(col.RED, str))
Simon Glass26132882012-01-14 15:12:45 +0000242 elif self.changes:
243 str = 'Change log exists, but no version is set'
Simon Glassf45d3742022-01-29 14:14:17 -0700244 print(col.build(col.RED, str))
Simon Glass26132882012-01-14 15:12:45 +0000245
Simon Glass77f57df2023-03-08 10:52:53 -0800246 def GetCcForCommit(self, commit, process_tags, warn_on_error,
247 add_maintainers, limit, get_maintainer_script,
Simon Glass9938b7b2025-04-07 22:51:46 +1200248 all_skips, alias):
Simon Glass77f57df2023-03-08 10:52:53 -0800249 """Get the email CCs to use with a particular commit
250
251 Uses subject tags and get_maintainers.pl script to find people to cc
252 on a patch
253
254 Args:
255 commit (Commit): Commit to process
256 process_tags (bool): Process tags as if they were aliases
257 warn_on_error (bool): True to print a warning when an alias fails to
258 match, False to ignore it.
259 add_maintainers (bool or list of str): Either:
260 True/False to call the get_maintainers to CC maintainers
261 List of maintainers to include (for testing)
262 limit (int): Limit the length of the Cc list (None if no limit)
263 get_maintainer_script (str): The file name of the get_maintainer.pl
264 script (or compatible).
265 all_skips (set of str): Updated to include the set of bouncing email
266 addresses that were dropped from the output. This is essentially
267 a return value from this function.
Simon Glass9938b7b2025-04-07 22:51:46 +1200268 alias (dict): Alias dictionary
269 key: alias
270 value: list of aliases or email addresses
Simon Glass77f57df2023-03-08 10:52:53 -0800271
272 Returns:
273 list of str: List of email addresses to cc
274 """
275 cc = []
276 if process_tags:
Simon Glass32f12a7e2025-04-07 22:51:47 +1200277 cc += gitutil.build_email_list(commit.tags, alias,
Simon Glass77f57df2023-03-08 10:52:53 -0800278 warn_on_error=warn_on_error)
Simon Glass32f12a7e2025-04-07 22:51:47 +1200279 cc += gitutil.build_email_list(commit.cc_list, alias,
Simon Glass77f57df2023-03-08 10:52:53 -0800280 warn_on_error=warn_on_error)
281 if type(add_maintainers) == type(cc):
282 cc += add_maintainers
283 elif add_maintainers:
284 cc += get_maintainer.get_maintainer(get_maintainer_script,
285 commit.patch)
286 all_skips |= set(cc) & set(settings.bounces)
287 cc = list(set(cc) - set(settings.bounces))
288 if limit is not None:
289 cc = cc[:limit]
290 return cc
291
Simon Glass1f975b92021-01-23 08:56:15 -0700292 def MakeCcFile(self, process_tags, cover_fname, warn_on_error,
Simon Glass9938b7b2025-04-07 22:51:46 +1200293 add_maintainers, limit, get_maintainer_script, alias):
Simon Glass26132882012-01-14 15:12:45 +0000294 """Make a cc file for us to use for per-commit Cc automation
295
Doug Anderson507e8e82012-12-03 14:40:42 +0000296 Also stores in self._generated_cc to make ShowActions() faster.
297
Simon Glass26132882012-01-14 15:12:45 +0000298 Args:
Simon Glass77f57df2023-03-08 10:52:53 -0800299 process_tags (bool): Process tags as if they were aliases
300 cover_fname (str): If non-None the name of the cover letter.
301 warn_on_error (bool): True to print a warning when an alias fails to
302 match, False to ignore it.
303 add_maintainers (bool or list of str): Either:
Simon Glassb712eed2017-05-29 15:31:29 -0600304 True/False to call the get_maintainers to CC maintainers
305 List of maintainers to include (for testing)
Simon Glass77f57df2023-03-08 10:52:53 -0800306 limit (int): Limit the length of the Cc list (None if no limit)
307 get_maintainer_script (str): The file name of the get_maintainer.pl
Maxim Cournoyer3ef23e92022-12-20 00:28:46 -0500308 script (or compatible).
Simon Glass9938b7b2025-04-07 22:51:46 +1200309 alias (dict): Alias dictionary
310 key: alias
311 value: list of aliases or email addresses
Simon Glass26132882012-01-14 15:12:45 +0000312 Return:
313 Filename of temp file created
314 """
Chris Packhame8d2a122017-09-01 20:57:53 +1200315 col = terminal.Color()
Simon Glass26132882012-01-14 15:12:45 +0000316 # Look for commit tags (of the form 'xxx:' at the start of the subject)
317 fname = '/tmp/patman.%d' % os.getpid()
Simon Glassf544a2d2019-10-31 07:42:51 -0600318 fd = open(fname, 'w', encoding='utf-8')
Doug Anderson05416af2012-12-03 14:40:43 +0000319 all_ccs = []
Simon Glass77f57df2023-03-08 10:52:53 -0800320 all_skips = set()
Simon Glass620639c2023-03-08 10:52:54 -0800321 with concurrent.futures.ThreadPoolExecutor(max_workers=16) as executor:
322 for i, commit in enumerate(self.commits):
323 commit.seq = i
324 commit.future = executor.submit(
325 self.GetCcForCommit, commit, process_tags, warn_on_error,
Simon Glass9938b7b2025-04-07 22:51:46 +1200326 add_maintainers, limit, get_maintainer_script, all_skips,
327 alias)
Simon Glass620639c2023-03-08 10:52:54 -0800328
329 # Show progress any commits that are taking forever
330 lastlen = 0
331 while True:
332 left = [commit for commit in self.commits
333 if not commit.future.done()]
334 if not left:
335 break
336 names = ', '.join(f'{c.seq + 1}:{c.subject}'
337 for c in left[:2])
338 out = f'\r{len(left)} remaining: {names}'[:79]
339 spaces = ' ' * (lastlen - len(out))
340 if lastlen: # Don't print anything the first time
341 print(out, spaces, end='')
342 sys.stdout.flush()
343 lastlen = len(out)
344 time.sleep(.25)
345 print(f'\rdone{" " * lastlen}\r', end='')
346 print('Cc processing complete')
347
Simon Glass26132882012-01-14 15:12:45 +0000348 for commit in self.commits:
Simon Glass620639c2023-03-08 10:52:54 -0800349 cc = commit.future.result()
Simon Glass0f94fa72017-05-29 15:31:30 -0600350 all_ccs += cc
Dmitry Torokhovef7f67d2019-10-21 20:09:56 -0700351 print(commit.patch, '\0'.join(sorted(set(cc))), file=fd)
Simon Glass0f94fa72017-05-29 15:31:30 -0600352 self._generated_cc[commit.patch] = cc
Simon Glass26132882012-01-14 15:12:45 +0000353
Simon Glass77f57df2023-03-08 10:52:53 -0800354 for x in sorted(all_skips):
355 print(col.build(col.YELLOW, f'Skipping "{x}"'))
356
Doug Anderson05416af2012-12-03 14:40:43 +0000357 if cover_fname:
Simon Glassdea1ddf2025-04-07 22:51:44 +1200358 cover_cc = gitutil.build_email_list(
Simon Glass32f12a7e2025-04-07 22:51:47 +1200359 self.get('cover_cc', ''), alias)
Simon Glass39ed6bb2020-02-27 18:49:23 -0700360 cover_cc = list(set(cover_cc + all_ccs))
361 if limit is not None:
362 cover_cc = cover_cc[:limit]
Simon Glass9dfb3112020-11-08 20:36:18 -0700363 cc_list = '\0'.join([x for x in sorted(cover_cc)])
Robert Beckett3356f2c2019-11-13 18:39:45 +0000364 print(cover_fname, cc_list, file=fd)
Doug Anderson05416af2012-12-03 14:40:43 +0000365
Simon Glass26132882012-01-14 15:12:45 +0000366 fd.close()
367 return fname
368
369 def AddChange(self, version, commit, info):
370 """Add a new change line to a version.
371
372 This will later appear in the change log.
373
374 Args:
375 version: version number to add change list to
376 info: change line for this version
377 """
378 if not self.changes.get(version):
379 self.changes[version] = []
380 self.changes[version].append([commit, info])
381
382 def GetPatchPrefix(self):
383 """Get the patch version string
384
385 Return:
386 Patch string, like 'RFC PATCH v5' or just 'PATCH'
387 """
Simon Glass761648b2022-01-29 14:14:11 -0700388 git_prefix = gitutil.get_default_subject_prefix()
Wu, Josh9873b912015-04-15 10:25:18 +0800389 if git_prefix:
Paul Burtona5edb442016-09-27 16:03:49 +0100390 git_prefix = '%s][' % git_prefix
Wu, Josh9873b912015-04-15 10:25:18 +0800391 else:
392 git_prefix = ''
393
Simon Glass26132882012-01-14 15:12:45 +0000394 version = ''
395 if self.get('version'):
396 version = ' v%s' % self['version']
397
398 # Get patch name prefix
399 prefix = ''
400 if self.get('prefix'):
401 prefix = '%s ' % self['prefix']
Sean Andersondc1cd132021-10-22 19:07:04 -0400402
403 postfix = ''
404 if self.get('postfix'):
405 postfix = ' %s' % self['postfix']
406 return '%s%sPATCH%s%s' % (git_prefix, prefix, postfix, version)