blob: 9ca66bf8db92be3345228225272e204792e3f56a [file] [log] [blame]
Jagan Teki0d2d0bf2023-02-17 17:28:41 +05301// SPDX-License-Identifier: GPL-2.0
2/*
3 * Rockchip USB3.0/PCIe Gen2/SATA/SGMII combphy driver
4 *
5 * Copyright (C) 2021 Rockchip Electronics Co., Ltd.
6 */
7
8#include <common.h>
9#include <clk.h>
10#include <dm.h>
11#include <dm/lists.h>
12#include <dt-bindings/phy/phy.h>
13#include <generic-phy.h>
14#include <syscon.h>
15#include <asm/io.h>
16#include <asm/arch-rockchip/clock.h>
17#include <regmap.h>
18#include <reset-uclass.h>
19#include <dm/device_compat.h>
20
21#define BIT_WRITEABLE_SHIFT 16
22
23struct rockchip_combphy_priv;
24
25struct combphy_reg {
26 u16 offset;
27 u16 bitend;
28 u16 bitstart;
29 u16 disable;
30 u16 enable;
31};
32
33struct rockchip_combphy_grfcfg {
34 struct combphy_reg pcie_mode_set;
35 struct combphy_reg usb_mode_set;
36 struct combphy_reg sgmii_mode_set;
37 struct combphy_reg qsgmii_mode_set;
38 struct combphy_reg pipe_rxterm_set;
39 struct combphy_reg pipe_txelec_set;
40 struct combphy_reg pipe_txcomp_set;
41 struct combphy_reg pipe_clk_25m;
42 struct combphy_reg pipe_clk_100m;
43 struct combphy_reg pipe_phymode_sel;
44 struct combphy_reg pipe_rate_sel;
45 struct combphy_reg pipe_rxterm_sel;
46 struct combphy_reg pipe_txelec_sel;
47 struct combphy_reg pipe_txcomp_sel;
48 struct combphy_reg pipe_clk_ext;
49 struct combphy_reg pipe_sel_usb;
50 struct combphy_reg pipe_sel_qsgmii;
51 struct combphy_reg pipe_phy_status;
52 struct combphy_reg con0_for_pcie;
53 struct combphy_reg con1_for_pcie;
54 struct combphy_reg con2_for_pcie;
55 struct combphy_reg con3_for_pcie;
56 struct combphy_reg con0_for_sata;
57 struct combphy_reg con1_for_sata;
58 struct combphy_reg con2_for_sata;
59 struct combphy_reg con3_for_sata;
60 struct combphy_reg pipe_con0_for_sata;
Jon Linbc980f62023-04-27 10:35:35 +030061 struct combphy_reg pipe_con1_for_sata;
Jagan Teki0d2d0bf2023-02-17 17:28:41 +053062 struct combphy_reg pipe_sgmii_mac_sel;
63 struct combphy_reg pipe_xpcs_phy_ready;
Jonas Karlmanecc72452023-08-02 19:41:22 +000064 struct combphy_reg pipe_pcie1l0_sel;
65 struct combphy_reg pipe_pcie1l1_sel;
Jagan Teki0d2d0bf2023-02-17 17:28:41 +053066 struct combphy_reg u3otg0_port_en;
67 struct combphy_reg u3otg1_port_en;
68};
69
70struct rockchip_combphy_cfg {
71 const struct rockchip_combphy_grfcfg *grfcfg;
72 int (*combphy_cfg)(struct rockchip_combphy_priv *priv);
73};
74
75struct rockchip_combphy_priv {
76 u32 mode;
77 void __iomem *mmio;
78 struct udevice *dev;
79 struct regmap *pipe_grf;
80 struct regmap *phy_grf;
81 struct phy *phy;
Eugen Hristev03a44832023-04-27 10:35:34 +030082 struct reset_ctl_bulk phy_rsts;
Jagan Teki0d2d0bf2023-02-17 17:28:41 +053083 struct clk ref_clk;
84 const struct rockchip_combphy_cfg *cfg;
85};
86
87static int param_write(struct regmap *base,
88 const struct combphy_reg *reg, bool en)
89{
90 u32 val, mask, tmp;
91
92 tmp = en ? reg->enable : reg->disable;
93 mask = GENMASK(reg->bitend, reg->bitstart);
94 val = (tmp << reg->bitstart) | (mask << BIT_WRITEABLE_SHIFT);
95
96 return regmap_write(base, reg->offset, val);
97}
98
99static int rockchip_combphy_pcie_init(struct rockchip_combphy_priv *priv)
100{
101 int ret = 0;
102
103 if (priv->cfg->combphy_cfg) {
104 ret = priv->cfg->combphy_cfg(priv);
105 if (ret) {
106 dev_err(priv->dev, "failed to init phy for pcie\n");
107 return ret;
108 }
109 }
110
111 return ret;
112}
113
114static int rockchip_combphy_usb3_init(struct rockchip_combphy_priv *priv)
115{
116 int ret = 0;
117
118 if (priv->cfg->combphy_cfg) {
119 ret = priv->cfg->combphy_cfg(priv);
120 if (ret) {
121 dev_err(priv->dev, "failed to init phy for usb3\n");
122 return ret;
123 }
124 }
125
126 return ret;
127}
128
129static int rockchip_combphy_sata_init(struct rockchip_combphy_priv *priv)
130{
131 int ret = 0;
132
133 if (priv->cfg->combphy_cfg) {
134 ret = priv->cfg->combphy_cfg(priv);
135 if (ret) {
136 dev_err(priv->dev, "failed to init phy for sata\n");
137 return ret;
138 }
139 }
140
141 return ret;
142}
143
144static int rockchip_combphy_sgmii_init(struct rockchip_combphy_priv *priv)
145{
146 int ret = 0;
147
148 if (priv->cfg->combphy_cfg) {
149 ret = priv->cfg->combphy_cfg(priv);
150 if (ret) {
151 dev_err(priv->dev, "failed to init phy for sgmii\n");
152 return ret;
153 }
154 }
155
156 return ret;
157}
158
159static int rockchip_combphy_set_mode(struct rockchip_combphy_priv *priv)
160{
161 switch (priv->mode) {
162 case PHY_TYPE_PCIE:
163 rockchip_combphy_pcie_init(priv);
164 break;
165 case PHY_TYPE_USB3:
166 rockchip_combphy_usb3_init(priv);
167 break;
168 case PHY_TYPE_SATA:
169 rockchip_combphy_sata_init(priv);
170 break;
171 case PHY_TYPE_SGMII:
172 case PHY_TYPE_QSGMII:
173 return rockchip_combphy_sgmii_init(priv);
174 default:
175 dev_err(priv->dev, "incompatible PHY type\n");
176 return -EINVAL;
177 }
178
179 return 0;
180}
181
182static int rockchip_combphy_init(struct phy *phy)
183{
184 struct rockchip_combphy_priv *priv = dev_get_priv(phy->dev);
185 int ret;
186
187 ret = clk_enable(&priv->ref_clk);
188 if (ret < 0 && ret != -ENOSYS)
189 return ret;
190
191 ret = rockchip_combphy_set_mode(priv);
192 if (ret)
193 goto err_clk;
194
Eugen Hristev03a44832023-04-27 10:35:34 +0300195 reset_deassert_bulk(&priv->phy_rsts);
Jagan Teki0d2d0bf2023-02-17 17:28:41 +0530196
197 return 0;
198
199err_clk:
200 clk_disable(&priv->ref_clk);
201
202 return ret;
203}
204
205static int rockchip_combphy_exit(struct phy *phy)
206{
207 struct rockchip_combphy_priv *priv = dev_get_priv(phy->dev);
208
209 clk_disable(&priv->ref_clk);
Eugen Hristev03a44832023-04-27 10:35:34 +0300210 reset_assert_bulk(&priv->phy_rsts);
Jagan Teki0d2d0bf2023-02-17 17:28:41 +0530211
212 return 0;
213}
214
215static int rockchip_combphy_xlate(struct phy *phy, struct ofnode_phandle_args *args)
216{
217 struct rockchip_combphy_priv *priv = dev_get_priv(phy->dev);
218
219 if (args->args_count != 1) {
220 pr_err("invalid number of arguments\n");
221 return -EINVAL;
222 }
223
224 priv->mode = args->args[0];
225
226 return 0;
227}
228
229static const struct phy_ops rochchip_combphy_ops = {
230 .init = rockchip_combphy_init,
231 .exit = rockchip_combphy_exit,
232 .of_xlate = rockchip_combphy_xlate,
233};
234
235static int rockchip_combphy_parse_dt(struct udevice *dev,
236 struct rockchip_combphy_priv *priv)
237{
238 struct udevice *syscon;
239 int ret;
240
241 ret = uclass_get_device_by_phandle(UCLASS_SYSCON, dev, "rockchip,pipe-grf", &syscon);
242 if (ret) {
243 dev_err(dev, "failed to find peri_ctrl pipe-grf regmap");
244 return ret;
245 }
246 priv->pipe_grf = syscon_get_regmap(syscon);
247
248 ret = uclass_get_device_by_phandle(UCLASS_SYSCON, dev, "rockchip,pipe-phy-grf", &syscon);
249 if (ret) {
250 dev_err(dev, "failed to find peri_ctrl pipe-phy-grf regmap\n");
251 return ret;
252 }
253 priv->phy_grf = syscon_get_regmap(syscon);
254
255 ret = clk_get_by_index(dev, 0, &priv->ref_clk);
256 if (ret) {
257 dev_err(dev, "failed to find ref clock\n");
258 return PTR_ERR(&priv->ref_clk);
259 }
260
Eugen Hristev03a44832023-04-27 10:35:34 +0300261 ret = reset_get_bulk(dev, &priv->phy_rsts);
Jagan Teki0d2d0bf2023-02-17 17:28:41 +0530262 if (ret) {
263 dev_err(dev, "no phy reset control specified\n");
264 return ret;
265 }
266
267 return 0;
268}
269
270static int rockchip_combphy_probe(struct udevice *udev)
271{
272 struct rockchip_combphy_priv *priv = dev_get_priv(udev);
273 const struct rockchip_combphy_cfg *phy_cfg;
274
275 priv->mmio = (void __iomem *)dev_read_addr(udev);
276 if (IS_ERR(priv->mmio))
277 return PTR_ERR(priv->mmio);
278
279 phy_cfg = (const struct rockchip_combphy_cfg *)dev_get_driver_data(udev);
280 if (!phy_cfg) {
281 dev_err(udev, "No OF match data provided\n");
282 return -EINVAL;
283 }
284
285 priv->dev = udev;
286 priv->mode = PHY_TYPE_SATA;
287 priv->cfg = phy_cfg;
288
289 return rockchip_combphy_parse_dt(udev, priv);
290}
291
292static int rk3568_combphy_cfg(struct rockchip_combphy_priv *priv)
293{
294 const struct rockchip_combphy_grfcfg *cfg = priv->cfg->grfcfg;
295 u32 val;
296
297 switch (priv->mode) {
298 case PHY_TYPE_PCIE:
299 /* Set SSC downward spread spectrum */
300 val = readl(priv->mmio + (0x1f << 2));
301 val &= ~GENMASK(5, 4);
302 val |= 0x01 << 4;
303 writel(val, priv->mmio + 0x7c);
304
305 param_write(priv->phy_grf, &cfg->con0_for_pcie, true);
306 param_write(priv->phy_grf, &cfg->con1_for_pcie, true);
307 param_write(priv->phy_grf, &cfg->con2_for_pcie, true);
308 param_write(priv->phy_grf, &cfg->con3_for_pcie, true);
309 break;
310 case PHY_TYPE_USB3:
311 /* Set SSC downward spread spectrum */
312 val = readl(priv->mmio + (0x1f << 2));
313 val &= ~GENMASK(5, 4);
314 val |= 0x01 << 4;
315 writel(val, priv->mmio + 0x7c);
316
317 /* Enable adaptive CTLE for USB3.0 Rx */
318 val = readl(priv->mmio + (0x0e << 2));
319 val &= ~GENMASK(0, 0);
320 val |= 0x01;
321 writel(val, priv->mmio + (0x0e << 2));
322
323 /* Set PLL KVCO fine tuning signals */
324 val = readl(priv->mmio + (0x20 << 2));
325 val &= ~(0x7 << 2);
326 val |= 0x2 << 2;
327 writel(val, priv->mmio + (0x20 << 2));
328
329 /* Set PLL LPF R1 to su_trim[10:7]=1001 */
330 writel(0x4, priv->mmio + (0xb << 2));
331
332 /* Set PLL input clock divider 1/2 */
333 val = readl(priv->mmio + (0x5 << 2));
334 val &= ~(0x3 << 6);
335 val |= 0x1 << 6;
336 writel(val, priv->mmio + (0x5 << 2));
337
338 /* Set PLL loop divider */
339 writel(0x32, priv->mmio + (0x11 << 2));
340
341 /* Set PLL KVCO to min and set PLL charge pump current to max */
342 writel(0xf0, priv->mmio + (0xa << 2));
343
344 param_write(priv->phy_grf, &cfg->pipe_sel_usb, true);
345 param_write(priv->phy_grf, &cfg->pipe_txcomp_sel, false);
346 param_write(priv->phy_grf, &cfg->pipe_txelec_sel, false);
347 param_write(priv->phy_grf, &cfg->usb_mode_set, true);
348 break;
349 case PHY_TYPE_SATA:
350 writel(0x41, priv->mmio + 0x38);
351 writel(0x8F, priv->mmio + 0x18);
352 param_write(priv->phy_grf, &cfg->con0_for_sata, true);
353 param_write(priv->phy_grf, &cfg->con1_for_sata, true);
354 param_write(priv->phy_grf, &cfg->con2_for_sata, true);
355 param_write(priv->phy_grf, &cfg->con3_for_sata, true);
356 param_write(priv->pipe_grf, &cfg->pipe_con0_for_sata, true);
357 break;
358 case PHY_TYPE_SGMII:
359 param_write(priv->pipe_grf, &cfg->pipe_xpcs_phy_ready, true);
360 param_write(priv->phy_grf, &cfg->pipe_phymode_sel, true);
361 param_write(priv->phy_grf, &cfg->pipe_sel_qsgmii, true);
362 param_write(priv->phy_grf, &cfg->sgmii_mode_set, true);
363 break;
364 case PHY_TYPE_QSGMII:
365 param_write(priv->pipe_grf, &cfg->pipe_xpcs_phy_ready, true);
366 param_write(priv->phy_grf, &cfg->pipe_phymode_sel, true);
367 param_write(priv->phy_grf, &cfg->pipe_rate_sel, true);
368 param_write(priv->phy_grf, &cfg->pipe_sel_qsgmii, true);
369 param_write(priv->phy_grf, &cfg->qsgmii_mode_set, true);
370 break;
371 default:
372 pr_err("%s, phy-type %d\n", __func__, priv->mode);
373 return -EINVAL;
374 }
375
376 /* The default ref clock is 25Mhz */
377 param_write(priv->phy_grf, &cfg->pipe_clk_25m, true);
378
379 if (dev_read_bool(priv->dev, "rockchip,enable-ssc")) {
380 val = readl(priv->mmio + (0x7 << 2));
381 val |= BIT(4);
382 writel(val, priv->mmio + (0x7 << 2));
383 }
384
385 return 0;
386}
387
388static const struct rockchip_combphy_grfcfg rk3568_combphy_grfcfgs = {
389 /* pipe-phy-grf */
390 .pcie_mode_set = { 0x0000, 5, 0, 0x00, 0x11 },
391 .usb_mode_set = { 0x0000, 5, 0, 0x00, 0x04 },
392 .sgmii_mode_set = { 0x0000, 5, 0, 0x00, 0x01 },
393 .qsgmii_mode_set = { 0x0000, 5, 0, 0x00, 0x21 },
394 .pipe_rxterm_set = { 0x0000, 12, 12, 0x00, 0x01 },
395 .pipe_txelec_set = { 0x0004, 1, 1, 0x00, 0x01 },
396 .pipe_txcomp_set = { 0x0004, 4, 4, 0x00, 0x01 },
397 .pipe_clk_25m = { 0x0004, 14, 13, 0x00, 0x01 },
398 .pipe_clk_100m = { 0x0004, 14, 13, 0x00, 0x02 },
399 .pipe_phymode_sel = { 0x0008, 1, 1, 0x00, 0x01 },
400 .pipe_rate_sel = { 0x0008, 2, 2, 0x00, 0x01 },
401 .pipe_rxterm_sel = { 0x0008, 8, 8, 0x00, 0x01 },
402 .pipe_txelec_sel = { 0x0008, 12, 12, 0x00, 0x01 },
403 .pipe_txcomp_sel = { 0x0008, 15, 15, 0x00, 0x01 },
404 .pipe_clk_ext = { 0x000c, 9, 8, 0x02, 0x01 },
405 .pipe_sel_usb = { 0x000c, 14, 13, 0x00, 0x01 },
406 .pipe_sel_qsgmii = { 0x000c, 15, 13, 0x00, 0x07 },
407 .pipe_phy_status = { 0x0034, 6, 6, 0x01, 0x00 },
408 .con0_for_pcie = { 0x0000, 15, 0, 0x00, 0x1000 },
409 .con1_for_pcie = { 0x0004, 15, 0, 0x00, 0x0000 },
410 .con2_for_pcie = { 0x0008, 15, 0, 0x00, 0x0101 },
411 .con3_for_pcie = { 0x000c, 15, 0, 0x00, 0x0200 },
412 .con0_for_sata = { 0x0000, 15, 0, 0x00, 0x0119 },
413 .con1_for_sata = { 0x0004, 15, 0, 0x00, 0x0040 },
414 .con2_for_sata = { 0x0008, 15, 0, 0x00, 0x80c3 },
415 .con3_for_sata = { 0x000c, 15, 0, 0x00, 0x4407 },
416 /* pipe-grf */
417 .pipe_con0_for_sata = { 0x0000, 15, 0, 0x00, 0x2220 },
418 .pipe_sgmii_mac_sel = { 0x0040, 1, 1, 0x00, 0x01 },
419 .pipe_xpcs_phy_ready = { 0x0040, 2, 2, 0x00, 0x01 },
420 .u3otg0_port_en = { 0x0104, 15, 0, 0x0181, 0x1100 },
421 .u3otg1_port_en = { 0x0144, 15, 0, 0x0181, 0x1100 },
422};
423
424static const struct rockchip_combphy_cfg rk3568_combphy_cfgs = {
425 .grfcfg = &rk3568_combphy_grfcfgs,
426 .combphy_cfg = rk3568_combphy_cfg,
427};
428
Jon Linbc980f62023-04-27 10:35:35 +0300429static int rk3588_combphy_cfg(struct rockchip_combphy_priv *priv)
430{
431 const struct rockchip_combphy_grfcfg *cfg = priv->cfg->grfcfg;
432 u32 val;
433
434 switch (priv->mode) {
435 case PHY_TYPE_PCIE:
436 param_write(priv->phy_grf, &cfg->con0_for_pcie, true);
437 param_write(priv->phy_grf, &cfg->con1_for_pcie, true);
438 param_write(priv->phy_grf, &cfg->con2_for_pcie, true);
439 param_write(priv->phy_grf, &cfg->con3_for_pcie, true);
Jonas Karlmanecc72452023-08-02 19:41:22 +0000440 param_write(priv->pipe_grf, &cfg->pipe_pcie1l0_sel, true);
441 param_write(priv->pipe_grf, &cfg->pipe_pcie1l1_sel, true);
Jon Linbc980f62023-04-27 10:35:35 +0300442 break;
443 case PHY_TYPE_USB3:
444 param_write(priv->phy_grf, &cfg->pipe_txcomp_sel, false);
445 param_write(priv->phy_grf, &cfg->pipe_txelec_sel, false);
446 param_write(priv->phy_grf, &cfg->usb_mode_set, true);
447 break;
448 case PHY_TYPE_SATA:
449 param_write(priv->phy_grf, &cfg->con0_for_sata, true);
450 param_write(priv->phy_grf, &cfg->con1_for_sata, true);
451 param_write(priv->phy_grf, &cfg->con2_for_sata, true);
452 param_write(priv->phy_grf, &cfg->con3_for_sata, true);
453 param_write(priv->pipe_grf, &cfg->pipe_con0_for_sata, true);
454 param_write(priv->pipe_grf, &cfg->pipe_con1_for_sata, true);
455 break;
456 case PHY_TYPE_SGMII:
457 case PHY_TYPE_QSGMII:
458 default:
459 dev_err(priv->dev, "incompatible PHY type\n");
460 return -EINVAL;
461 }
462
463 /* 100MHz refclock signal is good */
464 clk_set_rate(&priv->ref_clk, 100000000);
465 param_write(priv->phy_grf, &cfg->pipe_clk_100m, true);
466 if (priv->mode == PHY_TYPE_PCIE) {
467 /* PLL KVCO tuning fine */
468 val = readl(priv->mmio + (0x20 << 2));
469 val &= ~GENMASK(4, 2);
470 val |= 0x4 << 2;
471 writel(val, priv->mmio + (0x20 << 2));
472
473 /* Set up rx_trim: PLL LPF C1 85pf R1 1.25kohm */
474 val = 0x4c;
475 writel(val, priv->mmio + (0x1b << 2));
476
477 /* Set up su_trim: T3 */
478 val = 0xb0;
479 writel(val, priv->mmio + (0xa << 2));
480 val = 0x47;
481 writel(val, priv->mmio + (0xb << 2));
482 val = 0x57;
483 writel(val, priv->mmio + (0xd << 2));
484 }
485
486 return 0;
487}
488
489static const struct rockchip_combphy_grfcfg rk3588_combphy_grfcfgs = {
490 /* pipe-phy-grf */
491 .pcie_mode_set = { 0x0000, 5, 0, 0x00, 0x11 },
492 .usb_mode_set = { 0x0000, 5, 0, 0x00, 0x04 },
493 .pipe_rxterm_set = { 0x0000, 12, 12, 0x00, 0x01 },
494 .pipe_txelec_set = { 0x0004, 1, 1, 0x00, 0x01 },
495 .pipe_txcomp_set = { 0x0004, 4, 4, 0x00, 0x01 },
496 .pipe_clk_25m = { 0x0004, 14, 13, 0x00, 0x01 },
497 .pipe_clk_100m = { 0x0004, 14, 13, 0x00, 0x02 },
498 .pipe_rxterm_sel = { 0x0008, 8, 8, 0x00, 0x01 },
499 .pipe_txelec_sel = { 0x0008, 12, 12, 0x00, 0x01 },
500 .pipe_txcomp_sel = { 0x0008, 15, 15, 0x00, 0x01 },
501 .pipe_clk_ext = { 0x000c, 9, 8, 0x02, 0x01 },
502 .pipe_phy_status = { 0x0034, 6, 6, 0x01, 0x00 },
503 .con0_for_pcie = { 0x0000, 15, 0, 0x00, 0x1000 },
504 .con1_for_pcie = { 0x0004, 15, 0, 0x00, 0x0000 },
505 .con2_for_pcie = { 0x0008, 15, 0, 0x00, 0x0101 },
506 .con3_for_pcie = { 0x000c, 15, 0, 0x00, 0x0200 },
507 .con0_for_sata = { 0x0000, 15, 0, 0x00, 0x0129 },
508 .con1_for_sata = { 0x0004, 15, 0, 0x00, 0x0040 },
509 .con2_for_sata = { 0x0008, 15, 0, 0x00, 0x80c1 },
510 .con3_for_sata = { 0x000c, 15, 0, 0x00, 0x0407 },
511 /* pipe-grf */
512 .pipe_con0_for_sata = { 0x0000, 11, 5, 0x00, 0x22 },
513 .pipe_con1_for_sata = { 0x0000, 2, 0, 0x00, 0x2 },
Jonas Karlmanecc72452023-08-02 19:41:22 +0000514 .pipe_pcie1l0_sel = { 0x0100, 0, 0, 0x01, 0x0 },
515 .pipe_pcie1l1_sel = { 0x0100, 1, 1, 0x01, 0x0 },
Jon Linbc980f62023-04-27 10:35:35 +0300516};
517
518static const struct rockchip_combphy_cfg rk3588_combphy_cfgs = {
519 .grfcfg = &rk3588_combphy_grfcfgs,
520 .combphy_cfg = rk3588_combphy_cfg,
521};
522
Jagan Teki0d2d0bf2023-02-17 17:28:41 +0530523static const struct udevice_id rockchip_combphy_ids[] = {
524 {
525 .compatible = "rockchip,rk3568-naneng-combphy",
526 .data = (ulong)&rk3568_combphy_cfgs
527 },
Jon Linbc980f62023-04-27 10:35:35 +0300528 {
529 .compatible = "rockchip,rk3588-naneng-combphy",
530 .data = (ulong)&rk3588_combphy_cfgs
531 },
Jagan Teki0d2d0bf2023-02-17 17:28:41 +0530532 { }
533};
534
535U_BOOT_DRIVER(rockchip_naneng_combphy) = {
536 .name = "naneng-combphy",
537 .id = UCLASS_PHY,
538 .of_match = rockchip_combphy_ids,
539 .ops = &rochchip_combphy_ops,
540 .probe = rockchip_combphy_probe,
541 .priv_auto = sizeof(struct rockchip_combphy_priv),
542};