| developer | 66e89bc | 2024-04-23 14:50:01 +0800 | [diff] [blame^] | 1 | From db3c26b1e067aca67455a0246c390dc0271496f3 Mon Sep 17 00:00:00 2001 |
| 2 | From: Shayne Chen <shayne.chen@mediatek.com> |
| 3 | Date: Thu, 26 Oct 2023 17:27:43 +0800 |
| 4 | Subject: [PATCH 067/116] mtk: wifi: mt76: mt7996: do not report netdev stats |
| 5 | on monitor vif |
| 6 | |
| 7 | This fixes the following NULL pointer crash when enabling monitor mode: |
| 8 | [ 205.593158] Call trace: |
| 9 | [ 205.595597] mt7996_mcu_rx_event+0x4a0/0x6e8 [mt7996e] |
| 10 | [ 205.600725] mt7996_queue_rx_skb+0x6e4/0xfa0 [mt7996e] |
| 11 | [ 205.605851] mt76_dma_rx_poll+0x384/0x420 [mt76] |
| 12 | [ 205.610459] __napi_poll+0x38/0x1c0 |
| 13 | [ 205.613935] napi_threaded_poll+0x80/0xe8 |
| 14 | [ 205.617934] kthread+0x124/0x128 |
| 15 | |
| 16 | CR-Id: WCNCR00238098 |
| 17 | Change-Id: I66f2449401888255bf8d3edddc1d9f20bd8ba3e7 |
| 18 | Signed-off-by: Shayne Chen <shayne.chen@mediatek.com> |
| 19 | --- |
| 20 | mt7996/mcu.c | 3 +++ |
| 21 | 1 file changed, 3 insertions(+) |
| 22 | |
| 23 | diff --git a/mt7996/mcu.c b/mt7996/mcu.c |
| 24 | index 568e4d45a..337bcf559 100644 |
| 25 | --- a/mt7996/mcu.c |
| 26 | +++ b/mt7996/mcu.c |
| 27 | @@ -540,6 +540,9 @@ static inline void __mt7996_stat_to_netdev(struct mt76_phy *mphy, |
| 28 | drv_priv); |
| 29 | wdev = ieee80211_vif_to_wdev(vif); |
| 30 | |
| 31 | + if (vif->type == NL80211_IFTYPE_MONITOR) |
| 32 | + return; |
| 33 | + |
| 34 | dev_sw_netstats_tx_add(wdev->netdev, tx_packets, tx_bytes); |
| 35 | dev_sw_netstats_rx_add(wdev->netdev, rx_packets, rx_bytes); |
| 36 | } |
| 37 | -- |
| 38 | 2.39.2 |
| 39 | |