blob: 81fecd3ed2522c699621c880a5f4321fe2526edc [file] [log] [blame]
developer05f3b2b2024-08-19 19:17:34 +08001From 1879c122435092c63eb0e8156f6e75d8e147fa13 Mon Sep 17 00:00:00 2001
developer66e89bc2024-04-23 14:50:01 +08002From: "fancy.liu" <fancy.liu@mediatek.com>
3Date: Tue, 14 Nov 2023 10:13:24 +0800
developer05f3b2b2024-08-19 19:17:34 +08004Subject: [PATCH 020/199] mtk: mt76: mt7996: ACS channel time too long on duty
5 channel
developer66e89bc2024-04-23 14:50:01 +08006
7Step and issue:
81. Set channel to 36 in hostapd config;
92. Bootup;
103. Enable ACS through UCI command and reload;
114. Check hostapd log, channel 36 channel_time is much longer than other channels.
12
13Root cause:
14The reset chan_stat condition missed duty channel.
15
16Solution:
17When scan start, need to reset chan_stat in each channel switch.
18
developer66e89bc2024-04-23 14:50:01 +080019Issue:
20There's a chance that the channel time for duty channel is zero in ACS
21scan.
22
23Root cause:
24The chan_stat may be reset when restore to duty channel.
25Mac80211 will notify to hostapd when scan done and then restore to duty
26channel.
27And mt76 will clear scan flag after restore done.
28If hostapd get the chan_stat before channel_restore, will get the
29correct channel time;
30If hostapd get the chan_stat after channel_restore, will get zero
31channel time;
32
33Solution:
34When channel switch, will check the mac80211 scan state but not the mt76 scan flag.
35Mac80211 scan state will be set in scanning, and will be reset after
36scan done and before restore to duty channel.
37
developer66e89bc2024-04-23 14:50:01 +080038Signed-off-by: fancy.liu <fancy.liu@mediatek.com>
39---
40 mac80211.c | 3 ++-
41 1 file changed, 2 insertions(+), 1 deletion(-)
42
43diff --git a/mac80211.c b/mac80211.c
developer05f3b2b2024-08-19 19:17:34 +080044index 6d47b26d..9df9109f 100644
developer66e89bc2024-04-23 14:50:01 +080045--- a/mac80211.c
46+++ b/mac80211.c
developer9237f442024-06-14 17:13:04 +080047@@ -928,6 +928,7 @@ void mt76_set_channel(struct mt76_phy *phy)
developer66e89bc2024-04-23 14:50:01 +080048 struct cfg80211_chan_def *chandef = &hw->conf.chandef;
49 bool offchannel = hw->conf.flags & IEEE80211_CONF_OFFCHANNEL;
50 int timeout = HZ / 5;
51+ unsigned long was_scanning = ieee80211_get_scanning(hw);
52
53 wait_event_timeout(dev->tx_wait, !mt76_has_tx_pending(phy), timeout);
54 mt76_update_survey(phy);
developer9237f442024-06-14 17:13:04 +080055@@ -942,7 +943,7 @@ void mt76_set_channel(struct mt76_phy *phy)
developer66e89bc2024-04-23 14:50:01 +080056 if (!offchannel)
57 phy->main_chan = chandef->chan;
58
59- if (chandef->chan != phy->main_chan)
60+ if (chandef->chan != phy->main_chan || was_scanning)
61 memset(phy->chan_state, 0, sizeof(*phy->chan_state));
62 }
63 EXPORT_SYMBOL_GPL(mt76_set_channel);
64--
developer9237f442024-06-14 17:13:04 +0800652.18.0
developer66e89bc2024-04-23 14:50:01 +080066