| From e6830d67bbbc38036cd077badd5a605b8f257752 Mon Sep 17 00:00:00 2001 |
| From: Benjamin Lin <benjamin-jw.lin@mediatek.com> |
| Date: Thu, 27 Jul 2023 14:00:30 +0800 |
| Subject: [PATCH 21/98] wifi: mt76: mt7996: remove periodic MPDU TXS request |
| |
| --- |
| mt7996/mac.c | 39 ++++++++++++++++++++++----------------- |
| mt7996/main.c | 1 - |
| mt7996/mt7996.h | 1 - |
| 3 files changed, 22 insertions(+), 19 deletions(-) |
| |
| diff --git a/mt7996/mac.c b/mt7996/mac.c |
| index 06c9a14..32c52fc 100644 |
| --- a/mt7996/mac.c |
| +++ b/mt7996/mac.c |
| @@ -926,15 +926,6 @@ int mt7996_tx_prepare_skb(struct mt76_dev *mdev, void *txwi_ptr, |
| if (!wcid) |
| wcid = &dev->mt76.global_wcid; |
| |
| - if (sta) { |
| - struct mt7996_sta *msta = (struct mt7996_sta *)sta->drv_priv; |
| - |
| - if (time_after(jiffies, msta->jiffies + HZ / 4)) { |
| - info->flags |= IEEE80211_TX_CTL_REQ_TX_STATUS; |
| - msta->jiffies = jiffies; |
| - } |
| - } |
| - |
| t = (struct mt76_txwi_cache *)(txwi + mdev->drv->txwi_size); |
| t->skb = tx_info->skb; |
| |
| @@ -1010,22 +1001,36 @@ u32 mt7996_wed_init_buf(void *ptr, dma_addr_t phys, int token_id) |
| } |
| |
| static void |
| -mt7996_tx_check_aggr(struct ieee80211_sta *sta, __le32 *txwi) |
| +mt7996_tx_check_aggr(struct ieee80211_sta *sta, struct sk_buff *skb) |
| { |
| struct mt7996_sta *msta; |
| + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); |
| + bool is_8023 = info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP; |
| u16 fc, tid; |
| - u32 val; |
| |
| if (!sta || !(sta->deflink.ht_cap.ht_supported || sta->deflink.he_cap.has_he)) |
| return; |
| |
| - tid = le32_get_bits(txwi[1], MT_TXD1_TID); |
| + tid = skb->priority & IEEE80211_QOS_CTL_TID_MASK; |
| if (tid >= 6) /* skip VO queue */ |
| return; |
| |
| - val = le32_to_cpu(txwi[2]); |
| - fc = FIELD_GET(MT_TXD2_FRAME_TYPE, val) << 2 | |
| - FIELD_GET(MT_TXD2_SUB_TYPE, val) << 4; |
| + if (is_8023) |
| + fc = IEEE80211_FTYPE_DATA | |
| + (sta->wme ? IEEE80211_STYPE_QOS_DATA |
| + : IEEE80211_STYPE_DATA); |
| + else { |
| + /* No need to get precise TID for Action/Management Frame, |
| + * since it will not meet the following Frame Control |
| + * condition anyway. |
| + */ |
| + |
| + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; |
| + |
| + fc = le16_to_cpu(hdr->frame_control) & |
| + (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE); |
| + } |
| + |
| if (unlikely(fc != (IEEE80211_FTYPE_DATA | IEEE80211_STYPE_QOS_DATA))) |
| return; |
| |
| @@ -1053,7 +1058,7 @@ mt7996_txwi_free(struct mt7996_dev *dev, struct mt76_txwi_cache *t, |
| wcid_idx = wcid->idx; |
| |
| if (likely(t->skb->protocol != cpu_to_be16(ETH_P_PAE))) |
| - mt7996_tx_check_aggr(sta, txwi); |
| + mt7996_tx_check_aggr(sta, t->skb); |
| } else { |
| wcid_idx = le32_get_bits(txwi[9], MT_TXD9_WLAN_IDX); |
| } |
| @@ -1330,7 +1335,7 @@ static void mt7996_mac_add_txs(struct mt7996_dev *dev, void *data) |
| wcidx = le32_get_bits(txs_data[2], MT_TXS2_MLD_ID); |
| pid = le32_get_bits(txs_data[3], MT_TXS3_PID); |
| |
| - if (pid < MT_PACKET_ID_WED) |
| + if (pid < MT_PACKET_ID_NO_SKB) |
| return; |
| |
| if (wcidx >= mt7996_wtbl_size(dev)) |
| diff --git a/mt7996/main.c b/mt7996/main.c |
| index 0b3f8c8..832b861 100644 |
| --- a/mt7996/main.c |
| +++ b/mt7996/main.c |
| @@ -666,7 +666,6 @@ int mt7996_mac_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif, |
| msta->wcid.idx = idx; |
| msta->wcid.phy_idx = band_idx; |
| msta->wcid.tx_info |= MT_WCID_TX_INFO_SET; |
| - msta->jiffies = jiffies; |
| |
| ewma_avg_signal_init(&msta->avg_ack_signal); |
| |
| diff --git a/mt7996/mt7996.h b/mt7996/mt7996.h |
| index 420d113..f268773 100644 |
| --- a/mt7996/mt7996.h |
| +++ b/mt7996/mt7996.h |
| @@ -147,7 +147,6 @@ struct mt7996_sta { |
| struct ewma_avg_signal avg_ack_signal; |
| |
| unsigned long changed; |
| - unsigned long jiffies; |
| |
| struct mt76_connac_sta_key_conf bip; |
| |
| -- |
| 2.18.0 |
| |