[][kernel][common][eth][Fix Coverity scan warning]
[Description]
Fix Coverity scan warning.
[Release-log]
N/A
Change-Id: I7867c00156d1e439071cd8e606212d4ae011a52a
Reviewed-on: https://gerrit.mediatek.inc/c/openwrt/feeds/mtk_openwrt_feeds/+/6840068
diff --git a/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 0e34957..2d2797d 100755
--- a/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1143,7 +1143,8 @@
if (unlikely(dma_mapping_error(eth->dev, dma_addr)))
return -ENOMEM;
- phy_ring_tail = eth->phy_scratch_ring + soc->txrx.txd_size * (cnt - 1);
+ phy_ring_tail = eth->phy_scratch_ring +
+ (dma_addr_t)soc->txrx.txd_size * (cnt - 1);
for (i = 0; i < cnt; i++) {
struct mtk_tx_dma_v2 *txd;
@@ -1738,7 +1739,7 @@
while (done < budget) {
struct net_device *netdev = NULL;
unsigned int pktlen;
- dma_addr_t dma_addr;
+ dma_addr_t dma_addr = 0;
int mac = 0;
if (eth->hwlro)
@@ -2126,7 +2127,8 @@
&ring->phys, GFP_KERNEL);
else {
ring->dma = eth->scratch_ring + MTK_DMA_SIZE * sz;
- ring->phys = eth->phy_scratch_ring + MTK_DMA_SIZE * sz;
+ ring->phys = eth->phy_scratch_ring +
+ MTK_DMA_SIZE * (dma_addr_t)sz;
}
if (!ring->dma)
@@ -4035,8 +4037,13 @@
"ethernet:fixed link", mac);
}
- if (!of_property_read_string(to_of_node(fixed_node), "label", &label))
- strcpy(phylink_priv->label, label);
+ if (!of_property_read_string(to_of_node(fixed_node),
+ "label", &label)) {
+ if (strlen(label) < 16)
+ strcpy(phylink_priv->label, label);
+ else
+ dev_err(eth->dev, "insufficient space for label!\n");
+ }
phy_np = of_parse_phandle(to_of_node(fixed_node), "phy-handle", 0);
if (phy_np) {