| commit | 79bf963ba18ebc60851d964565bf92b1c2298035 | [log] [tgz] |
|---|---|---|
| author | developer <developer@mediatek.com> | Fri Dec 22 19:19:55 2023 +0800 |
| committer | developer <developer@mediatek.com> | Sat Dec 23 10:51:01 2023 +0800 |
| tree | 50c5e48af4d5b5b7c6aa93e1c557b21a50d67004 | |
| parent | 7328cc805198f28bfe136fd786945766bead672e [diff] |
[][kernel][common][eth][Fix Coverity scan warning]
[Description]
Fix Coverity scan warning.
- Fix missing unlock in the mtk_usxgmii_pcs_config().
[Release-log]
N/A
Change-Id: Ic72f682c0f3ee7133b085938bbb9019d0829c666
Reviewed-on: https://gerrit.mediatek.inc/c/openwrt/feeds/mtk_openwrt_feeds/+/8435435
diff --git a/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_usxgmii.c b/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_usxgmii.c index cdb2a55..f114225 100644 --- a/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_usxgmii.c +++ b/target/linux/mediatek/files-5.4/drivers/net/ethernet/mediatek/mtk_usxgmii.c
@@ -594,8 +594,10 @@ xfi_mode = FIELD_PREP(USXGMII_XFI_RX_MODE, USXGMII_XFI_RX_MODE_5G) | FIELD_PREP(USXGMII_XFI_TX_MODE, USXGMII_XFI_TX_MODE_5G); adapt_mode = USXGMII_RATE_UPDATE_MODE; - } else + } else { + spin_unlock(&mpcs->regmap_lock); return -EINVAL; + } adapt_mode |= FIELD_PREP(USXGMII_RATE_ADAPT_MODE, USXGMII_RATE_ADAPT_MODE_X1);