[][mt76-vendor: fix more coverity errors]
[Description]
Fix some more coverity errors related to NULL check for mt76-vendor.
[Release-log]
N/A
Change-Id: I096dd26bb6662d4f3e495707231f9ba482e0cc9a
Reviewed-on: https://gerrit.mediatek.inc/c/openwrt/feeds/mtk_openwrt_feeds/+/5072762
diff --git a/feed/mt76-vendor/src/amnt.c b/feed/mt76-vendor/src/amnt.c
index 653e785..4a98c31 100644
--- a/feed/mt76-vendor/src/amnt.c
+++ b/feed/mt76-vendor/src/amnt.c
@@ -72,6 +72,8 @@
return false;
data = nla_nest_start(msg, NL80211_ATTR_VENDOR_DATA | NLA_F_NESTED);
+ if (!data)
+ return -ENOMEM;
mt76_amnt_set_attr(msg, argc, argv);
@@ -136,10 +138,10 @@
int mt76_amnt_dump(int idx, int argc, char **argv)
{
- struct nl_msg *msg, *tb1;
- void *data;
- int ret;
- u8 amnt_idx = 0;
+ struct nl_msg *msg;
+ void *data, *tb1;
+ int ret = -EINVAL;
+ u8 amnt_idx;
if (argc < 1)
return 1;
@@ -157,8 +159,12 @@
return false;
data = nla_nest_start(msg, NL80211_ATTR_VENDOR_DATA | NLA_F_NESTED);
+ if (!data)
+ goto out;
tb1 = nla_nest_start(msg, MTK_VENDOR_ATTR_AMNT_CTRL_DUMP | NLA_F_NESTED);
+ if (!tb1)
+ goto out;
amnt_idx = strtoul(argv[0], NULL, 0);
nla_put_u8(msg, MTK_VENDOR_ATTR_AMNT_DUMP_INDEX, amnt_idx);
@@ -171,6 +177,7 @@
if (ret)
fprintf(stderr, "nl80211 call failed: %s\n", strerror(-ret));
+out:
unl_free(&unl);
return ret;