commit ff6603e7335057bfcb1c374b804c2783a2c65142
author Tim Duesterhus <tim@bastelstu.be> Sat Jan 18 01:46:18 2020 +0100
committer Christopher Faulet <cfaulet@haproxy.com> Mon Jan 20 14:26:13 2020 +0100
tree cb9faad941927129478783b19bdde94684956b2f
parent 8991ce13807bfe37a83212d422043f5cba25b628

BUG/MINOR: cache: Fix leak of cache name in error path

This issue was introduced in commit 99a17a2d91f9044ea20bba6617048488aed80555
which first appeared in tag v1.9-dev11. This bugfix should be backported
to HAProxy 1.9+.

(cherry picked from commit d34b1ce5a20ce8f62b234f9696a621aaebe694c1)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 09582bac29264997d71fcfb897d045c2dcac72f6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

src/cache.c

diff --git a/src/cache.c b/src/cache.c
index 54e3340..7c150ba 100644
--- a/src/cache.c
+++ b/src/cache.c
@@ -1797,7 +1797,7 @@
 			cconf = NULL;
 			memprintf(err, "%s: multiple explicit declarations of the cache filter '%s'",
 				  px->id, name);
-			return -1;
+			goto error;
 		}
 
 		/* Remove the implicit filter. <cconf> is kept for the explicit one */