commit fe83f589068d8cd90ea63fabadd60408ae80cce1
author Tim Duesterhus <tim@bastelstu.be> Sat Apr 22 17:47:34 2023 +0200
committer Willy Tarreau <w@1wt.eu> Sun Apr 23 00:28:25 2023 +0200
tree 7534e1fc00388960ce9a4b14bd22f98fd1d23fe0
parent c18e244515cdf860a3be59f0fc5622b8294099e7

CLEANUP: Stop checking the pointer before calling `task_free()`

Changes performed with this Coccinelle patch:

    @@
    expression e;
    @@

    - if (e != NULL) {
    	task_destroy(e);
    - }

    @@
    expression e;
    @@

    - if (e) {
    	task_destroy(e);
    - }

    @@
    expression e;
    @@

    - if (e)
    	task_destroy(e);

    @@
    expression e;
    @@

    - if (e != NULL)
    	task_destroy(e);

src/mworker.c

diff --git a/src/mworker.c b/src/mworker.c
index 11d61a2..b1115cc 100644
--- a/src/mworker.c
+++ b/src/mworker.c
@@ -502,8 +502,7 @@
 		/* disable this peer section so that it kills itself */
 		if (curpeers->sighandler)
 			signal_unregister_handler(curpeers->sighandler);
-		if (curpeers->sync_task)
-			task_destroy(curpeers->sync_task);
+		task_destroy(curpeers->sync_task);
 		curpeers->sync_task = NULL;
 		curpeers->peers_fe = NULL;
 	}