tree ed9cc7776bfa091dbbff1596686b9a69e25f554c
parent 91c614dd0eedfa7b14c490bbc0f5886cc4290826
author Willy Tarreau <w@1wt.eu> 1600963668 +0200
committer Willy Tarreau <w@1wt.eu> 1602235650 +0200
encoding latin1

BUG/MEDIUM: listeners: correctly report pause() errors

By using the same "ret" variable in the "if" block to test the return
value of pause(), the second one shadows the first one and when forcing
the result to zero in case of an error, it doesn't do anything. The
problem is that some listeners used to fail to pause in multi-process
mode and this was not reported, but their failure was automatically
resolved by the last process to pause. By properly checking for errors
we might now possibly report a race once in a while so we may have to
roll this back later if some users meet it.

The test on ==0 is wrong too since technically speaking a total stop
validates the need for a pause, but stops the listener so it's just
the resume that won't work anymore. We could switch to stopped but
it's an involuntary switch and the user will not know. Better then
mark it as paused and let the resume continue to fail so that only
the resume will eventually report an error (e.g. abns@).

This must not be backported as there is a risk of side effect by fixing
this bug, given that it hides other bugs itself.