tree 52df063f884028e2a78dde0bdf415abc4292454e
parent e781037fd1fac0f6695f2074e8bc1840ed2df83f
author Willy Tarreau <w@1wt.eu> 1578672089 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1579526293 +0100

BUG/MINOR: mux-h2: use a safe list_for_each_entry in h2_send()

h2_send() uses list_for_each_entry() to scan paused streams and resume
them, but happily deletes any leftover from a previous failed unsubscribe,
which is obviously not safe and would corrupt the list. In practice this
is a proof that this doesn't happen, but it's not the best way to prove it.
In order to fix this and reduce the maintenance burden caused by code
duplication (this list walk exists at 3 places), let's introduce a new
function h2_resume_each_sending_h2s() doing exactly this and use it at
all 3 places.

This bug was introduced as a side effect of fix 998410a41b ("BUG/MEDIUM:
h2: Revamp the way send subscriptions works.") so it should be backported
as far as 1.9.

(cherry picked from commit 989539b048bef502a474553a8e330a3d318edb6c)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 449f28322fb45688dacc80bead89fe75f3dd75db)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>