BUILD: add detection for unsupported compiler models
As reported in github issue #1765, some people get trapped into building
haproxy and companion libraries on Windows using a compiler following the
LLP64 model. This has no chance to work, and definitely causes nasty bugs
everywhere when pointers are passed as longs. Let's save them time and
detect this at boot time.
The message and detection was factored with the existing one for -fwrapv
since we need the same info and actions.
This should be backported to all recent supported versions (the ones
that are likely to be tried on such platforms when people don't know).
(cherry picked from commit 41afd9084e13fa834397f8f9925338223aaa4ed5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit a6b7832dd65dfc912f558f6bf67cdb89efed7a83)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit dd6c4129b35013491d90dd39b4dc87e971dc61f3)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
diff --git a/src/haproxy.c b/src/haproxy.c
index c078390..b484195 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2839,34 +2839,49 @@
int pidfd = -1;
int intovf = (unsigned char)argc + 1; /* let the compiler know it's strictly positive */
- /* Catch forced CFLAGS that miss 2-complement integer overflow */
- if (intovf + 0x7FFFFFFF >= intovf) {
+ /* Catch broken toolchains */
+ if (sizeof(long) != sizeof(void *) || (intovf + 0x7FFFFFFF >= intovf)) {
+ const char *msg;
+
+ if (sizeof(long) != sizeof(void *))
+ /* Apparently MingW64 was not made for us and can also break openssl */
+ msg = "The compiler this program was built with uses unsupported integral type sizes.\n"
+ "Most likely it follows the unsupported LLP64 model. Never try to link HAProxy\n"
+ "against libraries built with that compiler either! Please only use a compiler\n"
+ "producing ILP32 or LP64 programs for both programs and libraries.\n";
+ else if (intovf + 0x7FFFFFFF >= intovf)
+ /* Catch forced CFLAGS that miss 2-complement integer overflow */
+ msg = "The source code was miscompiled by the compiler, which usually indicates that\n"
+ "some of the CFLAGS needed to work around overzealous compiler optimizations\n"
+ "were overwritten at build time. Please do not force CFLAGS, and read Makefile\n"
+ "and INSTALL files to decide on the best way to pass your local build options.\n";
+ else
+ msg = "Bug in the compiler bug detection code, please report it to developers!\n";
+
fprintf(stderr,
"FATAL ERROR: invalid code detected -- cannot go further, please recompile!\n"
- "The source code was miscompiled by the compiler, which usually indicates that\n"
- "some of the CFLAGS needed to work around overzealous compiler optimizations\n"
- "were overwritten at build time. Please do not force CFLAGS, and read Makefile\n"
- "and INSTALL files to decide on the best way to pass your local build options.\n"
- "\nBuild options :"
+ "%s"
+ "\nBuild options :"
#ifdef BUILD_TARGET
- "\n TARGET = " BUILD_TARGET
+ "\n TARGET = " BUILD_TARGET
#endif
#ifdef BUILD_CPU
- "\n CPU = " BUILD_CPU
+ "\n CPU = " BUILD_CPU
#endif
#ifdef BUILD_CC
- "\n CC = " BUILD_CC
+ "\n CC = " BUILD_CC
#endif
#ifdef BUILD_CFLAGS
- "\n CFLAGS = " BUILD_CFLAGS
+ "\n CFLAGS = " BUILD_CFLAGS
#endif
#ifdef BUILD_OPTIONS
- "\n OPTIONS = " BUILD_OPTIONS
+ "\n OPTIONS = " BUILD_OPTIONS
#endif
#ifdef BUILD_DEBUG
- "\n DEBUG = " BUILD_DEBUG
+ "\n DEBUG = " BUILD_DEBUG
#endif
- "\n\n");
+ "\n\n", msg);
+
return 1;
}