BUG/MINOR: ssl: crt-ignore-err memory leak with 'all' parameter
Only allocate "str" if the parameter is not "all" in order to avoid any
memory leak.
No backport needed.
diff --git a/src/cfgparse-ssl.c b/src/cfgparse-ssl.c
index 8925fea..d9e93e4 100644
--- a/src/cfgparse-ssl.c
+++ b/src/cfgparse-ssl.c
@@ -836,15 +836,6 @@
return ERR_ALERT | ERR_FATAL;
}
- /* copy the string to be able to dump the complete one in case of
- * error, because strtok_r is writing \0 inside. */
- str = strdup(p);
- if (!str) {
- memprintf(err, "'%s' : Could not allocate memory", args[cur_arg]);
- return ERR_ALERT | ERR_FATAL;
-
- }
-
if (strcmp(args[cur_arg], "ca-ignore-err") == 0)
ignerr = conf->ca_ignerr_bitfield;
@@ -853,6 +844,14 @@
return 0;
}
+ /* copy the string to be able to dump the complete one in case of
+ * error, because strtok_r is writing \0 inside. */
+ str = strdup(p);
+ if (!str) {
+ memprintf(err, "'%s' : Could not allocate memory", args[cur_arg]);
+ return ERR_ALERT | ERR_FATAL;
+ }
+
s1 = str;
while ((token = strtok_r(s1, ",", &s2))) {
s1 = NULL;