REORG: connection: rename the data layer the "transport layer"
While working on the changes required to make the health checks use the
new connections, it started to become obvious that some naming was not
logical at all in the connections. Specifically, it is not logical to
call the "data layer" the layer which is in charge for all the handshake
and which does not yet provide a data layer once established until a
session has allocated all the required buffers.
In fact, it's more a transport layer, which makes much more sense. The
transport layer offers a medium on which data can transit, and it offers
the functions to move these data when the upper layer requests this. And
it is the upper layer which iterates over the transport layer's functions
to move data which should be called the data layer.
The use case where it's obvious is with embryonic sessions : an incoming
SSL connection is accepted. Only the connection is allocated, not the
buffers nor stream interface, etc... The connection handles the SSL
handshake by itself. Once this handshake is complete, we can't use the
data functions because the buffers and stream interface are not there
yet. Hence we have to first call a specific function to complete the
session initialization, after which we'll be able to use the data
functions. This clearly proves that SSL here is only a transport layer
and that the stream interface constitutes the data layer.
A similar change will be performed to rename app_cb => data, but the
two could not be in the same commit for obvious reasons.
diff --git a/src/proto_tcp.c b/src/proto_tcp.c
index 7c3258c..ea6f943 100644
--- a/src/proto_tcp.c
+++ b/src/proto_tcp.c
@@ -460,7 +460,7 @@
fd_insert(fd);
conn_sock_want_send(conn); /* for connect status */
- if (conn_data_init(conn) < 0) {
+ if (conn_xprt_init(conn) < 0) {
fd_delete(fd);
return SN_ERR_RESOURCE;
}
@@ -550,8 +550,8 @@
}
/* The FD is ready now, we'll mark the connection as complete and
- * forward the event to the data layer which will update the stream
- * interface flags.
+ * forward the event to the transport layer which will notify the
+ * data layer.
*/
conn->flags &= ~CO_FL_WAIT_L4_CONN;
return 1;