tree 84023f559e15402f667e0d6b768dc75370f4b387
parent 4087346daba41aae557e5bea15c42e1d2ae9a818
author Willy Tarreau <w@1wt.eu> 1557734562 +0200
committer Willy Tarreau <w@1wt.eu> 1557735001 +0200
encoding latin1

Revert "BUG/MINOR: vars: Fix memory leak in vars_check_arg"

This reverts commit 6ea00195c479d96c5aa651adcca3bc3637e3eceb.

As found by Christopher, this fix is not correct due to the way args
are built at various places. For example some config or runtime parsers
will place a substring pointer there, and calling free() on it will
immediately crash the program. A quick audit of the code shows that
there are not that many users, but the way it's done requires to
properly set the string as a regular chunk (size=0 if free not desired,
then call chunk_destroy() at release time), and given that the size is
currently set to len+1 in all parsers, a deeper audit needs to be done
to figure the impacts of not setting it anymore.

Thus for now better leave this harmless leak which impacts only the
config parsing time.

This fix must be backported to all branches containing the fix above.