BUG/MEDIUM: connections: Don't forget to unlock when killing a connection.
Commit 140237471e408736bb7162e68c572c710a66a526 made sure we hold the
toremove_lock for the corresponding thread before removing a connection
from its idle_orphan_conns list, however it failed to unlock it if we
found a connection, leading to a deadlock, so add the missing deadlock.
This should be backported to 2.1 and 2.0.
(cherry picked from commit 849d4f047f768184f30b989d06502c601f355b9f)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit 358273a47c1497e6c0ef4bd1fb61940cb266a724)
Signed-off-by: Willy Tarreau <w@1wt.eu>
diff --git a/src/backend.c b/src/backend.c
index 487a7c2..6570342 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -1371,6 +1371,7 @@
LIST_ADDQ_LOCKED(&toremove_connections[i],
&tokill_conn->list);
task_wakeup(idle_conn_cleanup[i], TASK_WOKEN_OTHER);
+ HA_SPIN_UNLOCK(OTHER_LOCK, &toremove_lock[tid]);
break;
}
HA_SPIN_UNLOCK(OTHER_LOCK, &toremove_lock[tid]);