tree e0142ced8f09c3bfc0f90da505247ced3009b079
parent 82c51b561e82100aedbf88c957b2b70a1d83c122
author Amaury Denoyelle <adenoyelle@haproxy.com> 1652806342 +0200
committer Amaury Denoyelle <adenoyelle@haproxy.com> 1652880209 +0200

BUG/MINOR: ncbuf: fix ncb_is_empty()

ncb_is_empty() was plainly incorrect as it directly dereferences the
memory to read offset blocks instead of ncb_read_off(). The result is
undefined.

Also, BUG_ON() statement is wrong when the buffer starts with a data
block. In this case, ncb_head() is not the first gap offset but instead
just random data. The calculated sum in BUG_ON() statement has thus no
meaning and may cause an abort. Adjust this by reorganizing the whole
function. Only the first data block size is read. If and only if not
nul, the first gap size is then checked.

ncb_is_full() has been rewritten to share the same model as
ncb_is_empty().