MINOR: quic: Remove useless traces about references to TX packets
Since this commit:
"BUG/MINOR: quic: Wrong list_for_each_entry() use when building packets from
qc_do_build_pkt()"
there is no more reason that frames can be released without having been
sent, i.e. frames with non null ->pkt member. This ->pkt is the packet
the frame is attached to.
Must be backported to 2.6.
diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index ffa2cba..30af64e 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -1475,15 +1475,8 @@
list_for_each_entry_safe(f, tmp, &frm->reflist, ref) {
f->origin = NULL;
LIST_DELETE(&f->ref);
- if (f->pkt) {
- TRACE_DEVEL("remove frame reference",
- QUIC_EV_CONN_PRSAFRM, qc, f, &f->pkt->pn_node.key);
- }
- else {
- /* XXX TODO: what must be done for such a frame */
- TRACE_DEVEL("remove frame reference for unsent frame",
- QUIC_EV_CONN_PRSAFRM, qc, f);
- }
+ TRACE_DEVEL("remove frame reference",
+ QUIC_EV_CONN_PRSAFRM, qc, f, &f->pkt->pn_node.key);
}
TRACE_LEAVE(QUIC_EV_CONN_PRSAFRM, qc);
@@ -1509,16 +1502,9 @@
* the current one.
*/
list_for_each_entry_safe(f, tmp, &origin->reflist, ref) {
- if (f->pkt) {
- pn = f->pkt->pn_node.key;
- TRACE_DEVEL("mark frame as acked from packet",
- QUIC_EV_CONN_PRSAFRM, qc, f, &pn);
- }
- else {
- /* XXX TODO: what must be done for such a frame */
- TRACE_DEVEL("mark frame as acked for unsent frame",
- QUIC_EV_CONN_PRSAFRM, qc, f);
- }
+ pn = f->pkt->pn_node.key;
+ TRACE_DEVEL("mark frame as acked from packet",
+ QUIC_EV_CONN_PRSAFRM, qc, f, &pn);
f->flags |= QUIC_FL_TX_FRAME_ACKED;
f->origin = NULL;
LIST_DELETE(&f->ref);