MINOR: server: remove idle lock in srv_cleanup_connections
This function used to grab the idle lock when scanning the threads for
idle connections, but it doesn't need it since the lock only protects
the tree. Let's remove it.
diff --git a/src/server.c b/src/server.c
index 81f4e46..1e9f46e 100644
--- a/src/server.c
+++ b/src/server.c
@@ -5222,7 +5222,6 @@
int i;
/* check all threads starting with ours */
- HA_SPIN_LOCK(OTHER_LOCK, &idle_conn_srv_lock);
for (i = tid;;) {
did_remove = 0;
if (srv_migrate_conns_to_remove(&srv->idle_conns[i], &idle_conns[i].toremove_conns, -1) > 0)
@@ -5235,7 +5234,6 @@
if ((i = ((i + 1 == global.nbthread) ? 0 : i + 1)) == tid)
break;
}
- HA_SPIN_UNLOCK(OTHER_LOCK, &idle_conn_srv_lock);
}
struct task *srv_cleanup_idle_connections(struct task *task, void *context, unsigned short state)