tree 4cba1e2ffa3afd1be23d71be89964771e6ca6c94
parent 4297363de3985d0b0bd55f03420c3db200ef43da
author Willy Tarreau <w@1wt.eu> 1592460899 +0200
committer Willy Tarreau <w@1wt.eu> 1592461542 +0200
encoding latin1

MINOR: fd: factorize the fd_takeover() exit path to make it safer

Since there was a risk of leaving fd_takeover() without properly
stopping the fd, let's take this opportunity for factoring the code
around a commont exit point that's common to both double-cas and locked
modes. This means using the "ret" variable inside the double-CAS code,
and inverting the loop to first test the old values. Doing do also
produces cleaner code because the compiler cannot factorize common
exit paths using asm statements that are present in some atomic ops.