tree 9fa07ea384f1193855b410ee5987d5ab03363dc2
parent ed0832b66b44d3d6367c1e51d83ccea8a8a5d506
author Willy Tarreau <w@1wt.eu> 1582383333 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1582885493 +0100

BUILD: ebtree: improve architecture-specific alignment

Commit 2c315ee75e ("BUG/MEDIUM: ebtree: don't set attribute packed
without unaligned access support") addressed alignment issues in
ebtrees in a way that is not really optimal since it will leave holes
in eb32trees for example.

This fix is better in that it restores the packed attribute on ebnode
but enforces proper alignment on the carrying nodes where necessary.
This also has the benefit of closing holes wherever possible and to
align data to the minimally required size.

The only thing it cannot close is the 32-bit hole at the end of ebmbnode
due to the required 64-bit on certain archs but at least it guarantees
that the key correctly points to the end of the node and that there is
never a hole after it.

This is a better fix than the one above and should be backported to
branches where the one above will be backported.

(cherry picked from commit 41136de58ef2a8f8fc1fa0f202a161eb7fe2c92d)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 8279ed94a269fbbdd07b08741ba42107070bdd32)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>