BUG/MEDIUM: threads/vars: Fix deadlock in register_name
In register_name, before locking the var_names array, we check the variable name
validity. So if we try to register an invalid or empty name, we need to return
without unlocking it (because it was never locked).
This patch must be backported in 1.8.
diff --git a/src/vars.c b/src/vars.c
index c8aa5ac..566ead6 100644
--- a/src/vars.c
+++ b/src/vars.c
@@ -174,8 +174,7 @@
/* Check length. */
if (len == 0) {
memprintf(err, "Empty variable name cannot be accepted");
- res = NULL;
- goto end;
+ return res;
}
/* Check scope. */
@@ -207,8 +206,7 @@
else {
memprintf(err, "invalid variable name '%s'. A variable name must be start by its scope. "
"The scope can be 'proc', 'sess', 'txn', 'req' or 'res'", name);
- res = NULL;
- goto end;
+ return res;
}
if (alloc)