commit eb221131a6d85375d0bac531dd663c9670b548b4
author Christopher Faulet <cfaulet@haproxy.com> Tue Mar 16 11:21:04 2021 +0100
committer Christopher Faulet <cfaulet@haproxy.com> Thu Mar 18 14:49:00 2021 +0100
tree 06858205ae401f55557fdb31325dcd939bb289d8
parent 9469af06c3dcf1d838eed48ec9e9ab4c1995ac70

BUG/MINOR: resolvers: Add missing case-insensitive comparisons of DNS hostnames

DNS hostname comparisons were fixed to be case-insensitive (see b17b88487
"BUG/MEDIUM: dns: Consider the fact that dns answers are
case-insensitive"). However 2 comparisons are still case-sensitive.

This patch must be backported as far as 1.8.

(cherry picked from commit 59b29257338f8e7fb6def6bddda45d08651ffe1c)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit d31f6942249989e415bf9524ae2835180a32bbad)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e31b387c6955e792f1814b137e1593658fbc3c21)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit f9c7675a74623f68cc0315bed83aa0b32c2a20a0)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

src/server.c

diff --git a/src/server.c b/src/server.c
index 043e664..415dbe4 100644
--- a/src/server.c
+++ b/src/server.c
@@ -4123,7 +4123,7 @@
 		HA_SPIN_LOCK(SERVER_LOCK, &tmpsrv->lock);
 		if ((tmpsrv->hostname_dn == NULL) ||
 		    (srv->hostname_dn_len != tmpsrv->hostname_dn_len) ||
-		    (strcmp(srv->hostname_dn, tmpsrv->hostname_dn) != 0) ||
+		    (strcasecmp(srv->hostname_dn, tmpsrv->hostname_dn) != 0) ||
 		    (srv->puid == tmpsrv->puid)) {
 			HA_SPIN_UNLOCK(SERVER_LOCK, &tmpsrv->lock);
 			continue;
@@ -4202,7 +4202,8 @@
 	resolution = srv->dns_requester->resolution;
 	if (resolution &&
 	    resolution->hostname_dn &&
-	    !strcmp(resolution->hostname_dn, hostname_dn))
+	    resolution->hostname_dn_len == hostname_dn_len &&
+	    strcasecmp(resolution->hostname_dn, hostname_dn) == 0)
 		goto end;
 
 	dns_unlink_resolution(srv->dns_requester);