tree 71f92d8a18900ef14359c6cd9fdb9f59d5c668b8
parent 10a37360c8c5dfc4a65aba81f67ae63fe5fa2161
author Willy Tarreau <w@1wt.eu> 1646240344 +0100
committer Willy Tarreau <w@1wt.eu> 1646241728 +0100
encoding latin1

BUG/MINOR: pool: always align pool_heads to 64 bytes

This is the pool equivalent of commit 97ea9c49f ("BUG/MEDIUM: fd: always
align fdtab[] to 64 bytes"). After a careful code review, it happens that
the pool heads are the other structures allocated with malloc/calloc that
claim to be aligned to a size larger than what the allocator can offer.
While no issue was reported on them, no memset() is performed and no type
is large, this is a problem waiting to happen, so better fix it. In
addition, it's relatively easy to do by storing the allocation address
inside the pool_head itself and use it at free() time. Finally, threads
might benefit from the fact that the caches will really be aligned and
that there will be no false sharing.

This should be backported to all versions where it applies easily.