tree 1ca25858d5541a36ca42aa3bbda9bd9c805340d7
parent f1b11e2d16ae3edd53df1492a17d9ef07322788f
author Willy Tarreau <w@1wt.eu> 1546620177 +0100
committer Willy Tarreau <w@1wt.eu> 1546621609 +0100
encoding latin1

BUG/MEDIUM: cli: make "show sess" really thread-safe

This one used to rely on a few spin locks around lists manipulations
only but 1) there were still a few races (e.g. when aborting, or
between STAT_ST_INIT and STAT_ST_LIST), and 2) after last commit
which dumps htx info it became obvious that dereferencing the buffer
contents is not safe at all.

This patch uses the thread isolation from the rendez-vous point
instead, to guarantee that nothing moves during the dump. It may
make the dump a bit slower but it will be 100% safe.

This fix must be backported to 1.9, and possibly to 1.8 which likely
suffers from the short races above, eventhough they're extremely
hard to trigger.