tree 0bcc3b25c639ece6a3da93b10d4ef07e2ee5cca6
parent b3228c83e320ad168f5b3e6884e771530a68a449
author Willy Tarreau <w@1wt.eu> 1412253014 +0200
committer Willy Tarreau <w@1wt.eu> 1412254584 +0200
encoding latin1

BUG/MEDIUM: check: rule-less tcp-check must detect connect failures

When "option tcp-check" is specified without any tcp-check rules, the
documentation says that it's the same as the default check method. But
the code path is a bit different, and we used to consider that since
the end of rules was reached, the check is always successful regardless
of the connection status.

This patch reorganizes the error detection, and considers the special
case where there's no tcp-check rule as a real L4 check. It also avoids
dereferencing the rule list head as a rule by itself.

While fixing this bug, another one related to the output messages'
accuracy was noticed, it will be fixed in a separate commit and is
much less important.

This bug is also present in 1.5, so this fix must be backported.
(cherry picked from commit ef953953e7f33c6a72c432fce8d47c2d84c69512)