tree 2ba73d02679f5baa7d788d3fc531d9b8e7f0cdfe
parent ef8b8649a6934674cf85ddc76cdb91f2b3fa1124
author Willy Tarreau <w@1wt.eu> 1606816038 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1607933993 +0100

BUG/MINOR: mux-h2/stats: not all GOAWAY frames are errors

The stats on haproxy.org reported ~12k GOAWAY for ~34k connections, with
only 2 protocol errorss. It turns out that the GOAWAY frame counter added
in commit a8879238c ("MINOR: mux-h2: report detected error on stats")
matches a bit too many situations. First it counts those which are not
sent as well as failed retries, second it counts as errors the cases of
attempts to cleanly close, while it's titled "GOAWAY sent on detected
error". Let's address this by moving the counter up one line and excluding
the clean codes.

This can be backported to 2.3.

(cherry picked from commit f965b2ad136b6487571f9a8fb0b3e58f778c002c)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>