MINOR: ssl: Remove unnecessary alloc'ed trash chunk in show ocsp-response
When displaying the content of an OCSP response in the CLI, a buffer is
alloc'ed when a temporary buffer would be enough.
diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 9c08c60..65d0c85 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -7921,30 +7921,18 @@
*/
static int cli_io_handler_show_ocspresponse_detail(struct appctx *appctx)
{
- struct buffer *trash = alloc_trash_chunk();
+ struct buffer *trash = get_trash_chunk();
struct certificate_ocsp *ocsp = appctx->svcctx;
- if (trash == NULL)
- return 1;
-
- if (ssl_ocsp_response_print(&ocsp->response, trash)) {
- free_trash_chunk(trash);
- return 1;
- }
+ if (ssl_ocsp_response_print(&ocsp->response, trash))
+ goto end;
if (applet_putchk(appctx, trash) == -1)
- goto yield;
+ return 0;
+end:
appctx->svcctx = NULL;
- if (trash)
- free_trash_chunk(trash);
return 1;
-
-yield:
- if (trash)
- free_trash_chunk(trash);
-
- return 0;
}
#endif