tree 93e3658cf38d514ef86e7aa59e6c214b826a141e
parent 9c27f36fc373c4285266d4ab7353786e1996d7f9
author Willy Tarreau <w@1wt.eu> 1623910128 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1624007549 +0200

MINOR: mux-h2: obey http-ignore-probes during the preface

We're seeing some browsers setting up multiple connections and closing
some to just keep one. It looks like they do this in case they'd
negotiate H1. This results in aborted prefaces and log pollution about
bad requests and "PR--" in the status flags.

We already have an option to ignore connections with no data, it's called
http-ignore-probes. But it was not used by the H2 mux. However it totally
makes sense to use it during the preface.

This patch changes this so that connections aborted before sending the
preface can avoid being logged.

This should be backported to 2.4 and 2.3 at least, and probably even
as far as 2.0.

(cherry picked from commit ee4684f65b6ea627e34395d254daf7971d3ed90f)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit c23d6d11bc7014b58feed96e91aa55aff3d03a2e)
[wt: s/HA_ATOMIC_INC/HA_ATOMIC_ADD]
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit dceef4d9fc5e74964d57a0a772a46fdd7746feff)
[cf: conn_proto_err counter does not exist, thus the increment is removed]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit f75cb48bdcc252fe48acb977ef4a801fc290bea5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>