tree 0a90d3ddd51be772cb3306b01307fc4dfb724956
parent 0c1e65a7cd260610967484bf3c258f4b2d656409
author Willy Tarreau <w@1wt.eu> 1715782943 +0200
committer Amaury Denoyelle <adenoyelle@haproxy.com> 1718013330 +0200

BUG/MEDIUM: stick-tables: properly mark stktable_data as packed

The stktable_data union is made of types of varying sizes, and depending
on which types are stored in a table, some offsets might not necessarily
be aligned. This results in a bus error for certain regtests (e.g.
lb-services) on MIPS64. This bug may impact MIPS64, SPARC64, armv7 when
accessing a 64-bit counter (e.g. bytes) and depending on how the compiler
emitted the operation, and cause a trap that's emulated by the OS on RISCV
(heavy cost). x86_64 and armv8 are not affected at all.

Let's properly mark the struct with __attribute__((packed)) so that the
compiler emits the suitable unaligned-compatible instructions when
accessing the fields.

This should be backported to all versions where it applies.

(cherry picked from commit 845fb846c74f3bd5b6fafec5b062b6c786affbdf)
Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
(cherry picked from commit e213ac589c2c8656d50bf2b7cc44eac1b5fffcd9)
Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
(cherry picked from commit d7cf43bd968109c298392abdd1c9625f9ff90936)
Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
(cherry picked from commit 4c6d38b66499638128e53c9f0f59ab36ca3c4d40)
 [ad: context adjustment]
Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>