BUG/MINOR: http: Missing calloc return value check while parsing redirect rule
A memory allocation failure happening in http_parse_redirect_rule when
trying to allocate a redirect_rule structure would have resulted in a
crash. This function is only called during configuration parsing.
It was raised in GitHub issue #1233.
It could be backported to all stable branches.
(cherry picked from commit b6864a5b6fa1ea6eb224710d00c897105b9e2a46)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
diff --git a/src/http_rules.c b/src/http_rules.c
index 3186036..6ad1e9c 100644
--- a/src/http_rules.c
+++ b/src/http_rules.c
@@ -408,6 +408,10 @@
}
rule = calloc(1, sizeof(*rule));
+ if (!rule) {
+ memprintf(errmsg, "parsing [%s:%d]: out of memory.", file, linenum);
+ return NULL;
+ }
rule->cond = cond;
LIST_INIT(&rule->rdr_fmt);