MINOR: chunk: make chunk_initstr() take a const string
chunk_initstr() prepares a read-only chunk from a string of
fixed length. Thus it must be prepared to accept a read-only
string on the input, otherwise the caller has to force-cast
some const char* and that's not a good idea.
(cherry picked from commit 70af633ebe8627fdf6b448f96c0e457adc93b1d1)
[wt: not strictly needed but backported to ensure that any future patch
relying on it works as expected]
(cherry picked from commit 7d16f278c6f2332439c7ddfbd939fbc48ddb5450)
diff --git a/include/common/chunk.h b/include/common/chunk.h
index b6433b8..9166f60 100644
--- a/include/common/chunk.h
+++ b/include/common/chunk.h
@@ -76,9 +76,10 @@
return 1;
}
-static inline void chunk_initstr(struct chunk *chk, char *str)
+/* this is only for temporary manipulation, the chunk is read-only */
+static inline void chunk_initstr(struct chunk *chk, const char *str)
{
- chk->str = str;
+ chk->str = (char *)str;
chk->len = strlen(str);
chk->size = 0; /* mark it read-only */
}