tree 852e63fc242455cbac0acb1523a0e3ea20eb6547
parent 4423cf2e5976e705a45fba6ca44797850de102b8
author Valentine Krasnobaeva <vkrasnobaeva@haproxy.com> 1723194341 +0200
committer Willy Tarreau <w@1wt.eu> 1725550251 +0200
encoding latin1

BUG/MINOR: proto_uxst: delete fd from fdtab if listen() fails

This patch is done mostly as a safeguard in order not to trigger
BUG_ON(fdtab[fd].owner != NULL) check, if listen() will fail on UNIX domain
socket.

In uxst_bind_listener(), the pretty same logic of closing socket on error path
was kept, as it was in tcp_bind_listener() before. The use of fd_delete() was
not generalized, when the support of UNIX sock_stream protocol was implemented.
So, let's remove fd from fdtab on failure, instead of closing it. Otherwise,
uxst_bind_listener(), which could be called in loop for each receiver, will
obtain the same fd via socket() for the next receiver. Then, it will bind it
again and it will try to re-insert it in fdtab.

This can be backported to all stable versions.

(cherry picked from commit eb8235869027fe6f472160febb6edb169f38d1ee)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 317e918193b5e133043d82cca29a682f74f9a032)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 3c4913cb5cbbc2628dd286cddc2e1b1aec2e4bb9)
Signed-off-by: Willy Tarreau <w@1wt.eu>