tree 502da101d4c5de25dc37233bbcbdafb6bc37d04c
parent f0f42389772b2303b162e929449a36b33e181c5f
author Willy Tarreau <w@1wt.eu> 1563979502 +0200
committer Willy Tarreau <w@1wt.eu> 1563979502 +0200
encoding latin1

BUG/MEDIUM: protocols: add a global lock for the init/deinit stuff

Dragan Dosen found that the listeners lock is not sufficient to protect
the listeners list when proxies are stopping because the listeners are
also unlinked from the protocol list, and under certain situations like
bombing with soft-stop signals or shutting down many frontends in parallel
from multiple CLI connections, it could be possible to provoke multiple
instances of delete_listener() to be called in parallel for different
listeners, thus corrupting the protocol lists.

Such operations are pretty rare, they are performed once per proxy upon
startup and once per proxy on shut down. Thus there is no point trying
to optimize anything and we can use a global lock to protect the protocol
lists during these manipulations.

This fix (or a variant) will have to be backported as far as 1.8.