tree 2167e820f55b407c17ec7f4a4d3a7535a91d4689
parent 00a15025bea006e4cf4f7ca57be066acb2d868f8
author Willy Tarreau <w@1wt.eu> 1637339141 +0100
committer Willy Tarreau <w@1wt.eu> 1637346313 +0100
encoding latin1

BUG/MEDIUM: cache/cli: make "show cache" thread-safe

The "show cache" command restarts from the previous node to look for a
duplicate key, but does this after having released the lock, so under
high write load, the node has many chances of having been reassigned
and the dereference of the node crashes after a few iterations. Since
the keys are unique anyway, there's no point looking for a dup, so
let's just continue from the next value.

This is only marked as medium as it seems to have been there for a
while, and discovering it that late simply means that nobody uses that
command, thus in practice it has a very limited impact on real users.

This should be backported to all stable versions.