BUG/MEDIUM: grpc: Fix several unaligned 32/64 bits accesses
There were several places in grpc and its dependency protobuf where unaligned
accesses were done. Read accesses to 32 (resp. 64) bits values should be performed
by read_u32() (resp. read_u64()).
Replace these unligned read accesses by correct calls to these functions.
Same fixes for doubles and floats.
Such unaligned read accesses could lead to crashes with bus errors on CPU
archictectures which do not fix them at run time.
This patch depends on this previous commit:
861199fa71 MINOR: net_helper: Add support for floats/doubles.
Must be backported as far as 2.6.
(cherry picked from commit 98583c42560a082c9d9898ba9e35cbd68ad15815)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 3431b4a2e2444b67fd73f6aaafa007b2c1e5f0d4)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
diff --git a/src/sample.c b/src/sample.c
index 794acb4..a246389 100644
--- a/src/sample.c
+++ b/src/sample.c
@@ -3424,7 +3424,7 @@
while (grpc_left > GRPC_MSG_HEADER_SZ) {
size_t grpc_msg_len, left;
- grpc_msg_len = left = ntohl(*(uint32_t *)(pos + GRPC_MSG_COMPRESS_FLAG_SZ));
+ grpc_msg_len = left = ntohl(read_u32(pos + GRPC_MSG_COMPRESS_FLAG_SZ));
pos += GRPC_MSG_HEADER_SZ;
grpc_left -= GRPC_MSG_HEADER_SZ;