tree 07a95cac6e3068654974687d2df26f854ef01fe2
parent 9f658a554f046f6b386bfa8410cafae0151bda8f
author Willy Tarreau <w@1wt.eu> 1592323094 +0200
committer Willy Tarreau <w@1wt.eu> 1592324740 +0200
encoding latin1

BUG/MINOR: spoe: add missing key length check before checking key names

The spoe parser fails to check that the decoded key length is large
enough to match a given key but it uses the returned length in memcmp().
So returning "ver" could match "version" for example. In addition this
makes clang 10's ASAN complain because the second argument to memcmp()
is the static key which is shorter than the decoded buffer size, which
in practice has no impact.

I'm still not 100% sure the parser is entirely correct because even
with this fix it cannot parse a key whose name matches the beginning
of another one, but in practice this does not happen. Ideally a
preliminary length check before the comparison would be safer.

This needs to be backported as far as 1.7.