tree 1635caddc49bf3f72860614e821098243f52b768
parent 3284dd2d0e60bec261f051e91919fc004d3acbab
author Willy Tarreau <w@1wt.eu> 1563459500 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1563522921 +0200

BUG/MINOR: backend: do not try to install a mux when the connection failed

If si_connect() failed, do not try to install the mux nor to complete
the operations or add the connection to an idle list, and abort quickly
instead. No obvious side effects were identified, but continuing to
allocate some resources after something has already failed seems risky.

This was a result of a prior fix which already wanted to push this code
further : aa089d80b ("BUG/MEDIUM: server: Defer the mux init until after
xprt has been initialized.") but it ought to have pushed it even further
to maintain the error check just after si_connect().

To be backported to 2.0 and 1.9.

(cherry picked from commit 09e0203ef40d2cd42a45a53c53ebc344a1519e50)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>