tree 3c1aa34ce77531a43ebc9cc4e6de7f6b86595776
parent cb4d8c00ab48641fc767459a1f13f20299069184
author Christopher Faulet <cfaulet@haproxy.com> 1625563536 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1625727539 +0200

Revert "MINOR: tcp-act: Add set-src/set-src-port for "tcp-request content" rules"

This reverts commit 19bbbe05629ea947dd60d5b96d96f0066b047b97.

For now, set-src/set-src-port actions are directly performed on the client
connection. Using these actions at the stream level is really a problem with
HTTP connection (See #90) because all requests are affected by this change
and not only the current request. And it is worse with the H2, because
several requests can set their source address into the same connection at
the same time.

It is already an issue when these actions are called from "http-request"
rules. It is safer to wait a bit before adding the support to "tcp-request
content" rules. The solution is to be able to set src/dst address on the
stream and not on the connection when the action if performed from the L7
level..

Reverting the above commit means the issue #1303 is no longer fixed.

This patch must be backported in all branches containing the above commit
(as far as 2.0 for now).

(cherry picked from commit 23048875a4eacf5d7d4450d677cb077e67778b95)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 390f49477159de53d0506cd52bd6ed323febde0a)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 637b026540de4a328da6a214dc29e00906317cdc)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit fcc1dd5fed7e7228c6004ce3a52efc5d39e62006)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>