BUG/MINOR: server: fix potential null gcc error in delete server
gcc still reports a potential null pointer dereference in delete server
function event with a BUG_ON before it. Remove the misleading NULL check
in the for loop which should never happen.
This does not need to be backported.
diff --git a/src/server.c b/src/server.c
index a6c67a0..6728e11 100644
--- a/src/server.c
+++ b/src/server.c
@@ -4563,12 +4563,12 @@
}
else {
struct server *next;
- for (next = be->srv; next && srv != next->next; next = next->next)
- ;
+ for (next = be->srv; srv != next->next; next = next->next) {
+ /* srv cannot be not found since we have already found
+ * it with get_backend_server */
+ BUG_ON(!next);
+ }
- /* srv cannot be not found since we have already found it
- * with get_backend_server */
- BUG_ON(!next);
next->next = srv->next;
}