tree 603ef2e0abd51b6926e597aaed9580f8dbc33b6f
parent 95a346073935e8639b41bff8a1f30fc85a1a6598
author Willy Tarreau <w@1wt.eu> 1602232540 +0200
committer Willy Tarreau <w@1wt.eu> 1602260944 +0200
encoding latin1

MEDIUM: listeners: always close master vs worker listeners

Right now in enable_listener(), we used to start all enabled
listeners then kill from the workers those that were for the master.
But this is incomplete. We must also close from the master the
listeners that are solely for workers, and do it before we even
start them. Otherwise we end up with a master responding to the
worker CLI connections if the listener remains in listen mode to
translate the socket's real state.

It doesn't seem like it could have caused bugs in the past because we
used to aggressively mark disabled listeners as LI_ASSIGNED despite
the fact that they were still bound and listening. If this patch were
ever seen as a candidate solution for any obscure bug, be careful in
that it subtly relies on the fact that fd_delete() doesn't close
inherited FDs anymore, otherwise that could break the master's ability
to pass inherited FDs on reloads.